<div dir="ltr">Does this need test coverage of some kind?</div><br><div class="gmail_quote"><div dir="ltr">On Thu, Jun 1, 2017 at 5:14 PM Michael Kruse via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: meinersbur<br>
Date: Thu Jun  1 19:13:49 2017<br>
New Revision: 304502<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=304502&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=304502&view=rev</a><br>
Log:<br>
[CodeGen] Iterate over explicit instruction list for block statements. NFC<br>
<br>
For when statements do not contain all instructions of a BasicBlock<br>
anymore, the block generator needs to go through the explicit list of<br>
instructions it contains.<br>
<br>
Contributed-by: Nandini Singhal <<a href="mailto:cs15mtech01004@iith.ac.in" target="_blank">cs15mtech01004@iith.ac.in</a>><br>
<br>
Differential Revision: <a href="https://reviews.llvm.org/D33653" rel="noreferrer" target="_blank">https://reviews.llvm.org/D33653</a><br>
<br>
Modified:<br>
    polly/trunk/include/polly/ScopInfo.h<br>
    polly/trunk/lib/CodeGen/BlockGenerators.cpp<br>
<br>
Modified: polly/trunk/include/polly/ScopInfo.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/polly/trunk/include/polly/ScopInfo.h?rev=304502&r1=304501&r2=304502&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/polly/trunk/include/polly/ScopInfo.h?rev=304502&r1=304501&r2=304502&view=diff</a><br>
==============================================================================<br>
--- polly/trunk/include/polly/ScopInfo.h (original)<br>
+++ polly/trunk/include/polly/ScopInfo.h Thu Jun  1 19:13:49 2017<br>
@@ -1502,6 +1502,10 @@ public:<br>
   Scop *getParent() { return &Parent; }<br>
   const Scop *getParent() const { return &Parent; }<br>
<br>
+  const std::vector<Instruction *> &getInstructions() const {<br>
+    return Instructions;<br>
+  }<br>
+<br>
   const char *getBaseName() const;<br>
<br>
   /// Set the isl AST build.<br>
<br>
Modified: polly/trunk/lib/CodeGen/BlockGenerators.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/polly/trunk/lib/CodeGen/BlockGenerators.cpp?rev=304502&r1=304501&r2=304502&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/polly/trunk/lib/CodeGen/BlockGenerators.cpp?rev=304502&r1=304501&r2=304502&view=diff</a><br>
==============================================================================<br>
--- polly/trunk/lib/CodeGen/BlockGenerators.cpp (original)<br>
+++ polly/trunk/lib/CodeGen/BlockGenerators.cpp Thu Jun  1 19:13:49 2017<br>
@@ -441,8 +441,12 @@ void BlockGenerator::copyBB(ScopStmt &St<br>
                             isl_id_to_ast_expr *NewAccesses) {<br>
   EntryBB = &CopyBB->getParent()->getEntryBlock();<br>
<br>
-  for (Instruction &Inst : *BB)<br>
-    copyInstruction(Stmt, &Inst, BBMap, LTS, NewAccesses);<br>
+  if (Stmt.isBlockStmt())<br>
+    for (Instruction *Inst : Stmt.getInstructions())<br>
+      copyInstruction(Stmt, Inst, BBMap, LTS, NewAccesses);<br>
+  else<br>
+    for (Instruction &Inst : *BB)<br>
+      copyInstruction(Stmt, &Inst, BBMap, LTS, NewAccesses);<br>
 }<br>
<br>
 Value *BlockGenerator::getOrCreateAlloca(const MemoryAccess &Access) {<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>