<div dir="ltr">Should already be fixed, the latest build is green.</div><br><div class="gmail_quote"><div dir="ltr">On Thu, Jun 1, 2017 at 4:47 PM Galina Kistanova <<a href="mailto:gkistanova@gmail.com">gkistanova@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hello Zachary,<br><br>This commit broke one of our builders:<br><br><a href="http://lab.llvm.org:8011/builders/lld-x86_64-darwin13/builds/8784" target="_blank">http://lab.llvm.org:8011/builders/lld-x86_64-darwin13/builds/8784</a><br><br>Please have a look?<br><br>Thanks</div><div dir="ltr"><br><br>Galina<br><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jun 1, 2017 at 2:52 PM, Zachary Turner via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: zturner<br>
Date: Thu Jun  1 16:52:41 2017<br>
New Revision: 304484<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=304484&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=304484&view=rev</a><br>
Log:<br>
[CodeView] Properly align symbol records on read/write.<br>
<br>
Object files have symbol records not aligned to any particular<br>
boundary (e.g. 1-byte aligned), while PDB files have symbol<br>
records padded to 4-byte aligned boundaries.  Since they share<br>
the same reading / writing code, we have to provide an option to<br>
specify the alignment and propagate it up to the producer or<br>
consumer who knows what the alignment is supposed to be for the<br>
given container type.<br>
<br>
Added a test for this by modifying the existing PDB -> YAML -> PDB<br>
round-tripping code to round trip symbol records as well as types.<br>
<br>
Differential Revision: <a href="https://reviews.llvm.org/D33785" rel="noreferrer" target="_blank">https://reviews.llvm.org/D33785</a><br>
<br>
Modified:<br>
    lld/trunk/COFF/PDB.cpp<br>
<br>
Modified: lld/trunk/COFF/PDB.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/COFF/PDB.cpp?rev=304484&r1=304483&r2=304484&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/COFF/PDB.cpp?rev=304484&r1=304483&r2=304484&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/COFF/PDB.cpp (original)<br>
+++ lld/trunk/COFF/PDB.cpp Thu Jun  1 16:52:41 2017<br>
@@ -157,7 +157,8 @@ static void dumpDebugS(ScopedPrinter &W,<br>
     fatal(EC, "StreamReader.readArray<CVSymbolArray> failed");<br>
<br>
   TypeDatabase TDB(0);<br>
-  CVSymbolDumper SymbolDumper(W, TDB, nullptr, false);<br>
+  CVSymbolDumper SymbolDumper(W, TDB, CodeViewContainer::ObjectFile, nullptr,<br>
+                              false);<br>
   if (auto EC = SymbolDumper.dump(Symbols))<br>
     fatal(EC, "CVSymbolDumper::dump failed");<br>
 }<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>
</blockquote></div>