<div dir="ltr">I just noticed that the patch contained?<div><span style="font-size:12.8px">-static void nullDeref() { *(volatile int *)nullptr = 0; }</span><br style="font-size:12.8px"><span style="font-size:12.8px">+static void nullDeref() { *(volatile int *)0x10 = 0; }</span><br></div><div><span style="font-size:12.8px"><br></span></div><div><span style="font-size:12.8px">Why this was needed? Should I put it back?</span></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, May 24, 2017 at 11:00 AM, Vitaly Buka <span dir="ltr"><<a href="mailto:vitalybuka@google.com" target="_blank">vitalybuka@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Reverted with r303783, should work without it.</div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, May 17, 2017 at 3:40 PM, Reid Kleckner <span dir="ltr"><<a href="mailto:rnk@google.com" target="_blank">rnk@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Right, I discussed this with him. This should go away when that happens, because LLVM's signal handler will work out of the box. For now this disables ASan's signal handlers in the SupportTests binary.</div><div class="m_7340098579790839433HOEnZb"><div class="m_7340098579790839433h5"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, May 17, 2017 at 3:38 PM, Kostya Serebryany <span dir="ltr"><<a href="mailto:kcc@google.com" target="_blank">kcc@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">FTR: Vitaly is planing to change the meaning/syntax/name of <span style="font-size:12.8px">allow_user_segv_handler=1</span></div><div class="m_7340098579790839433m_-4074220150345605449HOEnZb"><div class="m_7340098579790839433m_-4074220150345605449h5"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, May 17, 2017 at 3:23 PM, Reid Kleckner via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rnk<br>
Date: Wed May 17 17:23:20 2017<br>
New Revision: 303311<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=303311&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject?rev=303311&view=rev</a><br>
Log:<br>
Attempt to pacify ASan and UBSan reports in CrashRecovery tests<br>
<br>
Modified:<br>
    llvm/trunk/unittests/Support/C<wbr>rashRecoveryTest.cpp<br>
<br>
Modified: llvm/trunk/unittests/Support/C<wbr>rashRecoveryTest.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/Support/CrashRecoveryTest.cpp?rev=303311&r1=303310&r2=303311&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/llvm/trunk/unittests/Sup<wbr>port/CrashRecoveryTest.cpp?rev<wbr>=303311&r1=303310&r2=303311&vi<wbr>ew=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/unittests/Support/C<wbr>rashRecoveryTest.cpp (original)<br>
+++ llvm/trunk/unittests/Support/C<wbr>rashRecoveryTest.cpp Wed May 17 17:23:20 2017<br>
@@ -17,11 +17,15 @@<br>
 #include <windows.h><br>
 #endif<br>
<br>
+extern "C" const char *__asan_default_options() {<br>
+  return "allow_user_segv_handler=1";<br>
+}<br>
+<br>
 using namespace llvm;<br>
 using namespace llvm::sys;<br>
<br>
 static int GlobalInt = 0;<br>
-static void nullDeref() { *(volatile int *)nullptr = 0; }<br>
+static void nullDeref() { *(volatile int *)0x10 = 0; }<br>
 static void incrementGlobal() { ++GlobalInt; }<br>
 static void llvmTrap() { LLVM_BUILTIN_TRAP; }<br>
<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div>