<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Kostya,<div class=""><br class=""></div><div class="">Everything works for me if I enable <a href="https://reviews.llvm.org/D33472" class="">https://reviews.llvm.org/D33472</a></div><div class=""><br class=""></div><div class="">Why not just use it? The optimization is very obvious, and it does cover many cases.</div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On May 23, 2017, at 5:26 PM, Kostya Serebryany <<a href="mailto:kcc@google.com" class="">kcc@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Please revert this and the previous patch -- the bots are too red. <a href="http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/2055" class="">http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/2055</a><div class="">Then, let's figure out a way forward. </div></div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Tue, May 23, 2017 at 5:19 PM, Kostya Serebryany <span dir="ltr" class=""><<a href="mailto:kcc@google.com" target="_blank" class="">kcc@google.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="">Did you test on Linux? <div class="">There are some related tests that have e.g. "UNSUPPORTED: i386-darwin"<br class=""></div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br class=""><div class="gmail_quote">On Tue, May 23, 2017 at 3:42 PM, George Karpenkov via llvm-commits <span dir="ltr" class=""><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: george.karpenkov<br class="">
Date: Tue May 23 17:42:34 2017<br class="">
New Revision: 303701<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=303701&view=rev" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-pr<wbr class="">oject?rev=303701&view=rev</a><br class="">
Log:<br class="">
Fixes for tests for r303698<br class="">
<br class="">
Modified:<br class="">
llvm/trunk/test/Instrumentatio<wbr class="">n/SanitizerCoverage/coverage.<wbr class="">ll<br class="">
llvm/trunk/test/Instrumentatio<wbr class="">n/SanitizerCoverage/tracing.ll<br class="">
<br class="">
Modified: llvm/trunk/test/Instrumentatio<wbr class="">n/SanitizerCoverage/coverage.<wbr class="">ll<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Instrumentation/SanitizerCoverage/coverage.ll?rev=303701&r1=303700&r2=303701&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-pr<wbr class="">oject/llvm/trunk/test/Instrume<wbr class="">ntation/SanitizerCoverage/<wbr class="">coverage.ll?rev=303701&r1=<wbr class="">303700&r2=303701&view=diff</a><br class="">
==============================<wbr class="">==============================<wbr class="">==================<br class="">
--- llvm/trunk/test/Instrumentatio<wbr class="">n/SanitizerCoverage/coverage.<wbr class="">ll (original)<br class="">
+++ llvm/trunk/test/Instrumentatio<wbr class="">n/SanitizerCoverage/coverage.<wbr class="">ll Tue May 23 17:42:34 2017<br class="">
@@ -54,7 +54,7 @@ entry:<br class="">
; CHECK_WITH_CHECK: ret void<br class="">
; CHECK_WITH_CHECK-LABEL: define internal void @sancov.module_ctor<br class="">
; CHECK_WITH_CHECK-NOT: ret<br class="">
-; CHECK_WITH_CHECK: call void @__sanitizer_cov_module_init({<wbr class="">{.*}}, i64 3,<br class="">
+; CHECK_WITH_CHECK: call void @__sanitizer_cov_module_init({<wbr class="">{.*}}, i64 4,<br class="">
; CHECK_WITH_CHECK: ret<br class="">
<br class="">
; CHECK2-LABEL: define void @foo<br class="">
@@ -68,7 +68,7 @@ entry:<br class="">
<br class="">
; CHECK2-LABEL: define internal void @sancov.module_ctor<br class="">
; CHECK2-NOT: ret<br class="">
-; CHECK2: call void @__sanitizer_cov_module_init({<wbr class="">{.*}}, i64 3,<br class="">
+; CHECK2: call void @__sanitizer_cov_module_init({<wbr class="">{.*}}, i64 4,<br class="">
; CHECK2: ret<br class="">
<br class="">
; CHECK3-LABEL: define void @foo<br class="">
@@ -76,6 +76,7 @@ entry:<br class="">
; CHECK3: call void @__sanitizer_cov<br class="">
; CHECK3-NOT: ret void<br class="">
; CHECK3: call void @__sanitizer_cov<br class="">
+; CHECK3: call void @__sanitizer_cov<br class="">
; CHECK3-NOT: call void @__sanitizer_cov<br class="">
; CHECK3: ret void<br class="">
<br class="">
@@ -111,5 +112,6 @@ entry:<br class="">
; CHECKPRUNE: call void @__sanitizer_cov<br class="">
; CHECKPRUNE: call void @__sanitizer_cov<br class="">
; CHECKPRUNE: call void @__sanitizer_cov<br class="">
+; CHECKPRUNE: call void @__sanitizer_cov<br class="">
; CHECKPRUNE-NOT: call void @__sanitizer_cov<br class="">
; CHECKPRUNE: ret void<br class="">
<br class="">
Modified: llvm/trunk/test/Instrumentatio<wbr class="">n/SanitizerCoverage/tracing.ll<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Instrumentation/SanitizerCoverage/tracing.ll?rev=303701&r1=303700&r2=303701&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-pr<wbr class="">oject/llvm/trunk/test/Instrume<wbr class="">ntation/SanitizerCoverage/<wbr class="">tracing.ll?rev=303701&r1=<wbr class="">303700&r2=303701&view=diff</a><br class="">
==============================<wbr class="">==============================<wbr class="">==================<br class="">
--- llvm/trunk/test/Instrumentatio<wbr class="">n/SanitizerCoverage/tracing.ll (original)<br class="">
+++ llvm/trunk/test/Instrumentatio<wbr class="">n/SanitizerCoverage/tracing.ll Tue May 23 17:42:34 2017<br class="">
@@ -22,6 +22,7 @@ entry:<br class="">
; CHECK_PC: call void @__sanitizer_cov_trace_pc<br class="">
; CHECK_PC: call void @__sanitizer_cov_trace_pc<br class="">
; CHECK_PC: call void @__sanitizer_cov_trace_pc<br class="">
+; CHECK_PC: call void @__sanitizer_cov_trace_pc<br class="">
; CHECK_PC-NOT: call void @__sanitizer_cov_trace_pc<br class="">
; CHECK_PC: ret void<br class="">
; CHECK_PC-NOT: call void @__sanitizer_cov_module_init<br class="">
@@ -30,6 +31,7 @@ entry:<br class="">
; CHECK_PC_GUARD: call void @__sanitizer_cov_trace_pc_guar<wbr class="">d<br class="">
; CHECK_PC_GUARD: call void @__sanitizer_cov_trace_pc_guar<wbr class="">d<br class="">
; CHECK_PC_GUARD: call void @__sanitizer_cov_trace_pc_guar<wbr class="">d<br class="">
+; CHECK_PC_GUARD: call void @__sanitizer_cov_trace_pc_guar<wbr class="">d<br class="">
; CHECK_PC_GUARD-NOT: call void @__sanitizer_cov_trace_pc<br class="">
; CHECK_PC_GUARD: ret void<br class="">
; CHECK_PC_GUARD: call void @__sanitizer_cov_trace_pc_guar<wbr class="">d_init(i32* bitcast (i32** @__start___sancov_guards to i32*), i32* bitcast (i32** @__stop___sancov_guards to i32*))<br class="">
@@ -38,6 +40,7 @@ entry:<br class="">
; CHECK_PC_GUARD_DARWIN: call void @__sanitizer_cov_trace_pc_guar<wbr class="">d<br class="">
; CHECK_PC_GUARD_DARWIN: call void @__sanitizer_cov_trace_pc_guar<wbr class="">d<br class="">
; CHECK_PC_GUARD_DARWIN: call void @__sanitizer_cov_trace_pc_guar<wbr class="">d<br class="">
+; CHECK_PC_GUARD_DARWIN: call void @__sanitizer_cov_trace_pc_guar<wbr class="">d<br class="">
; CHECK_PC_GUARD_DARWIN-NOT: call void @__sanitizer_cov_trace_pc<br class="">
; CHECK_PC_GUARD_DARWIN: ret void<br class="">
; CHECK_PC_GUARD_DARWIN: call void @__sanitizer_cov_trace_pc_guar<wbr class="">d_init(i32* bitcast (i32** @"\01section$start$__DATA$__sa<wbr class="">ncov_guards" to i32*), i32* bitcast (i32** @"\01section$end$__DATA$__sanc<wbr class="">ov_guards" to i32*))<br class="">
<br class="">
<br class="">
______________________________<wbr class="">_________________<br class="">
llvm-commits mailing list<br class="">
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/<wbr class="">mailman/listinfo/llvm-commits</a><br class="">
</blockquote></div><br class=""></div>
</div></div></blockquote></div><br class=""></div>
</div></blockquote></div><br class=""></div></body></html>