<div dir="ltr">Thanks Davide, good idea.<div><br></div><div>Thanks</div><div><br></div><div>Galina</div><div><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, May 18, 2017 at 11:19 AM, Davide Italiano <span dir="ltr"><<a href="mailto:davide@freebsd.org" target="_blank">davide@freebsd.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Thu, May 18, 2017 at 10:53 AM, Galina Kistanova via llvm-commits<br>
<<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br>
> Author: gkistanova<br>
> Date: Thu May 18 12:53:47 2017<br>
> New Revision: 303365<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=303365&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=303365&view=rev</a><br>
> Log:<br>
> Reduce gcc-7 warnings by fall-through comments.<br>
><br>
> Modified:<br>
>     llvm/trunk/lib/Demangle/<wbr>ItaniumDemangle.cpp<br>
><br>
> Modified: llvm/trunk/lib/Demangle/<wbr>ItaniumDemangle.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Demangle/ItaniumDemangle.cpp?rev=303365&r1=303364&r2=303365&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/lib/<wbr>Demangle/ItaniumDemangle.cpp?<wbr>rev=303365&r1=303364&r2=<wbr>303365&view=diff</a><br>
> ==============================<wbr>==============================<wbr>==================<br>
> --- llvm/trunk/lib/Demangle/<wbr>ItaniumDemangle.cpp (original)<br>
> +++ llvm/trunk/lib/Demangle/<wbr>ItaniumDemangle.cpp Thu May 18 12:53:47 2017<br>
> @@ -1947,7 +1947,7 @@ static const char *parse_type(const char<br>
>                break;<br>
>              }<br>
>            }<br>
> -        // drop through<br>
> +        // falls through<br>
<br>
</span>I don' think this is the best way to fix this warning. You might<br>
consider using LLVM_FALLTRHOUGH (which will expand to<br>
[[gnu::fallthrough]] in this case). See the recent changes in `lld`<br>
for an example.<br>
<br>
Thanks!<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
Davide<br>
<br>
"There are no solved problems; there are only problems that are more<br>
or less solved" -- Henri Poincare<br>
</font></span></blockquote></div><br></div></div>