<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="" applecontenteditable="true">Hi Leo,<div class=""><br class=""></div><div class="">I think Filipe had a question about something in here, --</div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On May 17, 2017, at 10:17 AM, Leo Li via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">Author: aoli<br class="">Date: Wed May 17 12:17:41 2017<br class="">New Revision: 303276<br class=""><br class="">URL: <a href="http://llvm.org/viewvc/llvm-project?rev=303276&view=rev" class="">http://llvm.org/viewvc/llvm-project?rev=303276&view=rev</a><br class="">Log:<br class="">Generate ubsan shared libraries.<br class=""><br class="">Summary: Those libraries are required by aosp (<a href="https://android.googlesource.com/platform/prebuilts/clang/host/linux-x86/+/master/Android.mk" class="">https://android.googlesource.com/platform/prebuilts/clang/host/linux-x86/+/master/Android.mk</a>). Currenly the shared libraries are generated by aosp Makefile system. We are looking forward to using cmake to generate them.<br class=""><br class="">Reviewers: llvm-commits, vsk<br class=""><br class="">Reviewed By: vsk<br class=""><br class="">Subscribers: filcab, vsk, srhines, kubamracek, mgorny, krytarowski<br class=""><br class="">Differential Revision: <a href="https://reviews.llvm.org/D33216" class="">https://reviews.llvm.org/D33216</a><br class=""><br class="">Modified:<br class=""> compiler-rt/trunk/lib/ubsan/CMakeLists.txt<br class=""><br class="">Modified: compiler-rt/trunk/lib/ubsan/CMakeLists.txt<br class="">URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/ubsan/CMakeLists.txt?rev=303276&r1=303275&r2=303276&view=diff" class="">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/ubsan/CMakeLists.txt?rev=303276&r1=303275&r2=303276&view=diff</a><br class="">==============================================================================<br class="">--- compiler-rt/trunk/lib/ubsan/CMakeLists.txt (original)<br class="">+++ compiler-rt/trunk/lib/ubsan/CMakeLists.txt Wed May 17 12:17:41 2017<br class="">@@ -34,6 +34,14 @@ set(UBSAN_CXXFLAGS ${SANITIZER_COMMON_CF<br class=""> append_rtti_flag(ON UBSAN_CXXFLAGS)<br class=""> append_list_if(SANITIZER_CAN_USE_CXXABI -DUBSAN_CAN_USE_CXXABI UBSAN_CXXFLAGS)<br class=""><br class="">+append_list_if(COMPILER_RT_HAS_LIBDL dl UBSAN_DYNAMIC_LIBS)<br class="">+append_list_if(COMPILER_RT_HAS_LIBLOG log UBSAN_DYNAMIC_LIBS)<br class="">+append_list_if(COMPILER_RT_HAS_LIBC c UBSAN_DYNAMIC_LIBS)<br class="">+append_list_if(COMPILER_RT_HAS_LIBRT rt UBSAN_DYNAMIC_LIBS)<br class="">+append_list_if(COMPILER_RT_HAS_LIBM m UBSAN_DYNAMIC_LIBS)<br class="">+append_list_if(COMPILER_RT_HAS_LIBPTHREAD pthread UBSAN_DYNAMIC_LIBS)<br class="">+append_list_if(COMPILER_RT_HAS_LIBSTDCXX stdc++ UBSAN_DYNAMIC_LIBS)<br class=""></div></div></blockquote><div><br class=""></div>^ "<span style="color: rgb(70, 76, 92); font-family: 'Segoe UI', 'Segoe UI Emoji', 'Segoe UI Symbol', Lato, 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 13px; background-color: rgb(255, 255, 255);" class="">I wouldn't expect the non-c++ version of the lib to bring libstdc++ with it."</span></div><div><font color="#464c5c" face="Segoe UI, Segoe UI Emoji, Segoe UI Symbol, Lato, Helvetica Neue, Helvetica, Arial, sans-serif" size="2" class=""><span style="background-color: rgb(255, 255, 255);" class=""><br class=""></span></font></div><div><font color="#464c5c" face="Segoe UI, Segoe UI Emoji, Segoe UI Symbol, Lato, Helvetica Neue, Helvetica, Arial, sans-serif" size="2" class=""><span style="background-color: rgb(255, 255, 255);" class="">I agree. What do you think?</span></font></div><div><font color="#464c5c" face="Segoe UI, Segoe UI Emoji, Segoe UI Symbol, Lato, Helvetica Neue, Helvetica, Arial, sans-serif" size="2" class=""><span style="background-color: rgb(255, 255, 255);" class=""><br class=""></span></font></div><div><font color="#464c5c" face="Segoe UI, Segoe UI Emoji, Segoe UI Symbol, Lato, Helvetica Neue, Helvetica, Arial, sans-serif" size="2" class=""><span style="background-color: rgb(255, 255, 255);" class="">vedant</span></font></div><div><font color="#464c5c" face="Segoe UI, Segoe UI Emoji, Segoe UI Symbol, Lato, Helvetica Neue, Helvetica, Arial, sans-serif" size="2" class=""><span style="background-color: rgb(255, 255, 255);" class=""><br class=""></span></font><blockquote type="cite" class=""><div class=""><div class="">+ <br class=""> add_compiler_rt_component(ubsan)<br class=""><br class=""> if(APPLE)<br class="">@@ -144,6 +152,27 @@ else()<br class=""> CFLAGS ${UBSAN_CXXFLAGS}<br class=""> PARENT_TARGET ubsan)<br class=""><br class="">+ add_compiler_rt_runtime(clang_rt.ubsan_standalone<br class="">+ SHARED<br class="">+ ARCHS ${UBSAN_SUPPORTED_ARCH}<br class="">+ OBJECT_LIBS RTSanitizerCommon<br class="">+ RTSanitizerCommonLibc<br class="">+ RTUbsan<br class="">+ CFLAGS ${UBSAN_CFLAGS}<br class="">+ LINK_LIBS ${UBSAN_DYNAMIC_LIBS}<br class="">+ PARENT_TARGET ubsan)<br class="">+<br class="">+ add_compiler_rt_runtime(clang_rt.ubsan_standalone_cxx<br class="">+ SHARED<br class="">+ ARCHS ${UBSAN_SUPPORTED_ARCH}<br class="">+ OBJECT_LIBS RTSanitizerCommon<br class="">+ RTSanitizerCommonLibc<br class="">+ RTUbsan<br class="">+ RTUbsan_cxx<br class="">+ CFLAGS ${UBSAN_CXXFLAGS}<br class="">+ LINK_LIBS ${UBSAN_DYNAMIC_LIBS}<br class="">+ PARENT_TARGET ubsan)<br class="">+<br class=""> if (UNIX)<br class=""> set(ARCHS_FOR_SYMBOLS ${UBSAN_SUPPORTED_ARCH})<br class=""> list(REMOVE_ITEM ARCHS_FOR_SYMBOLS i386 i686)<br class=""><br class=""><br class="">_______________________________________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a><br class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits<br class=""></div></div></blockquote></div><br class=""></div></body></html>