<div dir="ltr">Unless someone can explain how the patches I committed caused the bot failure, I think I'm going to assume it was a random failure and recommit the patches today.<br><div class="gmail_extra"><br><div class="gmail_quote">On Sun, May 14, 2017 at 11:50 PM, Akira Hatanaka <span dir="ltr"><<a href="mailto:ahatanak@gmail.com" target="_blank">ahatanak@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">The bot turned green after I reverted the two patches.<div><br></div><div>I looked at the command again and I still don't understand how the changes I made to src/__cxa_exception.hpp caused the libcxx test to fail.</div><div><br></div><div><span style="color:rgb(0,0,0);font-family:"courier new",courier,monotype,monospace;font-size:medium">******************** TEST 'libc++ :: std/experimental/utilities/pro<wbr>pagate_const/propagate_const.<wbr>class/propagate_const.ctors/<wbr>convertible_propagate_const.<wbr>explicit.move_ctor.pass.cpp' FAILED ********************</span><br></div><div><div class="gmail_extra"><pre style="font-family:"courier new",courier,monotype,monospace;color:rgb(0,0,0);font-size:medium"><span class="m_1340863699914607469m_-413006741040801200gmail-stdout">Command: ['/usr/bin/clang++', '-o', '/home/buildslave/buildslave/l<wbr>ibcxx-libcxxabi-libunwind-aarc<wbr>h64-linux/build/projects/libcx<wbr>x/test/std/experimental/utilit<wbr>ies/propagate_const/propagate_<wbr>const.class/propagate_const.<wbr>ctors/Output/convertible_<wbr>propagate_const.explicit.move_<wbr>ctor.pass.cpp.o', '-x', 'c++', '/home/buildslave/buildslave/l<wbr>ibcxx-libcxxabi-libunwind-aarc<wbr>h64-linux/llvm/projects/libcxx<wbr>/test/std/experimental/utiliti<wbr>es/propagate_const/propagate_<wbr>const.class/propagate_const.<wbr>ctors/convertible_propagate_<wbr>const.explicit.move_ctor.pass.<wbr>cpp', '-c', '-v', '-D_LIBCPP_DISABLE_AVAILABILIT<wbr>Y', '-Werror=thread-safety', '-std=c++1z', '-include', '/home/buildslave/buildslave/l<wbr>ibcxx-libcxxabi-libunwind-aarc<wbr>h64-linux/llvm/projects/libcxx<wbr>/test/support/nasty_macros.<wbr>hpp', '-nostdinc++', '-I/home/buildslave/buildslave<wbr>/libcxx-libcxxabi-libunwind-<wbr>aarch64-linux/llvm/projects/<wbr>libcxx/include', '-I/home/buildslave/buildslave<wbr>/libcxx-libcxxabi-libunwind-<wbr>aarch64-linux/build/projects/<wbr>libcxx/include/c++build', '-D__STDC_FORMAT_MACROS', '-D__STDC_LIMIT_MACROS', '-D__STDC_CONSTANT_MACROS', '-I/home/buildslave/buildslave<wbr>/libcxx-libcxxabi-libunwind-<wbr>aarch64-linux/llvm/projects/<wbr>libcxx/test/support', '-DLIBCXX_FILESYSTEM_STATIC_TE<wbr>ST_ROOT="/home/buildslave/buil<wbr>dslave/libcxx-libcxxabi-libunw<wbr>ind-aarch64-linux/llvm/project<wbr>s/libcxx/test/std/experimental<wbr>/filesystem/Inputs/static_<wbr>test_env"', '-DLIBCXX_FILESYSTEM_DYNAMIC_T<wbr>EST_ROOT="/home/buildslave/bui<wbr>ldslave/libcxx-libcxxabi-libun<wbr>wind-aarch64-linux/build/proje<wbr>cts/libcxx/test/filesystem/<wbr>Output/dynamic_env"', '-DLIBCXX_FILESYSTEM_DYNAMIC_T<wbr>EST_HELPER="/usr/bin/python2.7 /home/buildslave/buildslave/li<wbr>bcxx-libcxxabi-libunwind-aarch<wbr>64-linux/llvm/projects/libcxx/<wbr>test/support/filesystem_<wbr>dynamic_test_helper.py"', '-D_LIBCPP_HAS_NO_PRAGMA_SYSTE<wbr>M_HEADER', '-Wall', '-Wextra', '-Werror', '-Wshadow', '-Wno-unused-command-line-argu<wbr>ment', '-Wno-attributes', '-Wno-pessimizing-move', '-Wno-c++11-extensions', '-Wno-user-defined-literals', '-Wsign-compare', '-Wunused-variable', '-Wunused-parameter', '-Wunreachable-code', '-Wno-conversion', '-Wno-unused-local-typedef', '-Wno-#warnings', '-c']
Exit Code: -11
Compilation failed unexpectedly!
********************</span></pre><div><span class="m_1340863699914607469m_-413006741040801200gmail-stdout"><br></span></div></div></div></div><div class="m_1340863699914607469HOEnZb"><div class="m_1340863699914607469h5"><div class="gmail_extra"><br><div class="gmail_quote">On Sun, May 14, 2017 at 12:01 PM, Akira Hatanaka <span dir="ltr"><<a href="mailto:ahatanak@gmail.com" target="_blank">ahatanak@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Reverted in r303016. Lets see if it turns the bot green and figure out what is causing the failure after that.<div><div class="m_1340863699914607469m_-413006741040801200h5"><div><div class="gmail_extra"><br><div class="gmail_quote">On Sun, May 14, 2017 at 10:50 AM, Renato Golin <span dir="ltr"><<a href="mailto:renato.golin@linaro.org" target="_blank">renato.golin@linaro.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span>On 14 May 2017 at 08:11, Akira Hatanaka <<a href="mailto:ahatanak@gmail.com" target="_blank">ahatanak@gmail.com</a>> wrote:<br>
> The test convertible_propagate_const.ex<wbr>plicit.move_ctor.pass.cpp seems to be<br>
> failing because of a compile error, but it doesn't look like the changes I<br>
> made could have caused it. The patches I committed made changes to<br>
> libcxxabi/cxa_exception.hpp and the failing test doesn't even include it.<br>
<br>
</span>Hi Akira,<br>
<br>
I have to say I have no idea how that test is executed. The build<br>
directory is wiped on every build, so I doubt this is left over from<br>
previous builds.<br>
<span><br>
<br>
> Is it possible to find out how exactly the test failed? There are two<br>
> static_asserts in the file, but since I don't see a static assertion error<br>
> message in the log, I don't think they caused the compile error.<br>
<br>
</span>It is, but I'd rather revert the patch and make sure it wasn't it than<br>
keep trying this while the bot is broken.<br>
<br>
I can help you reproduce as soon as the bot is back green.<br>
<br>
cheers,<br>
--renato<br>
</blockquote></div><br></div></div></div></div></div>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div></div>