<div dir="ltr">I have not checked the history of this test, but it probably should add some inline threshold parameter as you suggested.<div><br></div><div>David</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, May 15, 2017 at 10:00 AM, Jessica Paquette via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Do these tests make any assumptions about the inliner’s behaviour? If so, do you think it would be possible to include inlining thresholds in these tests?<br>
<br>
For example, some of the inliner tests specify -inline-threshold=<wbr>SomeIntegerValue.<br>
<br>
My concern is that changes to the inliner’s cost model might break some of these tests. Threshold values might improve the stability of the tests. They would also make it easier to fix the tests/inliner in the event of cost model changes.<br>
<br>
- Jessica<br>
<div class="HOEnZb"><div class="h5"><br>
> On May 13, 2017, at 7:58 PM, Xinliang David Li via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br>
><br>
> Author: davidxl<br>
> Date: Sat May 13 21:58:39 2017<br>
> New Revision: 303000<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=303000&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=303000&view=rev</a><br>
> Log:<br>
> Renable test that was disabled due to cost analysis<br>
><br>
> Modified:<br>
>    llvm/trunk/test/Transforms/<wbr>Inline/partial-inline-act.ll<br>
><br>
> Modified: llvm/trunk/test/Transforms/<wbr>Inline/partial-inline-act.ll<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/Inline/partial-inline-act.ll?rev=303000&r1=302999&r2=303000&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/test/<wbr>Transforms/Inline/partial-<wbr>inline-act.ll?rev=303000&r1=<wbr>302999&r2=303000&view=diff</a><br>
> ==============================<wbr>==============================<wbr>==================<br>
> --- llvm/trunk/test/Transforms/<wbr>Inline/partial-inline-act.ll (original)<br>
> +++ llvm/trunk/test/Transforms/<wbr>Inline/partial-inline-act.ll Sat May 13 21:58:39 2017<br>
> @@ -1,4 +1,4 @@<br>
> -; RUN: opt < %s -partial-inliner -disable-output<br>
> +; RUN: opt < %s -partial-inliner -skip-partial-inlining-cost-<wbr>analysis -disable-output<br>
> ; This testcase tests the assumption cache<br>
><br>
> define internal i32 @inlinedFunc(i1 %cond, i32* align 4 %align.val) {<br>
><br>
><br>
> ______________________________<wbr>_________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div>