<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, May 10, 2017 at 8:39 PM, David Majnemer <span dir="ltr"><<a href="mailto:david.majnemer@gmail.com" target="_blank" class="cremed">david.majnemer@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div>Test case?</div></blockquote><div><br></div><div>Test case forthcoming. I wanted to run the idea by some reviewers before sinking too much time into it.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><br><div class="gmail_quote"><div><div class="h5"><div>On Wed, May 10, 2017 at 8:13 PM Dean Michael Berris via Phabricator via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="cremed">llvm-commits@lists.llvm.org</a>> wrote:<br></div></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5">dberris added a comment.<br>
<br>
Drive-by-review.<br>
<br>
<br>
<br>
================<br>
Comment at: lib/Transforms/InstCombine/<wbr>InstructionCombining.cpp:2920<br>
+        UsesInOneBlock = true;<br>
+      } else if (CurrentUserParent != UsersParent) {<br>
+        UsesInOneBlock = false;<br>
----------------<br>
Do you actually need the else here? I suspect CurrentUserParent will never be nullptr, and UsersParent will never be nullptr here either after the preceding conditional.<br>
<br>
<br>
================<br>
Comment at: lib/Transforms/InstCombine/<wbr>InstructionCombining.cpp:2927<br>
+<br>
+    if (UsesInOneBlock) {<br>
+      BasicBlock *BB = I->getParent();<br>
----------------<br>
Maybe clearer if you turn this into an early return?<br>
<br>
```<br>
if (!UsesInOneBlock)<br>
  return false;<br>
<br>
// rest of code.<br>
```<br>
<br>
<br>
Repository:<br>
  rL LLVM<br>
<br>
<a href="https://reviews.llvm.org/D33074" rel="noreferrer" target="_blank" class="cremed">https://reviews.llvm.org/<wbr>D33074</a><br>
<br>
<br>
<br></div></div>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="cremed">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="cremed">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div></div>
</blockquote></div><br></div></div>