<div dir="ltr">Weirdly/pedantically, 'explicit' on a multi-arg ctor is actually meaningful. It stops {x, y, z} from compiling for the type (eg: LazyObjectFile func() { return {x, y, z}; } could compile if the ctor was not explicit, but would fail to compile if the ctor was explicit)<br><br>LLVM (& Google too, FWIW) don't apply explicit to every ctor that might be weird/confusing if it were called with {x, y, z} - so, yeah, probably good to remove for consistency - but just figured I'd mention it.</div><br><div class="gmail_quote"><div dir="ltr">On Fri, May 5, 2017 at 12:38 PM Rui Ueyama via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: ruiu<br>
Date: Fri May  5 14:24:58 2017<br>
New Revision: 302273<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=302273&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=302273&view=rev</a><br>
Log:<br>
Remove redundant `explicit`.<br>
<br>
Modified:<br>
    lld/trunk/ELF/InputFiles.h<br>
<br>
Modified: lld/trunk/ELF/InputFiles.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/InputFiles.h?rev=302273&r1=302272&r2=302273&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/InputFiles.h?rev=302273&r1=302272&r2=302273&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/ELF/InputFiles.h (original)<br>
+++ lld/trunk/ELF/InputFiles.h Fri May  5 14:24:58 2017<br>
@@ -219,8 +219,8 @@ private:<br>
 // archive file semantics.<br>
 class LazyObjectFile : public InputFile {<br>
 public:<br>
-  explicit LazyObjectFile(MemoryBufferRef M, StringRef ArchiveName,<br>
-                          uint64_t OffsetInArchive)<br>
+  LazyObjectFile(MemoryBufferRef M, StringRef ArchiveName,<br>
+                 uint64_t OffsetInArchive)<br>
       : InputFile(LazyObjectKind, M), OffsetInArchive(OffsetInArchive) {<br>
     this->ArchiveName = ArchiveName;<br>
   }<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>