<div dir="ltr">Any chance of using std::unique_ptr instead of manual memory management here?</div><br><div class="gmail_quote"><div dir="ltr">On Mon, May 1, 2017 at 9:31 AM Gabor Horvath via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: xazax<br>
Date: Mon May 1 11:18:42 2017<br>
New Revision: 301807<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=301807&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=301807&view=rev</a><br>
Log:<br>
Remove unnecessary conditions as suggested by clang-tidy. NFC<br>
<br>
Patch by: Gergely Angeli!<br>
<br>
Differential Revision: <a href="https://reviews.llvm.org/D31936" rel="noreferrer" target="_blank">https://reviews.llvm.org/D31936</a><br>
<br>
Modified:<br>
llvm/trunk/lib/CodeGen/DFAPacketizer.cpp<br>
llvm/trunk/lib/Support/SourceMgr.cpp<br>
llvm/trunk/lib/Target/TargetLoweringObjectFile.cpp<br>
<br>
Modified: llvm/trunk/lib/CodeGen/DFAPacketizer.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/DFAPacketizer.cpp?rev=301807&r1=301806&r2=301807&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/DFAPacketizer.cpp?rev=301807&r1=301806&r2=301807&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/CodeGen/DFAPacketizer.cpp (original)<br>
+++ llvm/trunk/lib/CodeGen/DFAPacketizer.cpp Mon May 1 11:18:42 2017<br>
@@ -213,10 +213,8 @@ VLIWPacketizerList::VLIWPacketizerList(M<br>
<br>
<br>
VLIWPacketizerList::~VLIWPacketizerList() {<br>
- if (VLIWScheduler)<br>
- delete VLIWScheduler;<br>
- if (ResourceTracker)<br>
- delete ResourceTracker;<br>
+ delete VLIWScheduler;<br>
+ delete ResourceTracker;<br>
}<br>
<br>
<br>
<br>
Modified: llvm/trunk/lib/Support/SourceMgr.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/SourceMgr.cpp?rev=301807&r1=301806&r2=301807&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/SourceMgr.cpp?rev=301807&r1=301806&r2=301807&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Support/SourceMgr.cpp (original)<br>
+++ llvm/trunk/lib/Support/SourceMgr.cpp Mon May 1 11:18:42 2017<br>
@@ -51,9 +51,7 @@ static LineNoCacheTy *getCache(void *Ptr<br>
}<br>
<br>
SourceMgr::~SourceMgr() {<br>
- // Delete the line # cache if allocated.<br>
- if (LineNoCacheTy *Cache = getCache(LineNoCache))<br>
- delete Cache;<br>
+ delete getCache(LineNoCache);<br>
}<br>
<br>
unsigned SourceMgr::AddIncludeFile(const std::string &Filename,<br>
<br>
Modified: llvm/trunk/lib/Target/TargetLoweringObjectFile.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/TargetLoweringObjectFile.cpp?rev=301807&r1=301806&r2=301807&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/TargetLoweringObjectFile.cpp?rev=301807&r1=301806&r2=301807&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Target/TargetLoweringObjectFile.cpp (original)<br>
+++ llvm/trunk/lib/Target/TargetLoweringObjectFile.cpp Mon May 1 11:18:42 2017<br>
@@ -44,7 +44,7 @@ void TargetLoweringObjectFile::Initializ<br>
const TargetMachine &TM) {<br>
Ctx = &ctx;<br>
// `Initialize` can be called more than once.<br>
- if (Mang != nullptr) delete Mang;<br>
+ delete Mang;<br>
Mang = new Mangler();<br>
InitMCObjectFileInfo(TM.getTargetTriple(), TM.isPositionIndependent(),<br>
TM.getCodeModel(), *Ctx);<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>