<div dir="ltr">Two gets passed to sdiv which we don't currently have a uint64_t version of. I might look into that, but the divide code scared me away.</div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature" data-smartmail="gmail_signature">~Craig</div></div>
<br><div class="gmail_quote">On Mon, May 8, 2017 at 10:08 AM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">It's not beneficial to do the same thing for 'Two' as well?</div><br><div class="gmail_quote"><div dir="ltr">On Sun, May 7, 2017 at 10:08 PM Craig Topper via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: ctopper<br>
Date: Sun May  7 23:55:13 2017<br>
New Revision: 302404<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=302404&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=302404&view=rev</a><br>
Log:<br>
[SCEV] Use APInt::operator*=(uint64_t) to avoid a temporary APInt for a constant.<br>
<br>
Modified:<br>
    llvm/trunk/lib/Analysis/<wbr>ScalarEvolution.cpp<br>
<br>
Modified: llvm/trunk/lib/Analysis/<wbr>ScalarEvolution.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/ScalarEvolution.cpp?rev=302404&r1=302403&r2=302404&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/lib/<wbr>Analysis/ScalarEvolution.cpp?<wbr>rev=302404&r1=302403&r2=<wbr>302404&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/lib/Analysis/<wbr>ScalarEvolution.cpp (original)<br>
+++ llvm/trunk/lib/Analysis/<wbr>ScalarEvolution.cpp Sun May  7 23:55:13 2017<br>
@@ -7376,7 +7376,6 @@ SolveQuadraticEquation(const SCEVAddRecE<br>
   const APInt &M = MC->getAPInt();<br>
   const APInt &N = NC->getAPInt();<br>
   APInt Two(BitWidth, 2);<br>
-  APInt Four(BitWidth, 4);<br>
<br>
   {<br>
     using namespace APIntOps;<br>
@@ -7392,7 +7391,7 @@ SolveQuadraticEquation(const SCEVAddRecE<br>
     // Compute the B^2-4ac term.<br>
     APInt SqrtTerm(B);<br>
     SqrtTerm *= B;<br>
-    SqrtTerm -= Four * (A * C);<br>
+    SqrtTerm -= 4 * (A * C);<br>
<br>
     if (SqrtTerm.isNegative()) {<br>
       // The loop is provably infinite.<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div>
</blockquote></div><br></div>