<div dir="ltr"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><span style="font-size:12.800000190734863px">I think of such lambdas as basically programmatic control flow (like an if, while, etc) - so there's no need to explicitly state which variables you'll use within this nested scope.</span></blockquote><div><span style="font-size:12.800000190734863px"><br></span></div><div><span style="font-size:12.800000190734863px">Good idea.</span></div><div><span style="font-size:12.800000190734863px"><br></span></div><div><span style="font-size:12.800000190734863px">This is probably too heavyweight to do as a warning, but some sort of style-checker plugin could suggest using default capture for non-escaping lambdas and explicit capture for may-escape ones.</span></div><div><span style="font-size:12.800000190734863px"><br></span></div><div><span style="font-size:12.800000190734863px">- Lang. </span></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Apr 24, 2017 at 9:13 AM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Generally if a lambda's only going to be used within its own scope - I'd suggest using [&]. I think of such lambdas as basically programmatic control flow (like an if, while, etc) - so there's no need to explicitly state which variables you'll use within this nested scope.</div><div class="HOEnZb"><div class="h5"><br><div class="gmail_quote"><div dir="ltr">On Sun, Apr 23, 2017 at 6:34 PM Lang Hames via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: lhames<br>
Date: Sun Apr 23 20:21:23 2017<br>
New Revision: 301152<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=301152&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=301152&view=rev</a><br>
Log:<br>
[Orc] Fix a warning by removing an unused lambda capture.<br>
<br>
Modified:<br>
llvm/trunk/include/llvm/<wbr>ExecutionEngine/Orc/<wbr>RPCSerialization.h<br>
<br>
Modified: llvm/trunk/include/llvm/<wbr>ExecutionEngine/Orc/<wbr>RPCSerialization.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ExecutionEngine/Orc/RPCSerialization.h?rev=301152&r1=301151&r2=301152&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/include/<wbr>llvm/ExecutionEngine/Orc/<wbr>RPCSerialization.h?rev=301152&<wbr>r1=301151&r2=301152&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/include/llvm/<wbr>ExecutionEngine/Orc/<wbr>RPCSerialization.h (original)<br>
+++ llvm/trunk/include/llvm/<wbr>ExecutionEngine/Orc/<wbr>RPCSerialization.h Sun Apr 23 20:21:23 2017<br>
@@ -378,7 +378,7 @@ public:<br>
return serializeSeq(C, std::string());<br>
<br>
return handleErrors(std::move(Err),<br>
- [&C, &Lock](const ErrorInfoBase &EIB) {<br>
+ [&C](const ErrorInfoBase &EIB) {<br>
auto SI = Serializers.find(EIB.<wbr>dynamicClassID());<br>
if (SI == Serializers.end())<br>
return serializeAsStringError(C, EIB);<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div>
</div></div></blockquote></div><br></div>