<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">
Added the (void)LatchBR; Warning should be fixed now.
<div class=""><br class="">
</div>
<div class="">Thanks</div>
<div class="">Anna<br class="">
<div>
<blockquote type="cite" class="">
<div class="">On May 3, 2017, at 3:34 PM, Craig Topper <<a href="mailto:craig.topper@gmail.com" class="">craig.topper@gmail.com</a>> wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<div dir="ltr" class="">getTerminator() is an out of line function though so it won't be optimized out.</div>
<div class="gmail_extra"><br clear="all" class="">
<div class="">
<div class="gmail_signature" data-smartmail="gmail_signature">~Craig</div>
</div>
<br class="">
<div class="gmail_quote">On Wed, May 3, 2017 at 12:29 PM, Anna Thomas <span dir="ltr" class="">
<<a href="mailto:anna@azul.com" target="_blank" class="">anna@azul.com</a>></span> wrote:<br class="">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word" class="">thanks, I was going to move the LatchBr inside the assert, and perhaps the compiler would common the 2 instances up in fastdebug/debug builds.
<div class=""><br class="">
</div>
<div class="">I’ll follow your idea.</div>
<span class="HOEnZb"><font color="#888888" class="">
<div class=""><br class="">
</div>
<div class=""><br class="">
</div>
</font></span>
<div class=""><span class="HOEnZb"><font color="#888888" class="">Anna</font></span>
<div class="">
<div class="h5"><br class="">
<div class="">
<blockquote type="cite" class="">
<div class="">On May 3, 2017, at 3:25 PM, Davide Italiano <<a href="mailto:davide@freebsd.org" target="_blank" class="">davide@freebsd.org</a>> wrote:</div>
<br class="m_3113098507258412448Apple-interchange-newline">
<div class=""><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important" class="">On
Wed, May 3, 2017 at 12:19 PM, Craig Topper via llvm-commits</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" class="">
<span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important" class=""><</span><a href="mailto:llvm-commits@lists.llvm.org" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" target="_blank" class="">llvm-commits@lists.llvm.org</a><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important" class="">>
wrote:</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" class="">
<blockquote type="cite" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" class="">
The variable LatchBR is unused in Release builds and throws a warning.<br class="">
<br class="">
~Craig<br class="">
<br class="">
</blockquote>
<br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" class="">
<span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important" class="">Adding
(void)LatchBr; immediately after the use should fix the warning</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" class="">
<span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important" class="">as
the variable is only used inside the assert.</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" class="">
<span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important" class="">This
is how we fix these cases, FWIW.</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" class="">
<br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" class="">
<blockquote type="cite" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" class="">
On Wed, May 3, 2017 at 10:44 AM, Anna Thomas via llvm-commits<br class="">
<<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a>> wrote:<br class="">
<blockquote type="cite" class=""><br class="">
Author: annat<br class="">
Date: Wed May 3 12:43:59 2017<br class="">
New Revision: 302058<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=302058&view=rev" target="_blank" class="">
http://llvm.org/viewvc/llvm-<wbr class="">project?rev=302058&view=rev</a><br class="">
Log:<br class="">
[RuntimeLoopUnroller] Add assert that we dont unroll non-rotated loops<br class="">
<br class="">
Summary:<br class="">
Cloning basic blocks in the loop for runtime loop unroller depends on loop<br class="">
being<br class="">
in rotated form (i.e. loop latch target is the exit block).<br class="">
Assert that this is true, so that callers of runtime loop unroller pass in<br class="">
canonical loops.<br class="">
The single caller of this function has that check recently added:<br class="">
<a href="https://reviews.llvm.org/rL301239" target="_blank" class="">https://reviews.llvm.org/<wbr class="">rL301239</a><br class="">
<br class="">
Reviewers: davide<br class="">
<br class="">
Subscribers: llvm-commits<br class="">
<br class="">
Differential Revision: <a href="https://reviews.llvm.org/D32801" target="_blank" class="">
https://reviews.llvm.org/<wbr class="">D32801</a><br class="">
<br class="">
Modified:<br class="">
llvm/trunk/lib/Transforms/<wbr class="">Utils/LoopUnrollRuntime.cpp<br class="">
<br class="">
Modified: llvm/trunk/lib/Transforms/<wbr class="">Utils/LoopUnrollRuntime.cpp<br class="">
URL:<br class="">
<a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Utils/LoopUnrollRuntime.cpp?rev=302058&r1=302057&r2=302058&view=diff" target="_blank" class="">http://llvm.org/viewvc/llvm-<wbr class="">project/llvm/trunk/lib/<wbr class="">Transforms/Utils/<wbr class="">LoopUnrollRuntime.cpp?rev=<wbr class="">302058&r1=302057&r2=302058&<wbr class="">view=diff</a><br class="">
<br class="">
==============================<wbr class="">==============================<wbr class="">==================<br class="">
--- llvm/trunk/lib/Transforms/<wbr class="">Utils/LoopUnrollRuntime.cpp (original)<br class="">
+++ llvm/trunk/lib/Transforms/<wbr class="">Utils/LoopUnrollRuntime.cpp Wed May 3<br class="">
12:43:59 2017<br class="">
@@ -512,6 +512,13 @@ bool llvm::<wbr class="">UnrollRuntimeLoopRemainder(Lo<br class="">
<br class="">
BasicBlock *Latch = L->getLoopLatch();<br class="">
<br class="">
+ // Cloning the loop basic blocks (`CloneLoopBlocks`) requires that one<br class="">
of the<br class="">
+ // targets of the Latch be the single exit block out of the loop. This<br class="">
needs<br class="">
+ // to be guaranteed by the callers of UnrollRuntimeLoopRemainder.<br class="">
+ BranchInst *LatchBR = cast<BranchInst>(Latch-><wbr class="">getTerminator());<br class="">
+ assert(LatchBR->getSuccessor(<wbr class="">0) == Exit ||<br class="">
+ LatchBR->getSuccessor(<wbr class="">1) == Exit && "loop latch successor should<br class="">
be "<br class="">
+ <wbr class=""> "exit block!");<br class="">
// Loop structure is the following:<br class="">
//<br class="">
// PreHeader<br class="">
<br class="">
<br class="">
______________________________<wbr class="">_________________<br class="">
llvm-commits mailing list<br class="">
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" target="_blank" class="">http://lists.llvm.org/cgi-bin/<wbr class="">mailman/listinfo/llvm-commits</a><br class="">
</blockquote>
<br class="">
<br class="">
<br class="">
______________________________<wbr class="">_________________<br class="">
llvm-commits mailing list<br class="">
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" target="_blank" class="">http://lists.llvm.org/cgi-bin/<wbr class="">mailman/listinfo/llvm-commits</a><br class="">
<br class="">
</blockquote>
<br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" class="">
<span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important" class="">--<span class="m_3113098507258412448Apple-converted-space"> </span></span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" class="">
<span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important" class="">Davide</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" class="">
<br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" class="">
<span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important" class="">"There
are no solved problems; there are only problems that are more</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px" class="">
<span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important" class="">or
less solved" -- Henri Poincare</span></div>
</blockquote>
</div>
<br class="">
</div>
</div>
</div>
</div>
</blockquote>
</div>
<br class="">
</div>
</div>
</blockquote>
</div>
<br class="">
</div>
</body>
</html>