<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Apr 28, 2017 at 5:07 PM, Davide Italiano via Phabricator <span dir="ltr"><<a href="mailto:reviews@reviews.llvm.org" target="_blank">reviews@reviews.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">davide added inline comments.<br>
<br>
<br>
================<br>
Comment at: lib/Transforms/IPO/<wbr>PartialInlining.cpp:111<br>
+    AU.addRequired<<wbr>ProfileSummaryInfoWrapperPass><wbr>();<br>
+    AU.addRequired<<wbr>TargetTransformInfoWrapperPass<wbr>>();<br>
   }<br>
----------------<br>
Why don't we preserve TTI? (not that it matters for performances, but)<br>
<br>
<br>
================<br>
Comment at: lib/Transforms/IPO/<wbr>PartialInlining.cpp:302-306<br>
+  if (IC.isAlways()) {<br>
+    ORE.emit(<wbr>OptimizationRemarkAnalysis(<wbr>DEBUG_TYPE, "AlwaysInline", Call)<br>
+             << NV("Callee", Callee)<br>
+             << " should always be fully inlined, not partially");<br>
+    return false;<br>
----------------<br>
Can you add a test that triggers this?<br>
<br>
<br>
================<br>
Comment at: lib/Transforms/IPO/<wbr>PartialInlining.cpp:309-323<br>
+  if (IC.isNever()) {<br>
+    ORE.emit(<wbr>OptimizationRemarkMissed(<wbr>DEBUG_TYPE, "NeverInline", Call)<br>
+             << NV("Callee", Callee) << " not partially inlined into "<br>
+             << NV("Caller", Caller)<br>
+             << " because it should never be inlined (cost=never)");<br>
+    return false;<br>
+  }<br>
----------------<br>
and these as well, maybe<br>
<br>
<br></blockquote><div><br></div><div>There is a test case for noinline case.</div><div><br></div><div>David</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<a href="https://reviews.llvm.org/D32666" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D32666</a><br>
<br>
<br>
<br>
</blockquote></div><br></div></div>