<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Actually, sorry, just testing with __has_attribute(target) is sufficient. Changing the build is not required.<br class=""><div><blockquote type="cite" class=""><div class="">On Apr 20, 2017, at 1:06 PM, George Karpenkov <<a href="mailto:ekarpenkov@apple.com" class="">ekarpenkov@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=us-ascii" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hi Kostya, <div class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> What would be a reasonable way to check for its presence?<br class=""></blockquote><div class=""><br class=""></div><div class="">Frankly, I don't know.</div></div></div></div></div></blockquote><div class=""><br class=""></div><div class="">A reasonable way would be to use CMake to detect the feature during the configuration phase,</div><div class="">and then generate a variable based on that, which would be later included during the compilation.</div><div class="">That would even improve the current experience, as one would be able to compile libFuzzer on a broader range of platforms.</div><div class=""><br class=""></div><div class="">I understand that the ability to compile libFuzzer independently of LLVM is important,</div><div class="">but that could be still done using CMake, and the libFuzzer repository already contains the CMakeLists.txt file.</div><div class="">What would you think about removing the build script and just using CMake?</div><div class="">That would just mean two compilation steps instead of one, yet could improve applicability.</div><div class=""><br class=""></div><div class="">Cheers,</div><div class="">George</div><div class=""><br class=""></div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><div class=""> </div><div class=""> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
LLVM webpage currently claims that LLVM should be buildable with those (<a href="http://llvm.org/docs/GettingStarted.html#software" rel="noreferrer" target="_blank" class="">http://llvm.org/docs/<wbr class="">GettingStarted.html#software</a>)<br class="">
<br class="">
There is another failure on <a href="http://green.lab.llvm.org/green/job/clang-stage1-configure-RA_build/33461/console" rel="noreferrer" target="_blank" class="">http://green.lab.llvm.org/<wbr class="">green/job/clang-stage1-<wbr class="">configure-RA_build/33461/<wbr class="">console</a></blockquote><div class=""><br class=""></div><div class="">Yep.</div><div class=""> <br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br class="">
<br class="">
Thanks!<br class="">
<div class="HOEnZb"><div class="h5"><br class="">
<br class="">
Repository:<br class="">
rL LLVM<br class="">
<br class="">
<a href="https://reviews.llvm.org/D32096" rel="noreferrer" target="_blank" class="">https://reviews.llvm.org/<wbr class="">D32096</a><br class="">
<br class="">
<br class="">
<br class="">
</div></div></blockquote></div><br class=""></div></div>
</div></blockquote></div><br class=""></div></div></blockquote></div><br class=""></body></html>