<div dir="ltr">I reverted the patch with r300739 and fixed the bot by switching to gold using update-alternatives</div><br><div class="gmail_quote"><div dir="ltr">On Wed, Apr 19, 2017 at 12:09 PM Evgenii Stepanov <<a href="mailto:eugenis@google.com">eugenis@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">LLD adds some potential flakiness, unless it's pinned to a fixed<br>
revision. Also, gold is much more common in Linux distributions.<br>
<br>
Bfd is even more common, but the buildbot machine has something weird<br>
going on with ld.bfd + 32-bit sysroot where it generates broken ELFs<br>
and we don't have time to look at it properly (and also don't care<br>
about i686 strongly enough), so gold is the next best thing.<br>
<br>
On Wed, Apr 19, 2017 at 11:44 AM, Vitaly Buka <<a href="mailto:vitalybuka@google.com" target="_blank">vitalybuka@google.com</a>> wrote:<br>
> +Evgenii Stepanov<br>
><br>
> On Wed, Apr 19, 2017 at 11:42 AM Davide Italiano <<a href="mailto:davide@freebsd.org" target="_blank">davide@freebsd.org</a>> wrote:<br>
>><br>
>> On Wed, Apr 19, 2017 at 11:26 AM, Vitaly Buka via llvm-commits<br>
>> <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br>
>> > Author: vitalybuka<br>
>> > Date: Wed Apr 19 13:26:36 2017<br>
>> > New Revision: 300731<br>
>> ><br>
>> > URL: <a href="http://llvm.org/viewvc/llvm-project?rev=300731&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=300731&view=rev</a><br>
>> > Log:<br>
>> > [sanitizers] Switch to gold on sanitizer-x86_64-linux bot<br>
>> ><br>
>> > Modified:<br>
>> > zorg/trunk/zorg/buildbot/builders/sanitizers/buildbot_cmake.sh<br>
>> ><br>
>> > Modified: zorg/trunk/zorg/buildbot/builders/sanitizers/buildbot_cmake.sh<br>
>> > URL:<br>
>> > <a href="http://llvm.org/viewvc/llvm-project/zorg/trunk/zorg/buildbot/builders/sanitizers/buildbot_cmake.sh?rev=300731&r1=300730&r2=300731&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/zorg/trunk/zorg/buildbot/builders/sanitizers/buildbot_cmake.sh?rev=300731&r1=300730&r2=300731&view=diff</a><br>
>> ><br>
>> > ==============================================================================<br>
>> > --- zorg/trunk/zorg/buildbot/builders/sanitizers/buildbot_cmake.sh<br>
>> > (original)<br>
>> > +++ zorg/trunk/zorg/buildbot/builders/sanitizers/buildbot_cmake.sh Wed<br>
>> > Apr 19 13:26:36 2017<br>
>> > @@ -29,7 +29,7 @@ MAKE_JOBS=${MAX_MAKE_JOBS:-16}<br>
>> > LLVM_CHECKOUT=$ROOT/llvm<br>
>> > ZLIB=$ROOT/zlib<br>
>> > COMPILER_RT_CHECKOUT=$LLVM_CHECKOUT/projects/compiler-rt<br>
>> > -CMAKE_COMMON_OPTIONS="-DLLVM_ENABLE_ASSERTIONS=ON<br>
>> > -DLLVM_PARALLEL_LINK_JOBS=10"<br>
>> > +CMAKE_COMMON_OPTIONS="-DLLVM_USE_LINKER=gold<br>
>> > -DLLVM_ENABLE_ASSERTIONS=ON -DLLVM_PARALLEL_LINK_JOBS=10"<br>
>> > ENABLE_LIBCXX_FLAG=<br>
>> > if [ "$PLATFORM" == "Darwin" ]; then<br>
>> > CMAKE_COMMON_OPTIONS="${CMAKE_COMMON_OPTIONS}<br>
>> > -DPYTHON_EXECUTABLE=/usr/bin/python"<br>
>> ><br>
>><br>
>> Have you considered lld?<br>
>><br>
>> Thanks,<br>
>><br>
>> --<br>
>> Davide<br>
>><br>
>> "There are no solved problems; there are only problems that are more<br>
>> or less solved" -- Henri Poincare<br>
</blockquote></div>