<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";}
@page WordSection1
{size:612.0pt 792.0pt;
margin:2.0cm 42.5pt 2.0cm 3.0cm;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Thanks! Forgot about it.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Review updated.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Stas<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Daniel Berlin [mailto:dberlin@dberlin.org]
<br>
<b>Sent:</b> Friday, April 14, 2017 5:19 PM<br>
<b>To:</b> reviews+D32101+public+305894f3d2e6edbd@reviews.llvm.org; Stanislav Mekhanoshin via Phabricator<br>
<b>Cc:</b> Mekhanoshin, Stanislav; Arsenault, Matthew; Ding, Wei; llvm-commits; dorit.nuzman@intel.com; Anna Thomas<br>
<b>Subject:</b> Re: [PATCH] D32101: Skip bitcasts while looking for GEP in LoadStoreVectorizer<o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">Ignoring the issue of neededness or not, we have a function to do this anyway, you would want to use ->stripPointerCasts(), not do it yourself :)<o:p></o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">On Fri, Apr 14, 2017 at 4:15 PM, Stanislav Mekhanoshin via Phabricator via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<o:p></o:p></p>
<p class="MsoNormal" style="margin-bottom:12.0pt">rampitec created this revision.<br>
Herald added subscribers: nhaehnle, wdng, mzolotukhin.<br>
<br>
Repository:<br>
rL LLVM<br>
<br>
<a href="https://reviews.llvm.org/D32101" target="_blank">https://reviews.llvm.org/D32101</a><br>
<br>
Files:<br>
lib/Transforms/Vectorize/LoadStoreVectorizer.cpp<br>
test/Transforms/LoadStoreVectorizer/AMDGPU/gep-bitcast.ll<br>
<br>
<br>
Index: test/Transforms/LoadStoreVectorizer/AMDGPU/gep-bitcast.ll<br>
===================================================================<br>
--- /dev/null<br>
+++ test/Transforms/LoadStoreVectorizer/AMDGPU/gep-bitcast.ll<br>
@@ -0,0 +1,27 @@<br>
+; RUN: opt -S -mtriple=amdgcn--amdhsa -load-store-vectorizer < %s | FileCheck %s<br>
+<br>
+; Check that vectorizer can find a GEP through bitcast<br>
+; CHECK: load <4 x i32><br>
+define void @vect_zext_bitcast_idx(float addrspace(1)* %arg1, i32 %base) {<br>
+ %add1 = add nuw i32 %base, 0<br>
+ %zext1 = zext i32 %add1 to i64<br>
+ %gep1 = getelementptr inbounds float, float addrspace(1)* %arg1, i64 %zext1<br>
+ %f2i1 = bitcast float addrspace(1)* %gep1 to i32 addrspace(1)*<br>
+ %load1 = load i32, i32 addrspace(1)* %f2i1, align 4<br>
+ %add2 = add nuw i32 %base, 1<br>
+ %zext2 = zext i32 %add2 to i64<br>
+ %gep2 = getelementptr inbounds float, float addrspace(1)* %arg1, i64 %zext2<br>
+ %f2i2 = bitcast float addrspace(1)* %gep2 to i32 addrspace(1)*<br>
+ %load2 = load i32, i32 addrspace(1)* %f2i2, align 4<br>
+ %add3 = add nuw i32 %base, 2<br>
+ %zext3 = zext i32 %add3 to i64<br>
+ %gep3 = getelementptr inbounds float, float addrspace(1)* %arg1, i64 %zext3<br>
+ %f2i3 = bitcast float addrspace(1)* %gep3 to i32 addrspace(1)*<br>
+ %load3 = load i32, i32 addrspace(1)* %f2i3, align 4<br>
+ %add4 = add nuw i32 %base, 3<br>
+ %zext4 = zext i32 %add4 to i64<br>
+ %gep4 = getelementptr inbounds float, float addrspace(1)* %arg1, i64 %zext4<br>
+ %f2i4 = bitcast float addrspace(1)* %gep4 to i32 addrspace(1)*<br>
+ %load4 = load i32, i32 addrspace(1)* %f2i4, align 4<br>
+ ret void<br>
+}<br>
Index: lib/Transforms/Vectorize/LoadStoreVectorizer.cpp<br>
===================================================================<br>
--- lib/Transforms/Vectorize/LoadStoreVectorizer.cpp<br>
+++ lib/Transforms/Vectorize/LoadStoreVectorizer.cpp<br>
@@ -283,8 +283,14 @@<br>
<br>
// Look through GEPs after checking they're the same except for the last<br>
// index.<br>
- GetElementPtrInst *GEPA = dyn_cast<GetElementPtrInst>(getPointerOperand(A));<br>
- GetElementPtrInst *GEPB = dyn_cast<GetElementPtrInst>(getPointerOperand(B));<br>
+ Value *SrcPTRA = getPointerOperand(A);<br>
+ Value *SrcPTRB = getPointerOperand(B);<br>
+ while (auto *C = dyn_cast<BitCastInst>(SrcPTRA))<br>
+ SrcPTRA = C->getOperand(0);<br>
+ while (auto *C = dyn_cast<BitCastInst>(SrcPTRB))<br>
+ SrcPTRB = C->getOperand(0);<br>
+ GetElementPtrInst *GEPA = dyn_cast<GetElementPtrInst>(SrcPTRA);<br>
+ GetElementPtrInst *GEPB = dyn_cast<GetElementPtrInst>(SrcPTRB);<br>
if (!GEPA || !GEPB || GEPA->getNumOperands() != GEPB->getNumOperands())<br>
return false;<br>
unsigned FinalIndex = GEPA->getNumOperands() - 1;<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><o:p></o:p></p>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</div>
</body>
</html>