<div dir="ltr">I was afraid of something like that. Reverted in r300217.</div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature" data-smartmail="gmail_signature">~Craig</div></div>
<br><div class="gmail_quote">On Thu, Apr 13, 2017 at 9:58 AM, Reid Kleckner <span dir="ltr"><<a href="mailto:rnk@google.com" target="_blank">rnk@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">MSVC does not pack data into base class tail padding, so this static_assert fails everywhere on Windows. If we want to do this optimization portably, we need to use the ugly SubclassData pattern that Value uses.</div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Apr 13, 2017 at 9:34 AM, Craig Topper via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: ctopper<br>
Date: Thu Apr 13 11:34:49 2017<br>
New Revision: 300213<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=300213&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject?rev=300213&view=rev</a><br>
Log:<br>
[APSInt] Add a static_assert to ensure APSInt is packed well with APInt after r300171.<br>
<br>
Modified:<br>
    llvm/trunk/include/llvm/ADT/AP<wbr>SInt.h<br>
<br>
Modified: llvm/trunk/include/llvm/ADT/AP<wbr>SInt.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/APSInt.h?rev=300213&r1=300212&r2=300213&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/llvm/trunk/include/llvm/<wbr>ADT/APSInt.h?rev=300213&r1=<wbr>300212&r2=300213&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/include/llvm/ADT/AP<wbr>SInt.h (original)<br>
+++ llvm/trunk/include/llvm/ADT/AP<wbr>SInt.h Thu Apr 13 11:34:49 2017<br>
@@ -24,7 +24,9 @@ class LLVM_NODISCARD APSInt : public API<br>
<br>
 public:<br>
   /// Default constructor that creates an uninitialized APInt.<br>
-  explicit APSInt() : IsUnsigned(false) {}<br>
+  explicit APSInt() : IsUnsigned(false) {<br>
+    static_assert(sizeof(*this) == 16, "APSInt fields poorly packed");<br>
+  }<br>
<br>
   /// APSInt ctor - Create an APSInt with the specified width, default to<br>
   /// unsigned.<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>
</blockquote></div><br></div>