<div dir="ltr">I fixed that in a later commit.</div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature" data-smartmail="gmail_signature">~Craig</div></div>
<br><div class="gmail_quote">On Tue, Apr 11, 2017 at 11:35 AM, Friedman, Eli <span dir="ltr"><<a href="mailto:efriedma@codeaurora.org" target="_blank">efriedma@codeaurora.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 4/10/2017 10:42 PM, Craig Topper via llvm-commits wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: ctopper<br>
Date: Tue Apr 11 00:42:47 2017<br>
New Revision: 299915<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=299915&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject?rev=299915&view=rev</a><br>
Log:<br>
[InstCombine] Support weird size element types in dyn_castNegVal.<br>
<br>
Modified:<br>
     llvm/trunk/lib/Transforms/Ins<wbr>tCombine/InstructionCombining.<wbr>cpp<br>
     llvm/trunk/test/Transforms/In<wbr>stCombine/2008-05-22-NegValVec<wbr>tor.ll<br>
     llvm/trunk/test/Transforms/In<wbr>stCombine/rem.ll<br>
<br>
Modified: llvm/trunk/lib/Transforms/Inst<wbr>Combine/InstructionCombining.<wbr>cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/InstCombine/InstructionCombining.cpp?rev=299915&r1=299914&r2=299915&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/llvm/trunk/lib/Transform<wbr>s/InstCombine/InstructionCombi<wbr>ning.cpp?rev=299915&r1=299914&<wbr>r2=299915&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/lib/Transforms/Inst<wbr>Combine/InstructionCombining.<wbr>cpp (original)<br>
+++ llvm/trunk/lib/Transforms/Inst<wbr>Combine/InstructionCombining.<wbr>cpp Tue Apr 11 00:42:47 2017<br>
@@ -726,6 +726,10 @@ Value *InstCombiner::dyn_castNegVal(<wbr>Valu<br>
      if (C->getType()->getElementType(<wbr>)->isIntegerTy())<br>
        return ConstantExpr::getNeg(C);<br>
  +  if (ConstantVector *C = dyn_cast<ConstantVector>(V))<br>
+    if (C->getType()->getElementType(<wbr>)->isIntegerTy())<br>
+      return ConstantExpr::getNeg(C);<br>
</blockquote>
<br>
Do you need to check the operands of the ConstantVector here?  The existing code carefully avoids making new ConstantExprs.<span class="HOEnZb"><font color="#888888"><br>
<br>
-Eli<br>
<br>
-- <br>
Employee of Qualcomm Innovation Center, Inc.<br>
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project<br>
<br>
</font></span></blockquote></div><br></div>