<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Thu, Apr 6, 2017 at 1:11 PM, Rafael Espíndola <span dir="ltr"><<a href="mailto:rafael.espindola@gmail.com" target="_blank">rafael.espindola@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail-">>  static bool refersToGotEntry(RelExpr Expr) {<br>
>    return isRelExprOneOf<R_GOT, R_GOT_OFF, R_MIPS_GOT_LOCAL_PAGE, R_MIPS_GOT_OFF,<br>
> -                        R_MIPS_GOT_OFF32, R_MIPS_TLSGD, R_MIPS_TLSLD,<br>
> -                        R_GOT_PAGE_PC, R_GOT_PC, R_GOT_FROM_END, R_TLSGD,<br>
> -                        R_TLSGD_PC, R_TLSDESC, R_TLSDESC_PAGE>(Expr);<br>
> +                        R_MIPS_GOT_OFF32, R_GOT_PAGE_PC, R_GOT_PC,<br>
> +                        R_GOT_FROM_END>(Expr);<br>
>  }<br>
<br>
</span>R_TLSGD_PC refers to a got entry. You might want to rename this function.</blockquote><div><br></div><div><a href="https://reviews.llvm.org/D31792">https://reviews.llvm.org/D31792</a><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail-"><br>
>      // If the relocation points to something in the file, we can process it.<br>
> -    bool Constant =<br>
> +    bool IsConstant =<br>
>          isStaticLinkTimeConstant<ELFT><wbr>(Expr, Type, Body, Sec, Rel.r_offset);<br>
<br>
</span>In the future please do renames like these in their own patch, as it<br>
make each patch easier to read.<br></blockquote><div><br></div><div>I'll keep that in mind.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
Cheers,<br>
Rafael<br>
</blockquote></div><br></div></div>