<div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Wed, Mar 29, 2017 at 2:20 AM Sven van Haastregt via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This revision was automatically updated to reflect the committed changes.<br class="gmail_msg">
Closed by commit rL298987: [MachineVerifier] Avoid reference to nullptr (authored by svenvh).<br class="gmail_msg">
<br class="gmail_msg">
Changed prior to commit:<br class="gmail_msg">
  <a href="https://reviews.llvm.org/D31387?vs=93108&id=93350#toc" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D31387?vs=93108&id=93350#toc</a><br class="gmail_msg">
<br class="gmail_msg">
Repository:<br class="gmail_msg">
  rL LLVM<br class="gmail_msg">
<br class="gmail_msg">
<a href="https://reviews.llvm.org/D31387" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D31387</a><br class="gmail_msg">
<br class="gmail_msg">
Files:<br class="gmail_msg">
  llvm/trunk/lib/CodeGen/MachineVerifier.cpp<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
Index: llvm/trunk/lib/CodeGen/MachineVerifier.cpp<br class="gmail_msg">
===================================================================<br class="gmail_msg">
--- llvm/trunk/lib/CodeGen/MachineVerifier.cpp<br class="gmail_msg">
+++ llvm/trunk/lib/CodeGen/MachineVerifier.cpp<br class="gmail_msg">
@@ -260,8 +260,8 @@<br class="gmail_msg">
     static char ID; // Pass ID, replacement for typeid<br class="gmail_msg">
     const std::string Banner;<br class="gmail_msg">
<br class="gmail_msg">
-    MachineVerifierPass(const std::string &banner = nullptr)<br class="gmail_msg">
-      : MachineFunctionPass(ID), Banner(banner) {<br class="gmail_msg">
+    MachineVerifierPass(const std::string banner = std::string())<br class="gmail_msg"></blockquote><div><br>Now that this is a value, the 'const' here is incorrect/pessimizing and will prevent the std::move from being effective (it's not possible to move from a const object). Please remove it. :)<br><br>- Dave<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+      : MachineFunctionPass(ID), Banner(std::move(banner)) {<br class="gmail_msg">
         initializeMachineVerifierPassPass(*PassRegistry::getPassRegistry());<br class="gmail_msg">
       }<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
</blockquote></div></div>