<p dir="ltr">Agreed, that's why I said to always assume TM. </p>
<br><div class="gmail_quote"><div dir="ltr">On Tue, Mar 28, 2017, 1:02 AM Nemanja Ivanovic via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">nemanjai added inline comments.<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
================<br class="gmail_msg">
Comment at: lib/Target/PowerPC/PPCBoolRetToInt.cpp:93<br class="gmail_msg">
+  Value *translate(Value *V) {<br class="gmail_msg">
+    Type *IntTy = Type::getInt32Ty(V->getContext());<br class="gmail_msg">
+    if (ST && ST->isPPC64())<br class="gmail_msg">
----------------<br class="gmail_msg">
Just a personal preference nit...<br class="gmail_msg">
Maybe turn this into a conditional operator for the initialization (rather than the assignment in the if).<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<a href="https://reviews.llvm.org/D31407" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D31407</a><br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
</blockquote></div>