<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Typically we create a minimal source file then generate IR from that, manually reduce the IR some more, and include the sources as a comment in the .ll file.<div class=""><br class=""></div><div class="">-- adrian<br class=""><div><blockquote type="cite" class=""><div class="">On Mar 24, 2017, at 2:37 PM, Zhizhou Yang <<a href="mailto:zhizhouy@google.com" class="">zhizhouy@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Thanks! May I ask do I create a cc file, generate the elf file and put them into Input directory?<div class=""><br class=""></div><div class="">The test I added is to check the behavior of addString to DW_AT_producer, like as a unit test. So do I no longer keep that?</div></div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Fri, Mar 24, 2017 at 2:09 PM, David Blaikie <span dir="ltr" class=""><<a href="mailto:dblaikie@gmail.com" target="_blank" class="">dblaikie@gmail.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="">Rather than testing the generated assembly, DWARF tests usually use llvm-dwarfdump to test the DWARF. Check other tests in LLVM's test/DebugInfo/...</div><div class="HOEnZb"><div class="h5"><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Fri, Mar 24, 2017 at 1:55 PM Zhizhou Yang via Phabricator <<a href="mailto:reviews@reviews.llvm.org" target="_blank" class="">reviews@reviews.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">zhizhouy updated this revision to Diff 93002.<br class="m_-7115805108502011045gmail_msg">
zhizhouy marked an inline comment as done.<br class="m_-7115805108502011045gmail_msg">
zhizhouy added a comment.<br class="m_-7115805108502011045gmail_msg">
<br class="m_-7115805108502011045gmail_msg">
Fixed StringRef related problem.<br class="m_-7115805108502011045gmail_msg">
<br class="m_-7115805108502011045gmail_msg">
Added a testcase for it.<br class="m_-7115805108502011045gmail_msg">
<br class="m_-7115805108502011045gmail_msg">
<br class="m_-7115805108502011045gmail_msg">
<a href="https://reviews.llvm.org/D31315" rel="noreferrer" class="m_-7115805108502011045gmail_msg" target="_blank">https://reviews.llvm.org/<wbr class="">D31315</a><br class="m_-7115805108502011045gmail_msg">
<br class="m_-7115805108502011045gmail_msg">
Files:<br class="m_-7115805108502011045gmail_msg">
lib/CodeGen/AsmPrinter/<wbr class="">DwarfDebug.cpp<br class="m_-7115805108502011045gmail_msg">
test/CodeGen/X86/dwarf-<wbr class="">producer-with-flags.ll<br class="m_-7115805108502011045gmail_msg">
<br class="m_-7115805108502011045gmail_msg">
<br class="m_-7115805108502011045gmail_msg">
Index: test/CodeGen/X86/dwarf-<wbr class="">producer-with-flags.ll<br class="m_-7115805108502011045gmail_msg">
==============================<wbr class="">==============================<wbr class="">=======<br class="m_-7115805108502011045gmail_msg">
--- /dev/null<br class="m_-7115805108502011045gmail_msg">
+++ test/CodeGen/X86/dwarf-<wbr class="">producer-with-flags.ll<br class="m_-7115805108502011045gmail_msg">
@@ -0,0 +1,28 @@<br class="m_-7115805108502011045gmail_msg">
+; RUN: llc -o - %s | FileCheck %s<br class="m_-7115805108502011045gmail_msg">
+; CHECK: .Linfo_string0:<br class="m_-7115805108502011045gmail_msg">
+; CHECK-NEXT: .asciz "clang -g -grecord-gcc-switches -S -llvm-emit -o test.ll"<br class="m_-7115805108502011045gmail_msg">
+; CHECK: .Linfo_string0 # DW_AT_producer<br class="m_-7115805108502011045gmail_msg">
+target triple = "x86_64-unknown-linux-gnu"<br class="m_-7115805108502011045gmail_msg">
+<br class="m_-7115805108502011045gmail_msg">
+define i32 @main() !dbg !6 {<br class="m_-7115805108502011045gmail_msg">
+entry:<br class="m_-7115805108502011045gmail_msg">
+ %retval = alloca i32, align 4<br class="m_-7115805108502011045gmail_msg">
+ store i32 0, i32* %retval, align 4<br class="m_-7115805108502011045gmail_msg">
+ ret i32 0, !dbg !10<br class="m_-7115805108502011045gmail_msg">
+}<br class="m_-7115805108502011045gmail_msg">
+<br class="m_-7115805108502011045gmail_msg">
+!<a href="http://llvm.dbg.cu/" rel="noreferrer" class="m_-7115805108502011045gmail_msg" target="_blank">llvm.dbg.cu</a> = !{!0}<br class="m_-7115805108502011045gmail_msg">
+!llvm.module.flags = !{!3, !4}<br class="m_-7115805108502011045gmail_msg">
+!llvm.ident = !{!5}<br class="m_-7115805108502011045gmail_msg">
+<br class="m_-7115805108502011045gmail_msg">
+!0 = distinct !DICompileUnit(language: DW_LANG_C99, file: !1, producer: "clang", isOptimized: false, flags: "-g -grecord-gcc-switches -S -llvm-emit -o test.ll", runtimeVersion: 0, emissionKind: FullDebug, enums: !2)<br class="m_-7115805108502011045gmail_msg">
+!1 = !DIFile(filename: "foo.c", directory: "d")<br class="m_-7115805108502011045gmail_msg">
+!2 = !{}<br class="m_-7115805108502011045gmail_msg">
+!3 = !{i32 2, !"Dwarf Version", i32 4}<br class="m_-7115805108502011045gmail_msg">
+!4 = !{i32 2, !"Debug Info Version", i32 3}<br class="m_-7115805108502011045gmail_msg">
+!5 = !{!"clang"}<br class="m_-7115805108502011045gmail_msg">
+!6 = distinct !DISubprogram(name: "main", scope: !1, file: !1, line: 4, type: !7, isLocal: false, isDefinition: true, scopeLine: 4, flags: DIFlagPrototyped, isOptimized: false, unit: !0, variables: !2)<br class="m_-7115805108502011045gmail_msg">
+!7 = !DISubroutineType(types: !8)<br class="m_-7115805108502011045gmail_msg">
+!8 = !{!9}<br class="m_-7115805108502011045gmail_msg">
+!9 = !DIBasicType(name: "int", size: 32, encoding: DW_ATE_signed)<br class="m_-7115805108502011045gmail_msg">
+!10 = !DILocation(line: 5, column: 3, scope: !6)<br class="m_-7115805108502011045gmail_msg">
Index: lib/CodeGen/AsmPrinter/<wbr class="">DwarfDebug.cpp<br class="m_-7115805108502011045gmail_msg">
==============================<wbr class="">==============================<wbr class="">=======<br class="m_-7115805108502011045gmail_msg">
--- lib/CodeGen/AsmPrinter/<wbr class="">DwarfDebug.cpp<br class="m_-7115805108502011045gmail_msg">
+++ lib/CodeGen/AsmPrinter/<wbr class="">DwarfDebug.cpp<br class="m_-7115805108502011045gmail_msg">
@@ -423,7 +423,14 @@<br class="m_-7115805108502011045gmail_msg">
Asm->OutStreamer->getContext(<wbr class="">).<wbr class="">setMCLineTableCompilationDir(<br class="m_-7115805108502011045gmail_msg">
NewCU.getUniqueID(), CompilationDir);<br class="m_-7115805108502011045gmail_msg">
<br class="m_-7115805108502011045gmail_msg">
- NewCU.addString(Die, dwarf::DW_AT_producer, DIUnit->getProducer());<br class="m_-7115805108502011045gmail_msg">
+ StringRef Producer = DIUnit->getProducer();<br class="m_-7115805108502011045gmail_msg">
+ StringRef Flags = DIUnit->getFlags();<br class="m_-7115805108502011045gmail_msg">
+ if (!Flags.empty()) {<br class="m_-7115805108502011045gmail_msg">
+ std::string ProducerWithFlags = Producer.str() + " " + Flags.str();<br class="m_-7115805108502011045gmail_msg">
+ NewCU.addString(Die, dwarf::DW_AT_producer, ProducerWithFlags);<br class="m_-7115805108502011045gmail_msg">
+ } else<br class="m_-7115805108502011045gmail_msg">
+ NewCU.addString(Die, dwarf::DW_AT_producer, Producer);<br class="m_-7115805108502011045gmail_msg">
+<br class="m_-7115805108502011045gmail_msg">
NewCU.addUInt(Die, dwarf::DW_AT_language, dwarf::DW_FORM_data2,<br class="m_-7115805108502011045gmail_msg">
DIUnit->getSourceLanguage());<br class="m_-7115805108502011045gmail_msg">
NewCU.addString(Die, dwarf::DW_AT_name, FN);<br class="m_-7115805108502011045gmail_msg">
<br class="m_-7115805108502011045gmail_msg">
<br class="m_-7115805108502011045gmail_msg">
</blockquote></div>
</div></div></blockquote></div><br class=""></div>
</div></blockquote></div><br class=""></div></body></html>