<div dir="ltr">I see. I wonder if it would be better to use /debugpdb to control PDB creation entirely for now (and remove that flag once we're in better shape). It looks like right now it just disables the TPI stream.<div><br></div><div>Peter</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Mar 22, 2017 at 2:02 PM, Reid Kleckner <span dir="ltr"><<a href="mailto:rnk@google.com" target="_blank">rnk@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Yes, <a href="https://reviews.llvm.org/D31224" target="_blank">https://reviews.llvm.org/<wbr>D31224</a> / r298467.</div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Mar 22, 2017 at 1:45 PM, Peter Collingbourne <span dir="ltr"><<a href="mailto:peter@pcc.me.uk" target="_blank">peter@pcc.me.uk</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Do you know which change caused this test to start failing?<div><br></div><div>Peter</div></div><div class="gmail_extra"><div><div class="m_-1321283078562213152h5"><br><div class="gmail_quote">On Wed, Mar 22, 2017 at 1:23 PM, Reid Kleckner <span dir="ltr"><<a href="mailto:rnk@google.com" target="_blank">rnk@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Both failures should be fixed with the changes to add a /nopdb flag to LLD and use it in these sanitizer tests:<div><a href="http://lab.llvm.org:8011/builders/sanitizer-windows/builds/8459" target="_blank">http://lab.llvm.org:8011/build<wbr>ers/sanitizer-windows/builds/8<wbr>459</a></div><div><br></div><div>In the future, we probably want to disentagle /debug from symbol table generation so that /debug can be more faithful to link.exe's command line interface.</div></div><div class="m_-1321283078562213152m_7802032899798700835HOEnZb"><div class="m_-1321283078562213152m_7802032899798700835h5"><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Mar 21, 2017 at 10:36 PM, Vitaly Buka <span dir="ltr"><<a href="mailto:vitalybuka@google.com" target="_blank">vitalybuka@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Now it fails another test.</div><a href="http://lab.llvm.org:8011/builders/sanitizer-windows/builds/8411/steps/run%20tests/logs/stdio" class="m_-1321283078562213152m_7802032899798700835m_5274683504007321244m_-5349329251110269227cremed" target="_blank">http://lab.llvm.org:8011/build<wbr>ers/sanitizer-windows/builds/8<wbr>411/steps/run%20tests/logs/std<wbr>io</a><div><br></div><div>Looks like windows bot stops on the first failure, so fuse-lld was introduced before but hidden by CFI bug.<br></div><div>Would be nice always continue to run all tests even after an error.</div><div><br></div>Maybe using "ninja -k N flag" or just by splitting "argv: ['ninja', '-j', '16', 'check-asan', 'check-asan-dynamic', 'check-sanitizer', 'check-cfi']" into multiple steps.<div><div class="m_-1321283078562213152m_7802032899798700835m_5274683504007321244h5"><div><br><div class="gmail_quote"><div dir="ltr">On Tue, Mar 21, 2017 at 6:57 PM Reid Kleckner via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rnk<br class="m_-1321283078562213152m_7802032899798700835m_5274683504007321244m_-5349329251110269227gmail_msg">
Date: Tue Mar 21 20:45:08 2017<br class="m_-1321283078562213152m_7802032899798700835m_5274683504007321244m_-5349329251110269227gmail_msg">
New Revision: 298476<br class="m_-1321283078562213152m_7802032899798700835m_5274683504007321244m_-5349329251110269227gmail_msg">
<br class="m_-1321283078562213152m_7802032899798700835m_5274683504007321244m_-5349329251110269227gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=298476&view=rev" rel="noreferrer" class="m_-1321283078562213152m_7802032899798700835m_5274683504007321244m_-5349329251110269227gmail_msg m_-1321283078562213152m_7802032899798700835m_5274683504007321244m_-5349329251110269227cremed" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject?rev=298476&view=rev</a><br class="m_-1321283078562213152m_7802032899798700835m_5274683504007321244m_-5349329251110269227gmail_msg">
Log:<br class="m_-1321283078562213152m_7802032899798700835m_5274683504007321244m_-5349329251110269227gmail_msg">
XFAIL CFI stats test while LLD produces corrupt PDBs that confuse DIA<br class="m_-1321283078562213152m_7802032899798700835m_5274683504007321244m_-5349329251110269227gmail_msg">
<br class="m_-1321283078562213152m_7802032899798700835m_5274683504007321244m_-5349329251110269227gmail_msg">
Modified:<br class="m_-1321283078562213152m_7802032899798700835m_5274683504007321244m_-5349329251110269227gmail_msg">
    compiler-rt/trunk/test/cfi/sta<wbr>ts.cpp<br class="m_-1321283078562213152m_7802032899798700835m_5274683504007321244m_-5349329251110269227gmail_msg">
<br class="m_-1321283078562213152m_7802032899798700835m_5274683504007321244m_-5349329251110269227gmail_msg">
Modified: compiler-rt/trunk/test/cfi/sta<wbr>ts.cpp<br class="m_-1321283078562213152m_7802032899798700835m_5274683504007321244m_-5349329251110269227gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/cfi/stats.cpp?rev=298476&r1=298475&r2=298476&view=diff" rel="noreferrer" class="m_-1321283078562213152m_7802032899798700835m_5274683504007321244m_-5349329251110269227gmail_msg m_-1321283078562213152m_7802032899798700835m_5274683504007321244m_-5349329251110269227cremed" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/compiler-rt/trunk/test/c<wbr>fi/stats.cpp?rev=298476&r1=298<wbr>475&r2=298476&view=diff</a><br class="m_-1321283078562213152m_7802032899798700835m_5274683504007321244m_-5349329251110269227gmail_msg">
==============================<wbr>==============================<wbr>==================<br class="m_-1321283078562213152m_7802032899798700835m_5274683504007321244m_-5349329251110269227gmail_msg">
--- compiler-rt/trunk/test/cfi/sta<wbr>ts.cpp (original)<br class="m_-1321283078562213152m_7802032899798700835m_5274683504007321244m_-5349329251110269227gmail_msg">
+++ compiler-rt/trunk/test/cfi/sta<wbr>ts.cpp Tue Mar 21 20:45:08 2017<br class="m_-1321283078562213152m_7802032899798700835m_5274683504007321244m_-5349329251110269227gmail_msg">
@@ -2,6 +2,8 @@<br class="m_-1321283078562213152m_7802032899798700835m_5274683504007321244m_-5349329251110269227gmail_msg">
 // RUN: env SANITIZER_STATS_PATH=%t.stats %t<br class="m_-1321283078562213152m_7802032899798700835m_5274683504007321244m_-5349329251110269227gmail_msg">
 // RUN: sanstats %t.stats | FileCheck %s<br class="m_-1321283078562213152m_7802032899798700835m_5274683504007321244m_-5349329251110269227gmail_msg">
<br class="m_-1321283078562213152m_7802032899798700835m_5274683504007321244m_-5349329251110269227gmail_msg">
+// XFAIL: win32<br class="m_-1321283078562213152m_7802032899798700835m_5274683504007321244m_-5349329251110269227gmail_msg">
+<br class="m_-1321283078562213152m_7802032899798700835m_5274683504007321244m_-5349329251110269227gmail_msg">
 // FIXME: We currently emit the wrong debug info under devirtualization.<br class="m_-1321283078562213152m_7802032899798700835m_5274683504007321244m_-5349329251110269227gmail_msg">
 // UNSUPPORTED: devirt<br class="m_-1321283078562213152m_7802032899798700835m_5274683504007321244m_-5349329251110269227gmail_msg">
<br class="m_-1321283078562213152m_7802032899798700835m_5274683504007321244m_-5349329251110269227gmail_msg">
<br class="m_-1321283078562213152m_7802032899798700835m_5274683504007321244m_-5349329251110269227gmail_msg">
<br class="m_-1321283078562213152m_7802032899798700835m_5274683504007321244m_-5349329251110269227gmail_msg">
______________________________<wbr>_________________<br class="m_-1321283078562213152m_7802032899798700835m_5274683504007321244m_-5349329251110269227gmail_msg">
llvm-commits mailing list<br class="m_-1321283078562213152m_7802032899798700835m_5274683504007321244m_-5349329251110269227gmail_msg">
<a href="mailto:llvm-commits@lists.llvm.org" class="m_-1321283078562213152m_7802032899798700835m_5274683504007321244m_-5349329251110269227gmail_msg m_-1321283078562213152m_7802032899798700835m_5274683504007321244m_-5349329251110269227cremed" target="_blank">llvm-commits@lists.llvm.org</a><br class="m_-1321283078562213152m_7802032899798700835m_5274683504007321244m_-5349329251110269227gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" class="m_-1321283078562213152m_7802032899798700835m_5274683504007321244m_-5349329251110269227gmail_msg m_-1321283078562213152m_7802032899798700835m_5274683504007321244m_-5349329251110269227cremed" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br class="m_-1321283078562213152m_7802032899798700835m_5274683504007321244m_-5349329251110269227gmail_msg">
</blockquote></div></div></div></div></div>
</blockquote></div><br></div>
</div></div></blockquote></div><br><br clear="all"><div><br></div></div></div><span class="m_-1321283078562213152HOEnZb"><font color="#888888">-- <br><div class="m_-1321283078562213152m_7802032899798700835gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">-- <div>Peter</div></div></div>
</font></span></div>
</blockquote></div><br></div>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">-- <div>Peter</div></div></div>
</div>