<div dir="ltr">Looks like this broke GreenDragon: <a href="http://lab.llvm.org:8080/green/job/clang-stage1-configure-RA_build/32391/">http://lab.llvm.org:8080/green/job/clang-stage1-configure-RA_build/32391/</a><div><br></div><div>Could you please take a look?</div><div><br></div><div>Thanks</div><div><br></div><div>Cheers,</div><div>Juergen</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Mar 21, 2017 at 12:35 PM, Zachary Turner via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: zturner<br>
Date: Tue Mar 21 14:35:05 2017<br>
New Revision: 298427<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=298427&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=298427&view=rev</a><br>
Log:<br>
[ADT] Add a version of llvm::join() that takes a range.<br>
<br>
Modified:<br>
    llvm/trunk/include/llvm/ADT/<wbr>StringExtras.h<br>
    llvm/trunk/unittests/ADT/<wbr>StringRefTest.cpp<br>
<br>
Modified: llvm/trunk/include/llvm/ADT/<wbr>StringExtras.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/StringExtras.h?rev=298427&r1=298426&r2=298427&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/include/<wbr>llvm/ADT/StringExtras.h?rev=<wbr>298427&r1=298426&r2=298427&<wbr>view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/include/llvm/ADT/<wbr>StringExtras.h (original)<br>
+++ llvm/trunk/include/llvm/ADT/<wbr>StringExtras.h Tue Mar 21 14:35:05 2017<br>
@@ -234,6 +234,13 @@ inline std::string join(IteratorT Begin,<br>
   return detail::join_impl(Begin, End, Separator, tag());<br>
 }<br>
<br>
+/// Joins the strings in the range [R.begin(), R.end()), adding Separator<br>
+/// between the elements.<br>
+template <typename Range><br>
+inline std::string join(Range &&R, StringRef Separator) {<br>
+  return join(R.begin(), R.end(), Separator);<br>
+}<br>
+<br>
 /// Joins the strings in the parameter pack \p Items, adding \p Separator<br>
 /// between the elements.  All arguments must be implicitly convertible to<br>
 /// std::string, or there should be an overload of std::string::operator+=()<br>
<br>
Modified: llvm/trunk/unittests/ADT/<wbr>StringRefTest.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/ADT/StringRefTest.cpp?rev=298427&r1=298426&r2=298427&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/unittests/<wbr>ADT/StringRefTest.cpp?rev=<wbr>298427&r1=298426&r2=298427&<wbr>view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/unittests/ADT/<wbr>StringRefTest.cpp (original)<br>
+++ llvm/trunk/unittests/ADT/<wbr>StringRefTest.cpp Tue Mar 21 14:35:05 2017<br>
@@ -899,6 +899,8 @@ TEST(StringRefTest, joinStrings) {<br>
   EXPECT_TRUE(v2_join2);<br>
   bool v2_join3 = join(v2.begin(), v2.end(), "::") == join_result3;<br>
   EXPECT_TRUE(v2_join3);<br>
+  v2_join3 = join(v2, "::") == join_result3;<br>
+  EXPECT_TRUE(v2_join3);<br>
 }<br>
<br>
<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>