<div dir="ltr">I was asking you to commit (assuming you have commit access) - but I guess you don't have commit access, so I've committed this for you in r298266</div><br><div class="gmail_quote"><div dir="ltr">On Mon, Mar 20, 2017 at 9:45 AM Moritz Kiefer <<a href="mailto:moritz.kiefer@purelyfunctional.org">moritz.kiefer@purelyfunctional.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Just to make sure I understand your message:<br class="gmail_msg">
Are you asking for someone with commit access to commit this or are you<br class="gmail_msg">
asking me to submit the patch in some different format?<br class="gmail_msg">
<br class="gmail_msg">
On 03/20/2017 05:33 PM, David Blaikie wrote:<br class="gmail_msg">
> LGTM, please commit.<br class="gmail_msg">
><br class="gmail_msg">
> On Wed, Mar 15, 2017 at 11:39 PM Moritz Kiefer via llvm-commits<br class="gmail_msg">
> <<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a> <mailto:<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a>>> wrote:<br class="gmail_msg">
><br class="gmail_msg">
>     Without this, a pass with a result type from `std::` causes an error.<br class="gmail_msg">
>     ---<br class="gmail_msg">
>      include/llvm/IR/PassManagerInternal.h | 2 +-<br class="gmail_msg">
>      1 file changed, 1 insertion(+), 1 deletion(-)<br class="gmail_msg">
><br class="gmail_msg">
>     diff --git a/include/llvm/IR/PassManagerInternal.h<br class="gmail_msg">
>     b/include/llvm/IR/PassManagerInternal.h<br class="gmail_msg">
>     index 02f21675fa9..387dc4c65c4 100644<br class="gmail_msg">
>     --- a/include/llvm/IR/PassManagerInternal.h<br class="gmail_msg">
>     +++ b/include/llvm/IR/PassManagerInternal.h<br class="gmail_msg">
>     @@ -291,7 +291,7 @@ struct AnalysisPassModel :<br class="gmail_msg">
>     AnalysisPassConcept<IRUnitT, PreservedAnalysesT,<br class="gmail_msg">
>            AnalysisResultConcept<IRUnitT, PreservedAnalysesT, InvalidatorT>><br class="gmail_msg">
>        run(IRUnitT &IR, AnalysisManager<IRUnitT, ExtraArgTs...> &AM,<br class="gmail_msg">
>            ExtraArgTs... ExtraArgs) override {<br class="gmail_msg">
>     -    return make_unique<ResultModelT>(Pass.run(IR, AM, ExtraArgs...));<br class="gmail_msg">
>     +    return llvm::make_unique<ResultModelT>(Pass.run(IR, AM,<br class="gmail_msg">
>     ExtraArgs...));<br class="gmail_msg">
>        }<br class="gmail_msg">
><br class="gmail_msg">
>        /// \brief The model delegates to a static \c PassT::name method.<br class="gmail_msg">
>     --<br class="gmail_msg">
>     2.12.0<br class="gmail_msg">
><br class="gmail_msg">
>     _______________________________________________<br class="gmail_msg">
>     llvm-commits mailing list<br class="gmail_msg">
>     <a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a> <mailto:<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a>><br class="gmail_msg">
>     <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="gmail_msg">
><br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
</blockquote></div>