<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Mar 17, 2017, at 11:34 AM, David Blaikie <<a href="mailto:dblaikie@gmail.com" class="">dblaikie@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">I suppose the question is: is it worth/necessary to provide a test case? We could include a fixme & not do anything here? Or I can work up an IR test case for IR Clang (& probably Swift) don't currently generate, so behavior that won't be used.</div></div></blockquote><div><br class=""></div><div>IMO if the IR passes the Verifier, we should support it. And we didn't test other frontends, such as Julia, for example. If it is just a matter of making a small modification to IR generated by clang, I feel more comfortable with supporting it.</div><div><br class=""></div><div>-- adrian</div><br class=""><blockquote type="cite" class=""><div class=""><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Fri, Mar 17, 2017 at 11:15 AM Adrian Prantl <<a href="mailto:aprantl@apple.com" class="">aprantl@apple.com</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word" class="gmail_msg"><div class="gmail_msg"><blockquote type="cite" class="gmail_msg"><div class="gmail_msg">On Mar 17, 2017, at 9:12 AM, David Blaikie <<a href="mailto:dblaikie@gmail.com" class="gmail_msg" target="_blank">dblaikie@gmail.com</a>> wrote:</div><br class="m_-137017025646655513Apple-interchange-newline gmail_msg"><div class="gmail_msg"><div dir="ltr" class="gmail_msg">Hmm, one wrinkle... <br class="gmail_msg"><br class="gmail_msg">the "if (auto Fragment ...)" case doesn't run in any existing test cases. (I put an "assert(false)" there & ran check-llvm).<br class="gmail_msg"><br class="gmail_msg">Any ideas if that's still reachable? Perhaps this only happens for direct bool parameters, never fragments.</div></div></blockquote><div class="gmail_msg"><br class="gmail_msg"></div></div></div><div style="word-wrap:break-word" class="gmail_msg"><div class="gmail_msg"><div class="gmail_msg">I just finished building the swift stdlib in 64 and 32 bit (which is typically a good source of these) and also didn't hit the assertion. We'd need to hand-craft a testcase for opt -mem2reg.</div></div></div><div style="word-wrap:break-word" class="gmail_msg"><div class="gmail_msg"><div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg">-- adrian</div></div></div><div style="word-wrap:break-word" class="gmail_msg"><div class="gmail_msg"><br class="gmail_msg"><blockquote type="cite" class="gmail_msg"><div class="gmail_msg"><br class="gmail_msg"><div class="gmail_quote gmail_msg"><div dir="ltr" class="gmail_msg">On Fri, Mar 17, 2017 at 8:28 AM Adrian Prantl via Phabricator <<a href="mailto:reviews@reviews.llvm.org" class="gmail_msg" target="_blank">reviews@reviews.llvm.org</a>> wrote:<br class="gmail_msg"></div><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">aprantl accepted this revision.<br class="gmail_msg">
aprantl added a comment.<br class="gmail_msg">
This revision is now accepted and ready to land.<br class="gmail_msg">
<br class="gmail_msg">
Took me a while to find the functional change amidst the refactoring :-)<br class="gmail_msg">
As discussed in the PR, this LGTM, thanks!<br class="gmail_msg">
One inline comment about a comment.<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
================<br class="gmail_msg">
Comment at: lib/Transforms/Utils/Local.cpp:1118<br class="gmail_msg">
// describing will always be smaller than the variable size, because<br class="gmail_msg">
// VariableSize == Size of Alloca described by DDI. Since SI stores<br class="gmail_msg">
// to the alloca described by DDI, if it's first operand is an extend,<br class="gmail_msg">
----------------<br class="gmail_msg">
Does this comment still match our understanding?<br class="gmail_msg">
Particularly the `The fragment we're describing will always be smaller than the variable size` bit.<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<a href="https://reviews.llvm.org/D31062" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D31062</a><br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
</blockquote></div>
</div></blockquote></div></div></blockquote></div>
</div></blockquote></div><br class=""></body></html>