<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Fri, Mar 17, 2017 at 6:15 AM, George Rimar via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: grimar<br>
Date: Fri Mar 17 08:15:35 2017<br>
New Revision: 298082<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=298082&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject?rev=298082&view=rev</a><br>
Log:<br>
[ELF] - Fix warning.<br>
<br>
Writer.cpp:361:3: warning: suggest parentheses around assignment used as truth value [-Wparentheses]<br>
<br>
Modified:<br>
    lld/trunk/ELF/Writer.cpp<br>
<br>
Modified: lld/trunk/ELF/Writer.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Writer.cpp?rev=298082&r1=298081&r2=298082&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/lld/trunk/ELF/Writer.cpp<wbr>?rev=298082&r1=298081&r2=29808<wbr>2&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- lld/trunk/ELF/Writer.cpp (original)<br>
+++ lld/trunk/ELF/Writer.cpp Fri Mar 17 08:15:35 2017<br>
@@ -358,8 +358,8 @@ template <class ELFT> void Writer<ELFT>:<br>
     Add(In<ELFT>::BuildId);<br>
   }<br>
<br>
-  if (In<ELFT>::Common = createCommonSection<ELFT>())<br>
-    Add(In<ELFT>::Common);<br>
+  if (auto *Sec = createCommonSection<ELFT>())<br>
+    Add(Sec); </blockquote><div><br></div><div>Can you always keep new code consistent with existing code? I wouldn't use `auto` as the other code in this file doesn't use `auto` in the context like this. </div></div></div></div>