<div dir="ltr">I'm running a debug build, so asserts are in fact enabled.</div><br><div class="gmail_quote"><div dir="ltr">On Wed, Mar 15, 2017 at 11:18 AM Rackover, Zvi <<a href="mailto:zvi.rackover@intel.com">zvi.rackover@intel.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-US" link="blue" vlink="purple" class="gmail_msg">
<div class="m_6483215564914976104WordSection1 gmail_msg">
<p class="MsoNormal gmail_msg"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d" class="gmail_msg">I counted 95 LIT tests marked as “XFAIL: *”. I agree that keeping a test in such a state for a long time is undesirable.<u class="gmail_msg"></u><u class="gmail_msg"></u></span></p>
<p class="MsoNormal gmail_msg"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d" class="gmail_msg">But I also uploaded a fix candidate,</span>
<span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d" class="gmail_msg"><a href="https://reviews.llvm.org/D30978" class="gmail_msg" target="_blank">https://reviews.llvm.org/D30978</a>, so if all goes well the test won’t remain an XFAIL for long.<u class="gmail_msg"></u><u class="gmail_msg"></u></span></p>
<p class="MsoNormal gmail_msg"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d" class="gmail_msg"><u class="gmail_msg"></u> <u class="gmail_msg"></u></span></p>
<p class="MsoNormal gmail_msg"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d" class="gmail_msg">Are you running with a build with assertions disabled? If yes, that may explain why the test passes unexpectedly on your build. I’m not sure what is the policy
about Release+NoAssertions builds, but I can remove the test if this the only test that fails in that configuration.<u class="gmail_msg"></u><u class="gmail_msg"></u></span></p>
<p class="MsoNormal gmail_msg"><a name="m_6483215564914976104__MailEndCompose" class="gmail_msg"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d" class="gmail_msg"><u class="gmail_msg"></u> <u class="gmail_msg"></u></span></a></p>
<p class="MsoNormal gmail_msg"><a name="m_6483215564914976104______replyseparator" class="gmail_msg"></a><b class="gmail_msg"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif" class="gmail_msg">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif" class="gmail_msg"> Zachary Turner [mailto:<a href="mailto:zturner@google.com" class="gmail_msg" target="_blank">zturner@google.com</a>]
<br class="gmail_msg">
<b class="gmail_msg">Sent:</b> Wednesday, March 15, 2017 19:59<br class="gmail_msg">
<b class="gmail_msg">To:</b> Rackover, Zvi <<a href="mailto:zvi.rackover@intel.com" class="gmail_msg" target="_blank">zvi.rackover@intel.com</a>>; <a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a><br class="gmail_msg">
<b class="gmail_msg">Subject:</b> Re: [llvm] r297823 - Fix malformed XFAIL in previous commit<u class="gmail_msg"></u><u class="gmail_msg"></u></span></p></div></div><div lang="EN-US" link="blue" vlink="purple" class="gmail_msg"><div class="m_6483215564914976104WordSection1 gmail_msg">
<p class="MsoNormal gmail_msg"><u class="gmail_msg"></u> <u class="gmail_msg"></u></p>
<div class="gmail_msg">
<p class="MsoNormal gmail_msg">Why does this have XFAIL: *? It's passing on my machine which is being treated as a failure since it's expected to fail but doesn't. In any case, what is the point of having a test which is expected to fail everywhere?<u class="gmail_msg"></u><u class="gmail_msg"></u></p>
</div>
<p class="MsoNormal gmail_msg"><u class="gmail_msg"></u> <u class="gmail_msg"></u></p>
<div class="gmail_msg">
<div class="gmail_msg">
<p class="MsoNormal gmail_msg">On Wed, Mar 15, 2017 at 4:56 AM Zvi Rackover via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<u class="gmail_msg"></u><u class="gmail_msg"></u></p>
</div>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm" class="gmail_msg">
<p class="MsoNormal gmail_msg">Author: zvi<br class="gmail_msg">
Date: Wed Mar 15 06:44:14 2017<br class="gmail_msg">
New Revision: 297823<br class="gmail_msg">
<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=297823&view=rev" class="gmail_msg" target="_blank">
http://llvm.org/viewvc/llvm-project?rev=297823&view=rev</a><br class="gmail_msg">
Log:<br class="gmail_msg">
Fix malformed XFAIL in previous commit<br class="gmail_msg">
<br class="gmail_msg">
Modified:<br class="gmail_msg">
llvm/trunk/test/CodeGen/Generic/pr32278.ll<br class="gmail_msg">
<br class="gmail_msg">
Modified: llvm/trunk/test/CodeGen/Generic/pr32278.ll<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/Generic/pr32278.ll?rev=297823&r1=297822&r2=297823&view=diff" class="gmail_msg" target="_blank">
http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/Generic/pr32278.ll?rev=297823&r1=297822&r2=297823&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- llvm/trunk/test/CodeGen/Generic/pr32278.ll (original)<br class="gmail_msg">
+++ llvm/trunk/test/CodeGen/Generic/pr32278.ll Wed Mar 15 06:44:14 2017<br class="gmail_msg">
@@ -1,5 +1,5 @@<br class="gmail_msg">
; PR32278<br class="gmail_msg">
-; XFAIL:<br class="gmail_msg">
+; XFAIL: *<br class="gmail_msg">
<br class="gmail_msg">
; RUN: llc < %s<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
llvm-commits mailing list<br class="gmail_msg">
<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><u class="gmail_msg"></u><u class="gmail_msg"></u></p>
</blockquote>
</div>
</div></div><div lang="EN-US" link="blue" vlink="purple" class="gmail_msg"><div class="m_6483215564914976104WordSection1 gmail_msg"></div>
<p class="gmail_msg">---------------------------------------------------------------------<br class="gmail_msg">
Intel Israel (74) Limited</p>
<p class="gmail_msg">This e-mail and any attachments may contain confidential material for<br class="gmail_msg">
the sole use of the intended recipient(s). Any review or distribution<br class="gmail_msg">
by others is strictly prohibited. If you are not the intended<br class="gmail_msg">
recipient, please contact the sender and delete all copies.</p></div>
</blockquote></div>