<div dir="ltr">Thanks. Reverted r297912</div><br><div class="gmail_quote"><div dir="ltr">On Wed, Mar 15, 2017 at 3:54 PM Bruno Cardoso Lopes <<a href="mailto:bruno.cardoso@gmail.com">bruno.cardoso@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="gmail_msg">Hi,<div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg">Looks like this triggered a test to fail in <a href="http://green.lab.llvm.org/green/job/libFuzzer/837" class="gmail_msg" target="_blank">http://green.lab.llvm.org/green/job/libFuzzer/837</a>, can you take a look?</div></div><div class="gmail_extra gmail_msg"></div><div class="gmail_extra gmail_msg"><br class="gmail_msg"><div class="gmail_quote gmail_msg">On Wed, Mar 15, 2017 at 1:59 PM, Vitaly Buka via llvm-commits <span dir="ltr" class="gmail_msg"><<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br class="gmail_msg"><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: vitalybuka<br class="gmail_msg">
Date: Wed Mar 15 15:59:27 2017<br class="gmail_msg">
New Revision: 297891<br class="gmail_msg">
<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=297891&view=rev" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project?rev=297891&view=rev</a><br class="gmail_msg">
Log:<br class="gmail_msg">
[libFuzzer] Use ChooseUnitIdxToMutate to pick item for crossover.<br class="gmail_msg">
<br class="gmail_msg">
Differential Revision: <a href="https://reviews.llvm.org/D30683" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D30683</a><br class="gmail_msg">
<br class="gmail_msg">
Modified:<br class="gmail_msg">
    llvm/trunk/lib/Fuzzer/FuzzerMutate.cpp<br class="gmail_msg">
    llvm/trunk/lib/Fuzzer/FuzzerMutate.h<br class="gmail_msg">
<br class="gmail_msg">
Modified: llvm/trunk/lib/Fuzzer/FuzzerMutate.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Fuzzer/FuzzerMutate.cpp?rev=297891&r1=297890&r2=297891&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Fuzzer/FuzzerMutate.cpp?rev=297891&r1=297890&r2=297891&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- llvm/trunk/lib/Fuzzer/FuzzerMutate.cpp (original)<br class="gmail_msg">
+++ llvm/trunk/lib/Fuzzer/FuzzerMutate.cpp Wed Mar 15 15:59:27 2017<br class="gmail_msg">
@@ -77,7 +77,7 @@ size_t MutationDispatcher::Mutate_Custom<br class="gmail_msg">
                                                   size_t MaxSize) {<br class="gmail_msg">
   if (!Corpus || Corpus->size() < 2 || Size == 0)<br class="gmail_msg">
     return 0;<br class="gmail_msg">
-  size_t Idx = Rand(Corpus->size());<br class="gmail_msg">
+  size_t Idx = Corpus->ChooseUnitIdxToMutate(Rand);<br class="gmail_msg">
   const Unit &Other = (*Corpus)[Idx];<br class="gmail_msg">
   if (Other.empty())<br class="gmail_msg">
     return 0;<br class="gmail_msg">
<br class="gmail_msg">
Modified: llvm/trunk/lib/Fuzzer/FuzzerMutate.h<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Fuzzer/FuzzerMutate.h?rev=297891&r1=297890&r2=297891&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Fuzzer/FuzzerMutate.h?rev=297891&r1=297890&r2=297891&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- llvm/trunk/lib/Fuzzer/FuzzerMutate.h (original)<br class="gmail_msg">
+++ llvm/trunk/lib/Fuzzer/FuzzerMutate.h Wed Mar 15 15:59:27 2017<br class="gmail_msg">
@@ -88,7 +88,7 @@ public:<br class="gmail_msg">
   void ClearAutoDictionary();<br class="gmail_msg">
   void PrintRecommendedDictionary();<br class="gmail_msg">
<br class="gmail_msg">
-  void SetCorpus(const InputCorpus *Corpus) { this->Corpus = Corpus; }<br class="gmail_msg">
+  void SetCorpus(InputCorpus *Corpus) { this->Corpus = Corpus; }<br class="gmail_msg">
<br class="gmail_msg">
   Random &GetRand() { return Rand; }<br class="gmail_msg">
<br class="gmail_msg">
@@ -141,7 +141,7 @@ private:<br class="gmail_msg">
   DictionaryEntry CmpDictionaryEntriesDeque[kCmpDictionaryEntriesDequeSize];<br class="gmail_msg">
   size_t CmpDictionaryEntriesDequeIdx = 0;<br class="gmail_msg">
<br class="gmail_msg">
-  const InputCorpus *Corpus = nullptr;<br class="gmail_msg">
+  InputCorpus *Corpus = nullptr;<br class="gmail_msg">
   std::vector<uint8_t> MutateInPlaceHere;<br class="gmail_msg">
   // CustomCrossOver needs its own buffer as a custom implementation may call<br class="gmail_msg">
   // LLVMFuzzerMutate, which in turn may resize MutateInPlaceHere.<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
llvm-commits mailing list<br class="gmail_msg">
<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="gmail_msg">
</blockquote></div><br class="gmail_msg"><br clear="all" class="gmail_msg"><div class="gmail_msg"><br class="gmail_msg"></div></div><div class="gmail_extra gmail_msg">-- <br class="gmail_msg"><div class="m_-746690781143453109gmail_signature gmail_msg" data-smartmail="gmail_signature">Bruno Cardoso Lopes <br class="gmail_msg"><a href="http://www.brunocardoso.cc" class="gmail_msg" target="_blank">http://www.brunocardoso.cc</a></div>
</div></blockquote></div>