<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class="">Thanks Maxim, I committed the fix in r297763.</div><div class=""><br class=""></div><div class="">-Dimitry</div><br class=""><div><blockquote type="cite" class=""><div class="">On 14 Mar 2017, at 19:07, Maxim Ostapenko <<a href="mailto:chefmax7@gmail.com" class="">chefmax7@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="auto" class="">Hi Dimitry, <div class=""><br class=""><div class="gmail_extra"><div class="gmail_quote">14 Мар 2017 г. 21:32 пользователь "Dimitry Andric" <<a href="mailto:dimitry@andric.com" class="">dimitry@andric.com</a>> написал:<br type="attribution" class=""><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Maxim,<br class="">
<br class="">
This also doesn't compile on FreeBSD, and actually on any non-glibc >= 2.3.4 platform.<br class=""></blockquote></div></div></div><div dir="auto" class=""><br class=""></div><div dir="auto" class="">Oh, sorry about that. </div><div dir="auto" class=""><br class=""></div><div dir="auto" class=""><div class="gmail_extra"><div class="gmail_quote"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br class="">
Can we just check for the existence of RTLD_DEEPBIND instead? E.g.:<br class=""></blockquote></div></div></div><div dir="auto" class=""><br class=""></div><div dir="auto" class="">Sure, could you please apply the patch? Or should I do it by myself? </div><div dir="auto" class=""><br class=""></div><div dir="auto" class="">-Maxim</div><div dir="auto" class=""><br class=""></div><div dir="auto" class=""><div class="gmail_extra"><div class="gmail_quote"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br class="">
Index: projects/compiler-rt/lib/<wbr class="">sanitizer_common/sanitizer_<wbr class=""><a href="http://linux.cc" class="">linux.cc</a><br class="">
==============================<wbr class="">==============================<wbr class="">=======<br class="">
--- projects/compiler-rt/lib/<wbr class="">sanitizer_common/sanitizer_<wbr class="">linux.cc (revision 297742)<br class="">
+++ projects/compiler-rt/lib/<wbr class="">sanitizer_common/sanitizer_<wbr class="">linux.cc (working copy)<br class="">
@@ -1463,7 +1463,7 @@ void MaybeReexec() {<br class="">
<div class="quoted-text"> void PrintModuleMap() { }<br class="">
<br class="">
void CheckNoDeepBind(const char *filename, int flag) {<br class="">
</div>-#if !SANITIZER_ANDROID<br class="">
+#ifdef RTLD_DEEPBIND<br class="">
<div class="quoted-text"> if (flag & RTLD_DEEPBIND) {<br class="">
Report(<br class="">
"You are trying to dlopen a %s shared library with RTLD_DEEPBIND flag"<br class="">
<br class="">
</div><font color="#888888" class="">-Dimitry<br class="">
</font><div class="elided-text"><br class="">
> On 9 Mar 2017, at 15:40, Maxim Ostapenko via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:<br class="">
><br class="">
> Author: chefmax<br class="">
> Date: Thu Mar 9 08:40:15 2017<br class="">
> New Revision: 297383<br class="">
><br class="">
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=297383&view=rev" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-<wbr class="">project?rev=297383&view=rev</a><br class="">
> Log:<br class="">
> [sanitizer] Fix android buildbots after r297370<br class="">
><br class="">
> Modified:<br class="">
> compiler-rt/trunk/lib/<wbr class="">sanitizer_common/sanitizer_<wbr class="">linux.cc<br class="">
><br class="">
> Modified: compiler-rt/trunk/lib/<wbr class="">sanitizer_common/sanitizer_<wbr class="">linux.cc<br class="">
> URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_linux.cc?rev=297383&r1=297382&r2=297383&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-<wbr class="">project/compiler-rt/trunk/lib/<wbr class="">sanitizer_common/sanitizer_<wbr class="">linux.cc?rev=297383&r1=297382&<wbr class="">r2=297383&view=diff</a><br class="">
> ==============================<wbr class="">==============================<wbr class="">==================<br class="">
> --- compiler-rt/trunk/lib/<wbr class="">sanitizer_common/sanitizer_<wbr class="">linux.cc (original)<br class="">
> +++ compiler-rt/trunk/lib/<wbr class="">sanitizer_common/sanitizer_<wbr class="">linux.cc Thu Mar 9 08:40:15 2017<br class="">
> @@ -1461,6 +1461,7 @@ void MaybeReexec() {<br class="">
> void PrintModuleMap() { }<br class="">
><br class="">
> void CheckNoDeepBind(const char *filename, int flag) {<br class="">
> +#if !SANITIZER_ANDROID<br class="">
> if (flag & RTLD_DEEPBIND) {<br class="">
> Report(<br class="">
> "You are trying to dlopen a %s shared library with RTLD_DEEPBIND flag"<br class="">
> @@ -1471,6 +1472,7 @@ void CheckNoDeepBind(const char *filenam<br class="">
> filename, filename);<br class="">
> Die();<br class="">
> }<br class="">
> +#endif<br class="">
> }<br class="">
><br class="">
> uptr FindAvailableMemoryRange(uptr size, uptr alignment, uptr left_padding) {<br class="">
><br class="">
><br class="">
> ______________________________<wbr class="">_________________<br class="">
> llvm-commits mailing list<br class="">
> <a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a><br class="">
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/<wbr class="">mailman/listinfo/llvm-commits</a><br class="">
<br class="">
</div></blockquote></div><br class=""></div></div></div>
</div></blockquote></div><br class=""></body></html>