<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:dt="uuid:C2F41010-65B3-11d1-A29F-00AA00C14882" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=utf-8"><meta name=Generator content="Microsoft Word 14 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.E-MailFormatvorlage17
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 2.0cm 70.85pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang=EN-US link=blue vlink=purple><div class=WordSection1><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>I went ahead and committed r297260 which removes the test.<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>Thanks,<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>Jonas<o:p></o:p></span></p><p class=MsoNormal><o:p> </o:p></p><div style='border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt'><div><div style='border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm'><p class=MsoNormal><b><span lang=DE style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'>From:</span></b><span lang=DE style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'> Zachary Turner [mailto:zturner@google.com] <br><b>Sent:</b> Friday, March 03, 2017 5:57 PM<br><b>To:</b> Simon Dardis; Hahnfeld, Jonas<br><b>Cc:</b> llvm-commits@lists.llvm.org<br><b>Subject:</b> Re: [llvm] r295768 - [Support] Add a function to check if a file resides locally.<o:p></o:p></span></p></div></div><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>Honestly i think it may just be better to delete the test. I knew this test had the chance of breaking when I originally added it but didn't think it would occur.<br><br>There are plenty of examples of untested functions for low level system functions whose results can't be predicted. Imagine getting the system page size or system temp directory for example. <o:p></o:p></p><div><div><p class=MsoNormal>On Fri, Mar 3, 2017 at 8:49 AM Simon Dardis <<a href="mailto:Simon.Dardis@imgtec.com">Simon.Dardis@imgtec.com</a>> wrote:<o:p></o:p></p></div><blockquote style='border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm'><p class=MsoNormal style='margin-bottom:12.0pt'>I was considering the option of using an environmental variable as well. In our case, half our<br>buildbots are configured to use remote storage due to the nature of the machines themselves.<br><br>I think the environment variable route is the only cross platform way to retain the test in a<br>useful fashion.<br><br>It would also help dealing with tests (in the future) which are by their nature sensitive to the<br>environment they're running it. Given the majority of buildbots (and developers I presume)<br>build and test in a 'regular' environment, we wouldn't lose test coverage for the small minority<br>with more exotic environments.<br><br>I do agree it's quite the sledgehammer approach.<br><br>Thanks,<br>Simon<br><br>From: Hahnfeld, Jonas [mailto:<a href="mailto:Hahnfeld@itc.rwth-aachen.de" target="_blank">Hahnfeld@itc.rwth-aachen.de</a>]<br>Sent: 03 March 2017 16:20<br>To: <a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a><br>Cc: Simon Dardis; <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>Subject: Re: [llvm] r295768 - [Support] Add a function to check if a file resides locally.<br><br>In the latter case, #1 doesn't work either. We could introduce an option or a variable in the environment to enable this specific test and set it on a few build bots, but that seems a bit overkill...<br><br>Am Freitag, den 03.03.2017, 15:27 +0000 schrieb Zachary Turner:<br>#2 would introduce enough additional file system code into the test that the code building up to the important part is more likely to fail than the important part.<br><br>I could also imagine someone installing their entire os on an NFS so perhaps there is just nothing we can do<br>On Thu, Mar 2, 2017 at 11:15 PM Hahnfeld, Jonas <<a href="mailto:Hahnfeld@itc.rwth-aachen.de" target="_blank">Hahnfeld@itc.rwth-aachen.de</a>> wrote:<br>Two more ideas after thinking about the problem a bit more:<br>1) We could test with a file in $TMP and hope that it is local.<br>2) On *nix systems, we could parse all mounted paths and blacklist certain filesystems, namely NFS to begin with.<br>I think both methods may be error prone in some cases. The only other solution is removing the test which I also quite don’t like that much.<br> <br>From: Zachary Turner [mailto:<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>]<br>Sent: Friday, March 03, 2017 7:56 AM<br>To: Hahnfeld, Jonas<br>Cc: Simon Dardis; <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>Subject: Re: [llvm] r295768 - [Support] Add a function to check if a file resides locally.<br> <br>My only idea in that case is to just delete the test sadly :-/<br><br>I can't think of a way to reliably test this if we can't assume we're on a local filesystem<br>On Thu, Mar 2, 2017 at 2:04 AM Hahnfeld, Jonas <<a href="mailto:Hahnfeld@itc.rwth-aachen.de" target="_blank">Hahnfeld@itc.rwth-aachen.de</a>> wrote:<br>Hi Zachary,<br><br>This change essentially breaks tests when anyone is building on NFS as I do.<br>Simon XFAIL'd the test for the mips buildbots in r295840 but that leaves the<br>problem for anyone else.<br><br>Do you have a clever solution for that?<br><br>Regards,<br>Jonas<br><br>> -----Original Message-----<br>> From: llvm-commits [mailto:<a href="mailto:llvm-commits-bounces@lists.llvm.org" target="_blank">llvm-commits-bounces@lists.llvm.org</a>] On Behalf<br>> Of Zachary Turner via llvm-commits<br>> Sent: Tuesday, February 21, 2017 9:56 PM<br>> To: <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>> Subject: [llvm] r295768 - [Support] Add a function to check if a file<br>> resides<br>> locally.<br>><br>> Author: zturner<br>> Date: Tue Feb 21 14:55:47 2017<br>> New Revision: 295768<br>><br>> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=295768&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=295768&view=rev</a><br>> Log:<br>> [Support] Add a function to check if a file resides locally.<br>><br>> Differential Revision: <a href="https://reviews.llvm.org/D30010" target="_blank">https://reviews.llvm.org/D30010</a><br>><br>> Modified:<br>> llvm/trunk/include/llvm/Support/FileSystem.h<br>> llvm/trunk/include/llvm/Support/MemoryBuffer.h<br>> llvm/trunk/lib/Support/MemoryBuffer.cpp<br>> llvm/trunk/lib/Support/Unix/Path.inc<br>> llvm/trunk/lib/Support/Windows/Path.inc<br>> llvm/trunk/unittests/Support/Path.cpp<o:p></o:p></p></blockquote></div></div></div></body></html>