<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
mso-fareast-language:EN-US;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-GB" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">This was caused by stdout and stderr being interleaved in a way that caused the test to fail.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">I’ve committed https://reviews.llvm.org/rL297273 which splits up the test which should<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">fix this.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">John<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Zachary Turner [mailto:zturner@google.com]
<br>
<b>Sent:</b> 07 March 2017 21:26<br>
<b>To:</b> reviews+D30692+public+d360c608692dd812@reviews.llvm.org; John Brawn via Phabricator; John Brawn; renato.golin@linaro.org; James Molloy; Oliver Stannard<br>
<b>Cc:</b> llvm-commits@lists.llvm.org<br>
<b>Subject:</b> Re: [PATCH] D30692: [ARM] Correct handling of LSL #0 in an IT block<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">This appears to be failing ON Windows. Can you take a look?<o:p></o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<div>
<p class="MsoNormal">******************** TEST 'LLVM :: MC/ARM/lsl-zero.s' FAILED ********************<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Script:<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">--<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">not D:/src/llvmbuild/ninja-mono/./bin\llvm-mc.EXE -triple=thumbv7 -show-encoding < D:\src\llvm-mono\llvm\test\MC\ARM\lsl-zero.s 2>&1 | D:/src/llvmbuild/ninja-mono/./bin\FileCheck.EXE --check-prefix=CHECK --check-prefix=CHECK-NONARM --check-prefix=CHECK-THUMBV7
D:\src\llvm-mono\llvm\test\MC\ARM\lsl-zero.s<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">not D:/src/llvmbuild/ninja-mono/./bin\llvm-mc.EXE -triple=thumbv8 -show-encoding < D:\src\llvm-mono\llvm\test\MC\ARM\lsl-zero.s 2>&1 | D:/src/llvmbuild/ninja-mono/./bin\FileCheck.EXE --check-prefix=CHECK --check-prefix=CHECK-NONARM --check-prefix=CHECK-THUMBV8
D:\src\llvm-mono\llvm\test\MC\ARM\lsl-zero.s<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">D:/src/llvmbuild/ninja-mono/./bin\llvm-mc.EXE -triple=armv7 -show-encoding < D:\src\llvm-mono\llvm\test\MC\ARM\lsl-zero.s 2>&1 | D:/src/llvmbuild/ninja-mono/./bin\FileCheck.EXE --check-prefix=CHECK --check-prefix=CHECK-ARM D:\src\llvm-mono\llvm\test\MC\ARM\lsl-zero.s<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">--<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Exit Code: 1<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Command Output (stdout):<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">--<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">$ "not" "D:/src/llvmbuild/ninja-mono/./bin\llvm-mc.EXE" "-triple=thumbv7" "-show-encoding"<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">$ "D:/src/llvmbuild/ninja-mono/./bin\FileCheck.EXE" "--check-prefix=CHECK" "--check-prefix=CHECK-NONARM" "--check-prefix=CHECK-THUMBV7" "D:\src\llvm-mono\llvm\test\MC\ARM\lsl-zero.s"<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">$ "not" "D:/src/llvmbuild/ninja-mono/./bin\llvm-mc.EXE" "-triple=thumbv8" "-show-encoding"<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">$ "D:/src/llvmbuild/ninja-mono/./bin\FileCheck.EXE" "--check-prefix=CHECK" "--check-prefix=CHECK-NONARM" "--check-prefix=CHECK-THUMBV8" "D:\src\llvm-mono\llvm\test\MC\ARM\lsl-zero.s"<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"># command stderr:<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">D:\src\llvm-mono\llvm\test\MC\ARM\lsl-zero.s:146:18: error: expected string not found in input<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">// CHECK-NONARM: moveq.w r0, r1 @ encoding: [0x4f,0xea,0x01,0x00]<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> ^<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><stdin>:119:1: note: scanning from here<o:p></o:p></p>
</div>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<p class="MsoNormal">On Tue, Mar 7, 2017 at 6:54 AM John Brawn via Phabricator via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<o:p></o:p></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm">
<p class="MsoNormal">This revision was automatically updated to reflect the committed changes.<br>
Closed by commit rL297142: [ARM] Correct handling of LSL #0 in an IT block (authored by john.brawn).<br>
<br>
Changed prior to commit:<br>
<a href="https://reviews.llvm.org/D30692?vs=90845&id=90847#toc" target="_blank">
https://reviews.llvm.org/D30692?vs=90845&id=90847#toc</a><br>
<br>
Repository:<br>
rL LLVM<br>
<br>
<a href="https://reviews.llvm.org/D30692" target="_blank">https://reviews.llvm.org/D30692</a><br>
<br>
Files:<br>
llvm/trunk/lib/Target/ARM/AsmParser/ARMAsmParser.cpp<br>
llvm/trunk/test/MC/ARM/lsl-zero.s<br>
<br>
<br>
Index: llvm/trunk/lib/Target/ARM/AsmParser/ARMAsmParser.cpp<br>
===================================================================<br>
--- llvm/trunk/lib/Target/ARM/AsmParser/ARMAsmParser.cpp<br>
+++ llvm/trunk/lib/Target/ARM/AsmParser/ARMAsmParser.cpp<br>
@@ -8940,7 +8940,7 @@<br>
inITBlock())<br>
return Match_RequiresNotITBlock;<br>
// LSL with zero immediate is not allowed in an IT block<br>
- if (Opc == ARM::tLSLri && Inst.getOperand(4).getImm() == 0 && inITBlock())<br>
+ if (Opc == ARM::tLSLri && Inst.getOperand(3).getImm() == 0 && inITBlock())<br>
return Match_RequiresNotITBlock;<br>
} else if (isThumbOne()) {<br>
// Some high-register supporting Thumb1 encodings only allow both registers<br>
Index: llvm/trunk/test/MC/ARM/lsl-zero.s<br>
===================================================================<br>
--- llvm/trunk/test/MC/ARM/lsl-zero.s<br>
+++ llvm/trunk/test/MC/ARM/lsl-zero.s<br>
@@ -122,19 +122,33 @@<br>
itt eq<br>
lsleq r0, r1, #0<br>
lslseq r0, r1, #0<br>
+ itt gt<br>
+ lslgt r0, r1, #0<br>
+ lslsgt r0, r1, #0<br>
<br>
// CHECK-NONARM: moveq.w r0, r1 @ encoding: [0x4f,0xea,0x01,0x00]<br>
// CHECK-NONARM: movseq.w r0, r1 @ encoding: [0x5f,0xea,0x01,0x00]<br>
+// CHECK-NONARM: movgt.w r0, r1 @ encoding: [0x4f,0xea,0x01,0x00]<br>
+// CHECK-NONARM: movsgt.w r0, r1 @ encoding: [0x5f,0xea,0x01,0x00]<br>
<br>
// CHECK-ARM: moveq r0, r1 @ encoding: [0x01,0x00,0xa0,0x01]<br>
// CHECK-ARM: movseq r0, r1 @ encoding: [0x01,0x00,0xb0,0x01]<br>
+// CHECK-ARM: movgt r0, r1 @ encoding: [0x01,0x00,0xa0,0xc1]<br>
+// CHECK-ARM: movsgt r0, r1 @ encoding: [0x01,0x00,0xb0,0xc1]<br>
<br>
itt eq<br>
moveq r0, r1, lsl #0<br>
movseq r0, r1, lsl #0<br>
+ itt gt<br>
+ movgt r0, r1, lsl #0<br>
+ movsgt r0, r1, lsl #0<br>
<br>
// CHECK-NONARM: moveq.w r0, r1 @ encoding: [0x4f,0xea,0x01,0x00]<br>
// CHECK-NONARM: movseq.w r0, r1 @ encoding: [0x5f,0xea,0x01,0x00]<br>
+// CHECK-NONARM: movgt.w r0, r1 @ encoding: [0x4f,0xea,0x01,0x00]<br>
+// CHECK-NONARM: movsgt.w r0, r1 @ encoding: [0x5f,0xea,0x01,0x00]<br>
<br>
// CHECK-ARM: moveq r0, r1 @ encoding: [0x01,0x00,0xa0,0x01]<br>
// CHECK-ARM: movseq r0, r1 @ encoding: [0x01,0x00,0xb0,0x01]<br>
+// CHECK-ARM: movgt r0, r1 @ encoding: [0x01,0x00,0xa0,0xc1]<br>
+// CHECK-ARM: movsgt r0, r1 @ encoding: [0x01,0x00,0xb0,0xc1]<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><o:p></o:p></p>
</blockquote>
</div>
</div>
</div>
</body>
</html>