<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
</head>
<body>
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Arial,Helvetica,sans-serif;" dir="ltr">
<p>That looks good to me. Thanks, and sorry about that.</p>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Zachary Turner <zturner@google.com><br>
<b>Sent:</b> Tuesday, March 7, 2017 4:59:17 PM<br>
<b>To:</b> reviews+D30679+public+115d2c040c88ea33@reviews.llvm.org; Konstantin Zhuravlyov via Phabricator; Zhuravlyov, Konstantin; Arsenault, Matthew; Liu, Yaxun (Sam)<br>
<b>Cc:</b> Ding, Wei; llvm-commits@lists.llvm.org; tpr.llvm@botech.co.uk; Stuttard, David; Tye, Tony<br>
<b>Subject:</b> Re: [PATCH] D30679: llvm-objdump: handle line numbers and source options for amdgpu objects</font>
<div> </div>
</div>
<div>
<div dir="ltr">This test is broken on Windows. Please take a look at this patch and see if it looks like an appropriate fix.
<div><br>
</div>
<div>In general this is a standard practice for tests where pathnames are concerned, but in this case I just want to make sure the value of the path prior to the source file name is not strictly important.</div>
<div><br>
</div>
<div><br>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr">On Tue, Mar 7, 2017 at 12:29 PM Konstantin Zhuravlyov via Phabricator via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
This revision was automatically updated to reflect the committed changes.<br class="gmail_msg">
Closed by commit rL297193: llvm-objdump: handle line numbers and source options for amdgpu objects (authored by kzhuravl).<br class="gmail_msg">
<br class="gmail_msg">
Changed prior to commit:<br class="gmail_msg">
<a href="https://reviews.llvm.org/D30679?vs=90798&id=90911#toc" rel="noreferrer" class="gmail_msg" target="_blank">
https://reviews.llvm.org/D30679?vs=90798&id=90911#toc</a><br class="gmail_msg">
<br class="gmail_msg">
Repository:<br class="gmail_msg">
rL LLVM<br class="gmail_msg">
<br class="gmail_msg">
<a href="https://reviews.llvm.org/D30679" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D30679</a><br class="gmail_msg">
<br class="gmail_msg">
Files:<br class="gmail_msg">
llvm/trunk/test/tools/llvm-objdump/AMDGPU/Inputs/<a href="http://source-lines.cl" rel="noreferrer" class="gmail_msg" target="_blank">source-lines.cl</a><br class="gmail_msg">
llvm/trunk/test/tools/llvm-objdump/AMDGPU/lit.local.cfg<br class="gmail_msg">
llvm/trunk/test/tools/llvm-objdump/AMDGPU/source-lines.ll<br class="gmail_msg">
llvm/trunk/tools/llvm-objdump/llvm-objdump.cpp<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
llvm-commits mailing list<br class="gmail_msg">
<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="gmail_msg">
</blockquote>
</div>
</div>
</div>
</body>
</html>