<div dir="ltr">This appears to be failing ON Windows.  Can you take a look?<div><br></div><div><div>******************** TEST 'LLVM :: MC/ARM/lsl-zero.s' FAILED ********************</div><div>Script:</div><div>--</div><div>not D:/src/llvmbuild/ninja-mono/./bin\llvm-mc.EXE -triple=thumbv7 -show-encoding < D:\src\llvm-mono\llvm\test\MC\ARM\lsl-zero.s 2>&1 | D:/src/llvmbuild/ninja-mono/./bin\FileCheck.EXE --check-prefix=CHECK --check-prefix=CHECK-NONARM --check-prefix=CHECK-THUMBV7 D:\src\llvm-mono\llvm\test\MC\ARM\lsl-zero.s</div><div>not D:/src/llvmbuild/ninja-mono/./bin\llvm-mc.EXE -triple=thumbv8 -show-encoding < D:\src\llvm-mono\llvm\test\MC\ARM\lsl-zero.s 2>&1 | D:/src/llvmbuild/ninja-mono/./bin\FileCheck.EXE --check-prefix=CHECK --check-prefix=CHECK-NONARM --check-prefix=CHECK-THUMBV8 D:\src\llvm-mono\llvm\test\MC\ARM\lsl-zero.s</div><div>D:/src/llvmbuild/ninja-mono/./bin\llvm-mc.EXE -triple=armv7 -show-encoding < D:\src\llvm-mono\llvm\test\MC\ARM\lsl-zero.s 2>&1 | D:/src/llvmbuild/ninja-mono/./bin\FileCheck.EXE --check-prefix=CHECK --check-prefix=CHECK-ARM D:\src\llvm-mono\llvm\test\MC\ARM\lsl-zero.s</div><div>--</div><div>Exit Code: 1</div><div><br></div><div>Command Output (stdout):</div><div>--</div><div>$ "not" "D:/src/llvmbuild/ninja-mono/./bin\llvm-mc.EXE" "-triple=thumbv7" "-show-encoding"</div><div>$ "D:/src/llvmbuild/ninja-mono/./bin\FileCheck.EXE" "--check-prefix=CHECK" "--check-prefix=CHECK-NONARM" "--check-prefix=CHECK-THUMBV7" "D:\src\llvm-mono\llvm\test\MC\ARM\lsl-zero.s"</div><div>$ "not" "D:/src/llvmbuild/ninja-mono/./bin\llvm-mc.EXE" "-triple=thumbv8" "-show-encoding"</div><div>$ "D:/src/llvmbuild/ninja-mono/./bin\FileCheck.EXE" "--check-prefix=CHECK" "--check-prefix=CHECK-NONARM" "--check-prefix=CHECK-THUMBV8" "D:\src\llvm-mono\llvm\test\MC\ARM\lsl-zero.s"</div><div># command stderr:</div><div>D:\src\llvm-mono\llvm\test\MC\ARM\lsl-zero.s:146:18: error: expected string not found in input</div><div>// CHECK-NONARM: moveq.w r0, r1 @ encoding: [0x4f,0xea,0x01,0x00]</div><div>                 ^</div><div><stdin>:119:1: note: scanning from here</div></div></div><br><div class="gmail_quote"><div dir="ltr">On Tue, Mar 7, 2017 at 6:54 AM John Brawn via Phabricator via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This revision was automatically updated to reflect the committed changes.<br class="gmail_msg">
Closed by commit rL297142: [ARM] Correct handling of LSL #0 in an IT block (authored by john.brawn).<br class="gmail_msg">
<br class="gmail_msg">
Changed prior to commit:<br class="gmail_msg">
  <a href="https://reviews.llvm.org/D30692?vs=90845&id=90847#toc" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D30692?vs=90845&id=90847#toc</a><br class="gmail_msg">
<br class="gmail_msg">
Repository:<br class="gmail_msg">
  rL LLVM<br class="gmail_msg">
<br class="gmail_msg">
<a href="https://reviews.llvm.org/D30692" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D30692</a><br class="gmail_msg">
<br class="gmail_msg">
Files:<br class="gmail_msg">
  llvm/trunk/lib/Target/ARM/AsmParser/ARMAsmParser.cpp<br class="gmail_msg">
  llvm/trunk/test/MC/ARM/lsl-zero.s<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
Index: llvm/trunk/lib/Target/ARM/AsmParser/ARMAsmParser.cpp<br class="gmail_msg">
===================================================================<br class="gmail_msg">
--- llvm/trunk/lib/Target/ARM/AsmParser/ARMAsmParser.cpp<br class="gmail_msg">
+++ llvm/trunk/lib/Target/ARM/AsmParser/ARMAsmParser.cpp<br class="gmail_msg">
@@ -8940,7 +8940,7 @@<br class="gmail_msg">
         inITBlock())<br class="gmail_msg">
       return Match_RequiresNotITBlock;<br class="gmail_msg">
     // LSL with zero immediate is not allowed in an IT block<br class="gmail_msg">
-    if (Opc == ARM::tLSLri && Inst.getOperand(4).getImm() == 0 && inITBlock())<br class="gmail_msg">
+    if (Opc == ARM::tLSLri && Inst.getOperand(3).getImm() == 0 && inITBlock())<br class="gmail_msg">
       return Match_RequiresNotITBlock;<br class="gmail_msg">
   } else if (isThumbOne()) {<br class="gmail_msg">
     // Some high-register supporting Thumb1 encodings only allow both registers<br class="gmail_msg">
Index: llvm/trunk/test/MC/ARM/lsl-zero.s<br class="gmail_msg">
===================================================================<br class="gmail_msg">
--- llvm/trunk/test/MC/ARM/lsl-zero.s<br class="gmail_msg">
+++ llvm/trunk/test/MC/ARM/lsl-zero.s<br class="gmail_msg">
@@ -122,19 +122,33 @@<br class="gmail_msg">
         itt eq<br class="gmail_msg">
         lsleq  r0, r1, #0<br class="gmail_msg">
         lslseq r0, r1, #0<br class="gmail_msg">
+        itt gt<br class="gmail_msg">
+        lslgt  r0, r1, #0<br class="gmail_msg">
+        lslsgt r0, r1, #0<br class="gmail_msg">
<br class="gmail_msg">
 // CHECK-NONARM: moveq.w r0, r1         @ encoding: [0x4f,0xea,0x01,0x00]<br class="gmail_msg">
 // CHECK-NONARM: movseq.w r0, r1        @ encoding: [0x5f,0xea,0x01,0x00]<br class="gmail_msg">
+// CHECK-NONARM: movgt.w r0, r1         @ encoding: [0x4f,0xea,0x01,0x00]<br class="gmail_msg">
+// CHECK-NONARM: movsgt.w r0, r1        @ encoding: [0x5f,0xea,0x01,0x00]<br class="gmail_msg">
<br class="gmail_msg">
 // CHECK-ARM: moveq r0, r1              @ encoding: [0x01,0x00,0xa0,0x01]<br class="gmail_msg">
 // CHECK-ARM: movseq r0, r1             @ encoding: [0x01,0x00,0xb0,0x01]<br class="gmail_msg">
+// CHECK-ARM: movgt r0, r1              @ encoding: [0x01,0x00,0xa0,0xc1]<br class="gmail_msg">
+// CHECK-ARM: movsgt r0, r1             @ encoding: [0x01,0x00,0xb0,0xc1]<br class="gmail_msg">
<br class="gmail_msg">
         itt eq<br class="gmail_msg">
         moveq  r0, r1, lsl #0<br class="gmail_msg">
         movseq r0, r1, lsl #0<br class="gmail_msg">
+        itt gt<br class="gmail_msg">
+        movgt  r0, r1, lsl #0<br class="gmail_msg">
+        movsgt r0, r1, lsl #0<br class="gmail_msg">
<br class="gmail_msg">
 // CHECK-NONARM: moveq.w r0, r1         @ encoding: [0x4f,0xea,0x01,0x00]<br class="gmail_msg">
 // CHECK-NONARM: movseq.w r0, r1        @ encoding: [0x5f,0xea,0x01,0x00]<br class="gmail_msg">
+// CHECK-NONARM: movgt.w r0, r1         @ encoding: [0x4f,0xea,0x01,0x00]<br class="gmail_msg">
+// CHECK-NONARM: movsgt.w r0, r1        @ encoding: [0x5f,0xea,0x01,0x00]<br class="gmail_msg">
<br class="gmail_msg">
 // CHECK-ARM: moveq r0, r1              @ encoding: [0x01,0x00,0xa0,0x01]<br class="gmail_msg">
 // CHECK-ARM: movseq r0, r1             @ encoding: [0x01,0x00,0xb0,0x01]<br class="gmail_msg">
+// CHECK-ARM: movgt r0, r1              @ encoding: [0x01,0x00,0xa0,0xc1]<br class="gmail_msg">
+// CHECK-ARM: movsgt r0, r1             @ encoding: [0x01,0x00,0xb0,0xc1]<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
llvm-commits mailing list<br class="gmail_msg">
<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="gmail_msg">
</blockquote></div>