<div dir="ltr">Thanks! I kept seeing that/meaning to fix it and never got around to it.<br><br></div><br><div class="gmail_quote"><div dir="ltr">On Wed, Mar 1, 2017 at 11:55 AM Paul Robinson via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: probinson<br class="gmail_msg">
Date: Wed Mar  1 13:43:29 2017<br class="gmail_msg">
New Revision: 296663<br class="gmail_msg">
<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=296663&view=rev" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project?rev=296663&view=rev</a><br class="gmail_msg">
Log:<br class="gmail_msg">
[DWARF] Print leading zeros in type signature<br class="gmail_msg">
<br class="gmail_msg">
Modified:<br class="gmail_msg">
    llvm/trunk/lib/DebugInfo/DWARF/DWARFTypeUnit.cpp<br class="gmail_msg">
    llvm/trunk/test/DebugInfo/Inputs/dwarfdump-header.elf-x86-64<br class="gmail_msg">
    llvm/trunk/test/DebugInfo/Inputs/dwarfdump-header.s<br class="gmail_msg">
    llvm/trunk/test/DebugInfo/dwarfdump-header.test<br class="gmail_msg">
<br class="gmail_msg">
Modified: llvm/trunk/lib/DebugInfo/DWARF/DWARFTypeUnit.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/DWARF/DWARFTypeUnit.cpp?rev=296663&r1=296662&r2=296663&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/DWARF/DWARFTypeUnit.cpp?rev=296663&r1=296662&r2=296663&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- llvm/trunk/lib/DebugInfo/DWARF/DWARFTypeUnit.cpp (original)<br class="gmail_msg">
+++ llvm/trunk/lib/DebugInfo/DWARF/DWARFTypeUnit.cpp Wed Mar  1 13:43:29 2017<br class="gmail_msg">
@@ -33,7 +33,7 @@ void DWARFTypeUnit::dump(raw_ostream &OS<br class="gmail_msg">
<br class="gmail_msg">
   if (SummarizeTypes) {<br class="gmail_msg">
     OS << "name = '" << Name << "'"<br class="gmail_msg">
-       << " type_signature = " << format("0x%16" PRIx64, TypeHash)<br class="gmail_msg">
+       << " type_signature = " << format("0x%016" PRIx64, TypeHash)<br class="gmail_msg">
        << " length = " << format("0x%08x", getLength()) << '\n';<br class="gmail_msg">
     return;<br class="gmail_msg">
   }<br class="gmail_msg">
@@ -46,7 +46,7 @@ void DWARFTypeUnit::dump(raw_ostream &OS<br class="gmail_msg">
   OS << " abbr_offset = " << format("0x%04x", getAbbreviations()->getOffset())<br class="gmail_msg">
      << " addr_size = " << format("0x%02x", getAddressByteSize())<br class="gmail_msg">
      << " name = '" << Name << "'"<br class="gmail_msg">
-     << " type_signature = " << format("0x%16" PRIx64, TypeHash)<br class="gmail_msg">
+     << " type_signature = " << format("0x%016" PRIx64, TypeHash)<br class="gmail_msg">
      << " type_offset = " << format("0x%04x", TypeOffset)<br class="gmail_msg">
      << " (next unit at " << format("0x%08x", getNextUnitOffset()) << ")\n";<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
Modified: llvm/trunk/test/DebugInfo/Inputs/dwarfdump-header.elf-x86-64<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/Inputs/dwarfdump-header.elf-x86-64?rev=296663&r1=296662&r2=296663&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/Inputs/dwarfdump-header.elf-x86-64?rev=296663&r1=296662&r2=296663&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
Binary files - no diff available.<br class="gmail_msg">
<br class="gmail_msg">
Modified: llvm/trunk/test/DebugInfo/Inputs/dwarfdump-header.s<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/Inputs/dwarfdump-header.s?rev=296663&r1=296662&r2=296663&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/Inputs/dwarfdump-header.s?rev=296663&r1=296662&r2=296663&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- llvm/trunk/test/DebugInfo/Inputs/dwarfdump-header.s (original)<br class="gmail_msg">
+++ llvm/trunk/test/DebugInfo/Inputs/dwarfdump-header.s Wed Mar  1 13:43:29 2017<br class="gmail_msg">
@@ -111,7 +111,7 @@ TU_4_version:<br class="gmail_msg">
         .short 4               # DWARF version number<br class="gmail_msg">
         .long .debug_abbrev    # Offset Into Abbrev. Section<br class="gmail_msg">
         .byte 8                # Address Size (in bytes)<br class="gmail_msg">
-        .quad 0x1122334455667788 # Type Signature<br class="gmail_msg">
+        .quad 0x0011223344556677 # Type Signature<br class="gmail_msg">
         .long TU_4_type-TU_4_start # Type offset<br class="gmail_msg">
 # The type-unit DIE, which has a name.<br class="gmail_msg">
         .byte 2<br class="gmail_msg">
<br class="gmail_msg">
Modified: llvm/trunk/test/DebugInfo/dwarfdump-header.test<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/dwarfdump-header.test?rev=296663&r1=296662&r2=296663&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/dwarfdump-header.test?rev=296663&r1=296662&r2=296663&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- llvm/trunk/test/DebugInfo/dwarfdump-header.test (original)<br class="gmail_msg">
+++ llvm/trunk/test/DebugInfo/dwarfdump-header.test Wed Mar  1 13:43:29 2017<br class="gmail_msg">
@@ -19,7 +19,7 @@ CHECK-LABEL: .debug_types contents:<br class="gmail_msg">
<br class="gmail_msg">
 The v4 type unit header.<br class="gmail_msg">
<br class="gmail_msg">
-CHECK: 0x00000000: Type Unit: length = 0x0000001f version = 0x0004 abbr_offset = 0x0000 addr_size = 0x08 name = 'V4_type_unit' type_signature = 0x1122334455667788 type_offset = 0x001c (next unit at 0x00000023)<br class="gmail_msg">
+CHECK: 0x00000000: Type Unit: length = 0x0000001f version = 0x0004 abbr_offset = 0x0000 addr_size = 0x08 name = 'V4_type_unit' type_signature = 0x0011223344556677 type_offset = 0x001c (next unit at 0x00000023)<br class="gmail_msg">
 CHECK: 0x00000017: DW_TAG_type_unit<br class="gmail_msg">
<br class="gmail_msg">
 FIXME: DWARF v5 wants type units in .debug_info[.dwo] not .debug_types[.dwo].<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
llvm-commits mailing list<br class="gmail_msg">
<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="gmail_msg">
</blockquote></div>