<div dir="ltr"><a class="GWVZpf gW" id="IloFPc-0" href="mailto:mpel@google.com" tabindex="-1">+Martin Pelikán</a> -- I think this should already be fixed by the change submitted by <a class="GWVZpf gW" id="IloFPc-1" href="mailto:timshen@google.com" tabindex="-1">+Tim Shen</a><br></div><br><div class="gmail_quote"><div dir="ltr">On Tue, Mar 7, 2017 at 2:28 AM Bill Seurer <<a href="mailto:seurer@linux.vnet.ibm.com">seurer@linux.vnet.ibm.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Your change appears to cause an undefined symbol error when the test<br class="gmail_msg">
cases are building on ppc64le.<br class="gmail_msg">
<br class="gmail_msg">
<a href="http://lab.llvm.org:8011/builders/clang-ppc64le-linux/builds/4088" rel="noreferrer" class="gmail_msg" target="_blank">http://lab.llvm.org:8011/builders/clang-ppc64le-linux/builds/4088</a><br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<a href="http://lab.llvm.org:8011/builders/clang-ppc64le-linux/builds/4088/steps/ninja%20check%201/logs/stdio" rel="noreferrer" class="gmail_msg" target="_blank">http://lab.llvm.org:8011/builders/clang-ppc64le-linux/builds/4088/steps/ninja%20check%201/logs/stdio</a><br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
[71/143] cd<br class="gmail_msg">
/home/buildbots/ppc64le-clang-test/clang-ppc64le/stage1/projects/compiler-rt/lib/xray/tests/unit<br class="gmail_msg">
&& /home/buildbots/ppc64le-clang-test/clang-ppc64le/stage1/./bin/clang<br class="gmail_msg">
fdr_logging_test.cc.powerpc64le.o xray_unit_test_main.cc.powerpc64le.o<br class="gmail_msg">
gtest-all.cc.powerpc64le.o -o<br class="gmail_msg">
/home/buildbots/ppc64le-clang-test/clang-ppc64le/stage1/projects/compiler-rt/lib/xray/tests/unit/XRayFDRLoggingTest-powerpc64le<br class="gmail_msg">
-L/home/ubuntu/gcc/install/gcc-6.2.0/lib64 -Wl,-allow-shlib-undefined<br class="gmail_msg">
-m64 -fno-function-sections -lstdc++ -lm -lpthread -lpthread<br class="gmail_msg">
-L/home/buildbots/ppc64le-clang-test/clang-ppc64le/stage1/./lib/clang/5.0.0/lib/linux<br class="gmail_msg">
-lclang_rt.xray-powerpc64le -latomic -ldl -lrt<br class="gmail_msg">
FAILED: cd<br class="gmail_msg">
/home/buildbots/ppc64le-clang-test/clang-ppc64le/stage1/projects/compiler-rt/lib/xray/tests/unit<br class="gmail_msg">
&& /home/buildbots/ppc64le-clang-test/clang-ppc64le/stage1/./bin/clang<br class="gmail_msg">
fdr_logging_test.cc.powerpc64le.o xray_unit_test_main.cc.powerpc64le.o<br class="gmail_msg">
gtest-all.cc.powerpc64le.o -o<br class="gmail_msg">
/home/buildbots/ppc64le-clang-test/clang-ppc64le/stage1/projects/compiler-rt/lib/xray/tests/unit/XRayFDRLoggingTest-powerpc64le<br class="gmail_msg">
-L/home/ubuntu/gcc/install/gcc-6.2.0/lib64 -Wl,-allow-shlib-undefined<br class="gmail_msg">
-m64 -fno-function-sections -lstdc++ -lm -lpthread -lpthread<br class="gmail_msg">
-L/home/buildbots/ppc64le-clang-test/clang-ppc64le/stage1/./lib/clang/5.0.0/lib/linux<br class="gmail_msg">
-lclang_rt.xray-powerpc64le -latomic -ldl -lrt<br class="gmail_msg">
/home/buildbots/ppc64le-clang-test/clang-ppc64le/stage1/./lib/clang/5.0.0/lib/linux/libclang_rt.xray-powerpc64le.a(xray_interface.cc.o):(.toc+0x0):<br class="gmail_msg">
undefined reference to `__xray_ArgLoggerEntry'<br class="gmail_msg">
/home/buildbots/ppc64le-clang-test/clang-ppc64le/stage1/./lib/clang/5.0.0/lib/linux/libclang_rt.xray-powerpc64le.a(xray_interface.cc.o):<br class="gmail_msg">
In function `controlPatching(bool)':<br class="gmail_msg">
/home/buildbots/ppc64le-clang-test/clang-ppc64le/llvm/projects/compiler-rt/lib/xray/xray_interface.cc:191:<br class="gmail_msg">
undefined reference to `__xray::patchFunctionEntry(bool, unsigned int,<br class="gmail_msg">
XRaySledEntry const&, void (*)())'<br class="gmail_msg">
/home/buildbots/ppc64le-clang-test/clang-ppc64le/llvm/projects/compiler-rt/lib/xray/xray_interface.cc:200:<br class="gmail_msg">
undefined reference to `__xray::patchFunctionEntry(bool, unsigned int,<br class="gmail_msg">
XRaySledEntry const&, void (*)())'<br class="gmail_msg">
clang-4.0: error: linker command failed with exit code 1 (use -v to see<br class="gmail_msg">
invocation)<br class="gmail_msg">
ninja: build stopped: subcommand failed.<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
On 03/06/2017 12:48 AM, Dean Michael Berris via llvm-commits wrote:<br class="gmail_msg">
> Author: dberris<br class="gmail_msg">
> Date: Mon Mar 6 00:48:56 2017<br class="gmail_msg">
> New Revision: 296998<br class="gmail_msg">
><br class="gmail_msg">
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=296998&view=rev" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project?rev=296998&view=rev</a><br class="gmail_msg">
> Log:<br class="gmail_msg">
> [XRay] Allow logging the first argument of a function call.<br class="gmail_msg">
><br class="gmail_msg">
> Summary:<br class="gmail_msg">
> Functions with the "xray-log-args" attribute will have a special XRay sled kind<br class="gmail_msg">
> emitted, for compiler-rt to copy any call arguments to your logging handler.<br class="gmail_msg">
><br class="gmail_msg">
> For practical and performance reasons, only the first argument is supported, and<br class="gmail_msg">
> only up to 64 bits.<br class="gmail_msg">
><br class="gmail_msg">
> Reviewers: dberris<br class="gmail_msg">
><br class="gmail_msg">
> Reviewed By: dberris<br class="gmail_msg">
><br class="gmail_msg">
> Subscribers: llvm-commits<br class="gmail_msg">
><br class="gmail_msg">
> Differential Revision: <a href="https://reviews.llvm.org/D29702" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D29702</a><br class="gmail_msg">
><br class="gmail_msg">
> Added:<br class="gmail_msg">
> llvm/trunk/test/CodeGen/X86/xray-log-args.ll<br class="gmail_msg">
> Modified:<br class="gmail_msg">
> llvm/trunk/include/llvm/CodeGen/AsmPrinter.h<br class="gmail_msg">
> llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp<br class="gmail_msg">
><br class="gmail_msg">
> Modified: llvm/trunk/include/llvm/CodeGen/AsmPrinter.h<br class="gmail_msg">
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/CodeGen/AsmPrinter.h?rev=296998&r1=296997&r2=296998&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/CodeGen/AsmPrinter.h?rev=296998&r1=296997&r2=296998&view=diff</a><br class="gmail_msg">
> ==============================================================================<br class="gmail_msg">
> --- llvm/trunk/include/llvm/CodeGen/AsmPrinter.h (original)<br class="gmail_msg">
> +++ llvm/trunk/include/llvm/CodeGen/AsmPrinter.h Mon Mar 6 00:48:56 2017<br class="gmail_msg">
> @@ -222,6 +222,7 @@ public:<br class="gmail_msg">
> FUNCTION_ENTER = 0,<br class="gmail_msg">
> FUNCTION_EXIT = 1,<br class="gmail_msg">
> TAIL_CALL = 2,<br class="gmail_msg">
> + LOG_ARGS_ENTER = 3,<br class="gmail_msg">
> };<br class="gmail_msg">
><br class="gmail_msg">
> // The table will contain these structs that point to the sled, the function<br class="gmail_msg">
><br class="gmail_msg">
> Modified: llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp<br class="gmail_msg">
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp?rev=296998&r1=296997&r2=296998&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp?rev=296998&r1=296997&r2=296998&view=diff</a><br class="gmail_msg">
> ==============================================================================<br class="gmail_msg">
> --- llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp (original)<br class="gmail_msg">
> +++ llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp Mon Mar 6 00:48:56 2017<br class="gmail_msg">
> @@ -2756,8 +2756,11 @@ void AsmPrinter::recordSled(MCSymbol *Sl<br class="gmail_msg">
> SledKind Kind) {<br class="gmail_msg">
> auto Fn = MI.getParent()->getParent()->getFunction();<br class="gmail_msg">
> auto Attr = Fn->getFnAttribute("function-instrument");<br class="gmail_msg">
> + bool LogArgs = Fn->hasFnAttribute("xray-log-args");<br class="gmail_msg">
> bool AlwaysInstrument =<br class="gmail_msg">
> Attr.isStringAttribute() && Attr.getValueAsString() == "xray-always";<br class="gmail_msg">
> + if (Kind == SledKind::FUNCTION_ENTER && LogArgs)<br class="gmail_msg">
> + Kind = SledKind::LOG_ARGS_ENTER;<br class="gmail_msg">
> Sleds.emplace_back(<br class="gmail_msg">
> XRayFunctionEntry{ Sled, CurrentFnSym, Kind, AlwaysInstrument, Fn });<br class="gmail_msg">
> }<br class="gmail_msg">
><br class="gmail_msg">
> Added: llvm/trunk/test/CodeGen/X86/xray-log-args.ll<br class="gmail_msg">
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/xray-log-args.ll?rev=296998&view=auto" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/xray-log-args.ll?rev=296998&view=auto</a><br class="gmail_msg">
> ==============================================================================<br class="gmail_msg">
> --- llvm/trunk/test/CodeGen/X86/xray-log-args.ll (added)<br class="gmail_msg">
> +++ llvm/trunk/test/CodeGen/X86/xray-log-args.ll Mon Mar 6 00:48:56 2017<br class="gmail_msg">
> @@ -0,0 +1,35 @@<br class="gmail_msg">
> +; When logging arguments is specified, emit the entry sled accordingly.<br class="gmail_msg">
> +<br class="gmail_msg">
> +; RUN: llc -filetype=asm -o - -mtriple=x86_64-unknown-linux-gnu < %s | FileCheck %s<br class="gmail_msg">
> +; RUN: llc -filetype=asm -o - -mtriple=x86_64-darwin-unknown < %s | FileCheck %s<br class="gmail_msg">
> +<br class="gmail_msg">
> +define i32 @callee(i32 %arg) nounwind noinline uwtable "function-instrument"="xray-always" "xray-log-args"="1" {<br class="gmail_msg">
> + ret i32 %arg<br class="gmail_msg">
> +}<br class="gmail_msg">
> +; CHECK-LABEL: Lxray_synthetic_0:<br class="gmail_msg">
> +; CHECK: .quad {{\.?}}Lxray_sled_0<br class="gmail_msg">
> +; CHECK: .quad {{_?}}callee<br class="gmail_msg">
> +; CHECK: .byte 3<br class="gmail_msg">
> +; CHECK: .byte 1<br class="gmail_msg">
> +; CHECK: .{{(zero|space)}} 14<br class="gmail_msg">
> +; CHECK: .quad {{\.?}}Lxray_sled_1<br class="gmail_msg">
> +; CHECK: .quad {{_?}}callee<br class="gmail_msg">
> +; CHECK: .byte 1<br class="gmail_msg">
> +; CHECK: .byte 1<br class="gmail_msg">
> +; CHECK: .{{(zero|space)}} 14<br class="gmail_msg">
> +<br class="gmail_msg">
> +define i32 @caller(i32 %arg) nounwind noinline uwtable "function-instrument"="xray-always" "xray-log-args"="1" {<br class="gmail_msg">
> + %retval = tail call i32 @callee(i32 %arg)<br class="gmail_msg">
> + ret i32 %retval<br class="gmail_msg">
> +}<br class="gmail_msg">
> +; CHECK-LABEL: Lxray_synthetic_1:<br class="gmail_msg">
> +; CHECK: .quad {{\.?}}Lxray_sled_2<br class="gmail_msg">
> +; CHECK: .quad {{_?}}caller<br class="gmail_msg">
> +; CHECK: .byte 3<br class="gmail_msg">
> +; CHECK: .byte 1<br class="gmail_msg">
> +; CHECK: .{{(zero|space)}} 14<br class="gmail_msg">
> +; CHECK: .quad {{\.?}}Lxray_sled_3<br class="gmail_msg">
> +; CHECK: .quad {{_?}}caller<br class="gmail_msg">
> +; CHECK: .byte 2<br class="gmail_msg">
> +; CHECK: .byte 1<br class="gmail_msg">
> +; CHECK: .{{(zero|space)}} 14<br class="gmail_msg">
><br class="gmail_msg">
><br class="gmail_msg">
> _______________________________________________<br class="gmail_msg">
> llvm-commits mailing list<br class="gmail_msg">
> <a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a><br class="gmail_msg">
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="gmail_msg">
><br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
--<br class="gmail_msg">
<br class="gmail_msg">
-Bill Seurer<br class="gmail_msg">
<br class="gmail_msg">
</blockquote></div>