Sorry I missed this use case. I took your suggestion from previous revert and created BinaryStreamError. We can use that here. I made the changes everywhere else, but forgot about this one<br><div class="gmail_quote"><div dir="ltr">On Tue, Feb 28, 2017 at 9:23 PM NAKAMURA Takumi via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: chapuni<br class="gmail_msg">
Date: Tue Feb 28 23:11:41 2017<br class="gmail_msg">
New Revision: 296583<br class="gmail_msg">
<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=296583&view=rev" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project?rev=296583&view=rev</a><br class="gmail_msg">
Log:<br class="gmail_msg">
(Rewroking r296581) PDB/BinaryStreamTest.cpp: Appease mingw to avoid std::errc::no_buffer_space.<br class="gmail_msg">
<br class="gmail_msg">
Unfortunately, mingw's libstdc++ doesn't provide winsock2 errors.<br class="gmail_msg">
That said, we should avoid raising OS-oriented error code in our code.<br class="gmail_msg">
<br class="gmail_msg">
For now, I suggest to define custom error from std::error_category.<br class="gmail_msg">
See also; <a href="https://reviews.llvm.org/D20592" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D20592</a><br class="gmail_msg">
<br class="gmail_msg">
Modified:<br class="gmail_msg">
llvm/trunk/unittests/DebugInfo/PDB/BinaryStreamTest.cpp<br class="gmail_msg">
<br class="gmail_msg">
Modified: llvm/trunk/unittests/DebugInfo/PDB/BinaryStreamTest.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/DebugInfo/PDB/BinaryStreamTest.cpp?rev=296583&r1=296582&r2=296583&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/DebugInfo/PDB/BinaryStreamTest.cpp?rev=296583&r1=296582&r2=296583&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- llvm/trunk/unittests/DebugInfo/PDB/BinaryStreamTest.cpp (original)<br class="gmail_msg">
+++ llvm/trunk/unittests/DebugInfo/PDB/BinaryStreamTest.cpp Tue Feb 28 23:11:41 2017<br class="gmail_msg">
@@ -13,6 +13,7 @@<br class="gmail_msg">
#include "llvm/DebugInfo/MSF/BinaryStreamReader.h"<br class="gmail_msg">
#include "llvm/DebugInfo/MSF/BinaryStreamRef.h"<br class="gmail_msg">
#include "llvm/DebugInfo/MSF/BinaryStreamWriter.h"<br class="gmail_msg">
+#include "llvm/Support/Errc.h"<br class="gmail_msg">
#include "gtest/gtest.h"<br class="gmail_msg">
<br class="gmail_msg">
#include <unordered_map><br class="gmail_msg">
@@ -56,7 +57,7 @@ public:<br class="gmail_msg">
Error readBytes(uint32_t Offset, uint32_t Size,<br class="gmail_msg">
ArrayRef<uint8_t> &Buffer) override {<br class="gmail_msg">
if (Offset + Size > Data.size())<br class="gmail_msg">
- return errorCodeToError(make_error_code(std::errc::no_buffer_space));<br class="gmail_msg">
+ return errorCodeToError(make_error_code(llvm::errc::function_not_supported));<br class="gmail_msg">
uint32_t S = startIndex(Offset);<br class="gmail_msg">
auto Ref = Data.drop_front(S);<br class="gmail_msg">
if (Ref.size() >= Size) {<br class="gmail_msg">
@@ -75,7 +76,7 @@ public:<br class="gmail_msg">
Error readLongestContiguousChunk(uint32_t Offset,<br class="gmail_msg">
ArrayRef<uint8_t> &Buffer) override {<br class="gmail_msg">
if (Offset >= Data.size())<br class="gmail_msg">
- return errorCodeToError(make_error_code(std::errc::no_buffer_space));<br class="gmail_msg">
+ return errorCodeToError(make_error_code(llvm::errc::function_not_supported));<br class="gmail_msg">
uint32_t S = startIndex(Offset);<br class="gmail_msg">
Buffer = Data.drop_front(S);<br class="gmail_msg">
return Error::success();<br class="gmail_msg">
@@ -85,7 +86,7 @@ public:<br class="gmail_msg">
<br class="gmail_msg">
Error writeBytes(uint32_t Offset, ArrayRef<uint8_t> SrcData) override {<br class="gmail_msg">
if (Offset + SrcData.size() > Data.size())<br class="gmail_msg">
- return errorCodeToError(make_error_code(std::errc::no_buffer_space));<br class="gmail_msg">
+ return errorCodeToError(make_error_code(llvm::errc::function_not_supported));<br class="gmail_msg">
if (SrcData.empty())<br class="gmail_msg">
return Error::success();<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
llvm-commits mailing list<br class="gmail_msg">
<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="gmail_msg">
</blockquote></div>