Thanks for the heads up<br><div class="gmail_quote"><div dir="ltr">On Sat, Feb 25, 2017 at 12:14 AM Daniel Jasper <<a href="mailto:djasper@google.com">djasper@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="gmail_msg"><div class="gmail_extra gmail_msg"><div class="gmail_quote gmail_msg">On Sat, Feb 25, 2017 at 2:20 AM, Zachary Turner via llvm-commits <span dir="ltr" class="gmail_msg"><<a href="mailto:llvm-commits@lists.llvm.org" class="m_3890890517559823655gmail-cremed m_3890890517559823655gmail-cremed m_3890890517559823655cremed gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br class="gmail_msg"><blockquote class="gmail_quote gmail_msg" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Author: zturner<br class="gmail_msg">
Date: Fri Feb 24 19:20:08 2017<br class="gmail_msg">
New Revision: 296220<br class="gmail_msg">
<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=296220&view=rev" rel="noreferrer" class="m_3890890517559823655gmail-cremed m_3890890517559823655gmail-cremed m_3890890517559823655cremed gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project?rev=296220&view=rev</a><br class="gmail_msg">
Log:<br class="gmail_msg">
Re-enable BinaryStreamTest.StreamReaderObject.<br class="gmail_msg">
<br class="gmail_msg">
I had an invalid pointer / size calculation that was causing<br class="gmail_msg">
a stack smash. Should be fixed now.<br class="gmail_msg">
<br class="gmail_msg">
Modified:<br class="gmail_msg">
llvm/trunk/unittests/DebugInfo/PDB/BinaryStreamTest.cpp<br class="gmail_msg">
llvm/trunk/unittests/DebugInfo/PDB/MappedBlockStreamTest.cpp<br class="gmail_msg">
<br class="gmail_msg">
Modified: llvm/trunk/unittests/DebugInfo/PDB/BinaryStreamTest.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/DebugInfo/PDB/BinaryStreamTest.cpp?rev=296220&r1=296219&r2=296220&view=diff" rel="noreferrer" class="m_3890890517559823655gmail-cremed m_3890890517559823655gmail-cremed m_3890890517559823655cremed gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/DebugInfo/PDB/BinaryStreamTest.cpp?rev=296220&r1=296219&r2=296220&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- llvm/trunk/unittests/DebugInfo/PDB/BinaryStreamTest.cpp (original)<br class="gmail_msg">
+++ llvm/trunk/unittests/DebugInfo/PDB/BinaryStreamTest.cpp Fri Feb 24 19:20:08 2017<br class="gmail_msg">
@@ -443,39 +443,33 @@ TEST_F(BinaryStreamTest, StreamReaderEnu<br class="gmail_msg">
}<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
-//TEST_F(BinaryStreamTest, StreamReaderObject) {<br class="gmail_msg">
-// struct Foo {<br class="gmail_msg">
-// int X;<br class="gmail_msg">
-// double Y;<br class="gmail_msg">
-// char Z;<br class="gmail_msg">
-// };<br class="gmail_msg">
-//<br class="gmail_msg">
-// std::vector<Foo> Foos;<br class="gmail_msg">
-// Foos.push_back({-42, 42.42, 42});<br class="gmail_msg">
-// Foos.push_back({100, 3.1415, -89});<br class="gmail_msg"></blockquote><div class="gmail_msg"><br class="gmail_msg"></div></div></div></div><div dir="ltr" class="gmail_msg"><div class="gmail_extra gmail_msg"><div class="gmail_quote gmail_msg"><div class="gmail_msg">Note that this was triggering -Wc++11-narrowing, which I have silenced in r296249. Please double-check whether that's the right thing to do.</div></div></div></div><div dir="ltr" class="gmail_msg"><div class="gmail_extra gmail_msg"><div class="gmail_quote gmail_msg"><div class="gmail_msg"> </div><blockquote class="gmail_quote gmail_msg" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
-//<br class="gmail_msg">
-// std::vector<uint8_t> Bytes;<br class="gmail_msg">
-// Bytes.resize(2 * sizeof(Foo));<br class="gmail_msg">
-// Foo *FPtr = reinterpret_cast<Foo *>(&Bytes[0]);<br class="gmail_msg">
-// Foo *GPtr = FPtr + 1;<br class="gmail_msg">
-//<br class="gmail_msg">
-// ::memcpy(FPtr, &Foos[0], sizeof(Foo));<br class="gmail_msg">
-// ::memcpy(GPtr + sizeof(Foo), &Foos[1], sizeof(Foo));<br class="gmail_msg">
-//<br class="gmail_msg">
-// initialize(Bytes, 0);<br class="gmail_msg">
-//<br class="gmail_msg">
-// for (auto IS : InputStreams) {<br class="gmail_msg">
-// // 1. Reading object pointers.<br class="gmail_msg">
-// BinaryStreamReader Reader(*IS);<br class="gmail_msg">
-// const Foo *FPtrOut = nullptr;<br class="gmail_msg">
-// const Foo *GPtrOut = nullptr;<br class="gmail_msg">
-// ASSERT_NO_ERROR(Reader.readObject(FPtrOut));<br class="gmail_msg">
-// ASSERT_NO_ERROR(Reader.readObject(GPtrOut));<br class="gmail_msg">
-// EXPECT_EQ(0U, Reader.bytesRemaining());<br class="gmail_msg">
-// EXPECT_EQ(0, ::memcmp(FPtr, FPtrOut, sizeof(Foo)));<br class="gmail_msg">
-// EXPECT_EQ(0, ::memcmp(GPtr, GPtrOut, sizeof(Foo)));<br class="gmail_msg">
-// }<br class="gmail_msg">
-//}<br class="gmail_msg">
+TEST_F(BinaryStreamTest, StreamReaderObject) {<br class="gmail_msg">
+ struct Foo {<br class="gmail_msg">
+ int X;<br class="gmail_msg">
+ double Y;<br class="gmail_msg">
+ char Z;<br class="gmail_msg">
+ };<br class="gmail_msg">
+<br class="gmail_msg">
+ std::vector<Foo> Foos;<br class="gmail_msg">
+ Foos.push_back({-42, 42.42, 42});<br class="gmail_msg">
+ Foos.push_back({100, 3.1415, -89});<br class="gmail_msg">
+<br class="gmail_msg">
+ const uint8_t *Bytes = reinterpret_cast<const uint8_t *>(&Foos[0]);<br class="gmail_msg">
+<br class="gmail_msg">
+ initialize(makeArrayRef(Bytes, 2 * sizeof(Foo)), 0);<br class="gmail_msg">
+<br class="gmail_msg">
+ for (auto IS : InputStreams) {<br class="gmail_msg">
+ // 1. Reading object pointers.<br class="gmail_msg">
+ BinaryStreamReader Reader(*IS);<br class="gmail_msg">
+ const Foo *FPtrOut = nullptr;<br class="gmail_msg">
+ const Foo *GPtrOut = nullptr;<br class="gmail_msg">
+ ASSERT_NO_ERROR(Reader.readObject(FPtrOut));<br class="gmail_msg">
+ ASSERT_NO_ERROR(Reader.readObject(GPtrOut));<br class="gmail_msg">
+ EXPECT_EQ(0U, Reader.bytesRemaining());<br class="gmail_msg">
+ EXPECT_EQ(0, ::memcmp(&Foos[0], FPtrOut, sizeof(Foo)));<br class="gmail_msg">
+ EXPECT_EQ(0, ::memcmp(&Foos[1], GPtrOut, sizeof(Foo)));<br class="gmail_msg">
+ }<br class="gmail_msg">
+}<br class="gmail_msg">
<br class="gmail_msg">
TEST_F(BinaryStreamTest, StreamReaderStrings) {<br class="gmail_msg">
std::vector<uint8_t> Bytes = {'O', 'n', 'e', '\0', 'T', 'w', 'o',<br class="gmail_msg">
<br class="gmail_msg">
Modified: llvm/trunk/unittests/DebugInfo/PDB/MappedBlockStreamTest.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/DebugInfo/PDB/MappedBlockStreamTest.cpp?rev=296220&r1=296219&r2=296220&view=diff" rel="noreferrer" class="m_3890890517559823655gmail-cremed m_3890890517559823655gmail-cremed m_3890890517559823655cremed gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/DebugInfo/PDB/MappedBlockStreamTest.cpp?rev=296220&r1=296219&r2=296220&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- llvm/trunk/unittests/DebugInfo/PDB/MappedBlockStreamTest.cpp (original)<br class="gmail_msg">
+++ llvm/trunk/unittests/DebugInfo/PDB/MappedBlockStreamTest.cpp Fri Feb 24 19:20:08 2017<br class="gmail_msg">
@@ -37,7 +37,7 @@ public:<br class="gmail_msg">
uint32_t block_size() const { return 1; }<br class="gmail_msg">
uint32_t block_count() const { return Blocks.size(); }<br class="gmail_msg">
<br class="gmail_msg">
- endianness getEndian() const { return little; }<br class="gmail_msg">
+ endianness getEndian() const override { return little; }<br class="gmail_msg">
<br class="gmail_msg">
Error readBytes(uint32_t Offset, uint32_t Size,<br class="gmail_msg">
ArrayRef<uint8_t> &Buffer) override {<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
llvm-commits mailing list<br class="gmail_msg">
<a href="mailto:llvm-commits@lists.llvm.org" class="m_3890890517559823655gmail-cremed m_3890890517559823655gmail-cremed m_3890890517559823655cremed gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" class="m_3890890517559823655gmail-cremed m_3890890517559823655gmail-cremed m_3890890517559823655cremed gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="gmail_msg">
</blockquote></div></div></div></blockquote></div>