<div dir="ltr">Yes. i forgot we switched version numbering. Thanks!</div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature" data-smartmail="gmail_signature">~Craig</div></div>
<br><div class="gmail_quote">On Thu, Feb 23, 2017 at 12:38 PM, Robinson, Paul <span dir="ltr"><<a href="mailto:paul.robinson@sony.com" target="_blank">paul.robinson@sony.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
<br>
> -----Original Message-----<br>
> From: llvm-commits [mailto:<a href="mailto:llvm-commits-bounces@lists.llvm.org">llvm-commits-bounces@<wbr>lists.llvm.org</a>] On Behalf<br>
> Of Craig Topper via llvm-commits<br>
> Sent: Wednesday, February 22, 2017 7:22 PM<br>
> To: <a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
> Subject: [llvm] r295930 - [X86][IR] In AutoUpgrade, check explicitly for<br>
> xop.vpcmov and xop.vpcmov.256 instead of anything starting with xop.vpcmov<br>
><br>
> Author: ctopper<br>
> Date: Wed Feb 22 21:22:14 2017<br>
> New Revision: 295930<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=295930&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=295930&view=rev</a><br>
> Log:<br>
> [X86][IR] In AutoUpgrade, check explicitly for xop.vpcmov and<br>
> xop.vpcmov.256 instead of anything starting with xop.vpcmov<br>
><br>
> There were some older intrinsics that only existed for less than a month<br>
> in 2012 that still exist in some out of tree test files that start with<br>
> this string, but aren't able to be handled by the current upgrade code and<br>
> fire an assert. Now we'll go back to treating them as not intrinsics at<br>
> all and just passing them through to output.<br>
><br>
> Fixes PR32041, sort of.<br>
><br>
> Modified:<br>
>     llvm/trunk/lib/IR/AutoUpgrade.<wbr>cpp<br>
><br>
> Modified: llvm/trunk/lib/IR/AutoUpgrade.<wbr>cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-</a><br>
> project/llvm/trunk/lib/IR/<wbr>AutoUpgrade.cpp?rev=295930&r1=<wbr>295929&r2=295930&v<br>
> iew=diff<br>
> ==============================<wbr>==============================<wbr>==============<br>
> ====<br>
> --- llvm/trunk/lib/IR/AutoUpgrade.<wbr>cpp (original)<br>
> +++ llvm/trunk/lib/IR/AutoUpgrade.<wbr>cpp Wed Feb 22 21:22:14 2017<br>
> @@ -230,7 +230,8 @@ static bool ShouldUpgradeX86Intrinsic(Fu<br>
>        Name.startswith("avx2.pblendd.<wbr>") || // Added in 3.7<br>
>        Name.startswith("avx.<wbr>vbroadcastf128") || // Added in 4.0<br>
>        Name == "avx2.vbroadcasti128" || // Added in 3.7<br>
> -      Name.startswith("xop.vpcmov") || // Added in 3.8<br>
> +      Name == "xop.vpcmov" || // Added in 3.8<br>
> +      Name == "xop.vpcmov.256" || // Added in 4.1<br>
<br>
Shouldn't that be 5.0 not 4.1?<br>
--paulr<br>
<br>
>        Name.startswith("avx512.mask.<wbr>move.s") || // Added in 4.0<br>
>        (Name.startswith("xop.vpcom") && // Added in 3.2<br>
>         F->arg_size() == 2))<br>
><br>
><br>
> ______________________________<wbr>_________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>