<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p>Agree, thanks. Will fix it ASAP.<br>
</p>
<pre class="moz-signature" cols="72">-------------
Best regards,
Alexey Bataev</pre>
<div class="moz-cite-prefix">22.02.2017 1:10, David Blaikie пишет:<br>
</div>
<blockquote cite="mid:CAENS6EstqBh-BGHBD-LJGVHZ=6-JPYrVAdx0XWiqgHRms0EvPg@mail.gmail.com" type="cite">
<div dir="ltr">If it's really unused, perhaps leave it uninitialized - that way Clang (& other static analysis tools) can warn if it's accidentally used.</div>
<br>
<div class="gmail_quote">
<div dir="ltr">On Mon, Feb 20, 2017 at 12:15 AM Alexey Bataev via llvm-commits <<a moz-do-not-send="true" href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: abataev<br class="gmail_msg">
Date: Mon Feb 20 02:04:11 2017<br class="gmail_msg">
New Revision: 295642<br class="gmail_msg">
<br class="gmail_msg">
URL: <a moz-do-not-send="true" href="http://llvm.org/viewvc/llvm-project?rev=295642&view=rev" rel="noreferrer" class="gmail_msg" target="_blank">
http://llvm.org/viewvc/llvm-project?rev=295642&view=rev</a><br class="gmail_msg">
Log:<br class="gmail_msg">
[SLP] nullptr'ize initial value in `findBuildAggregate()`, NFC.<br class="gmail_msg">
<br class="gmail_msg">
Initial value of V is sett nullptr, as it is not used.<br class="gmail_msg">
<br class="gmail_msg">
Modified:<br class="gmail_msg">
llvm/trunk/lib/Transforms/Vectorize/SLPVectorizer.cpp<br class="gmail_msg">
<br class="gmail_msg">
Modified: llvm/trunk/lib/Transforms/Vectorize/SLPVectorizer.cpp<br class="gmail_msg">
URL: <a moz-do-not-send="true" href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Vectorize/SLPVectorizer.cpp?rev=295642&r1=295641&r2=295642&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">
http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Vectorize/SLPVectorizer.cpp?rev=295642&r1=295641&r2=295642&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- llvm/trunk/lib/Transforms/Vectorize/SLPVectorizer.cpp (original)<br class="gmail_msg">
+++ llvm/trunk/lib/Transforms/Vectorize/SLPVectorizer.cpp Mon Feb 20 02:04:11 2017<br class="gmail_msg">
@@ -4614,7 +4614,7 @@ static bool findBuildVector(InsertElemen<br class="gmail_msg">
static bool findBuildAggregate(InsertValueInst *IV,<br class="gmail_msg">
SmallVectorImpl<Value *> &BuildVector,<br class="gmail_msg">
SmallVectorImpl<Value *> &BuildVectorOpds) {<br class="gmail_msg">
- Value *V = IV;<br class="gmail_msg">
+ Value *V = nullptr;<br class="gmail_msg">
do {<br class="gmail_msg">
BuildVector.push_back(IV);<br class="gmail_msg">
BuildVectorOpds.push_back(IV->getInsertedValueOperand());<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
llvm-commits mailing list<br class="gmail_msg">
<a moz-do-not-send="true" href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a><br class="gmail_msg">
<a moz-do-not-send="true" href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="gmail_msg">
</blockquote>
</div>
</blockquote>
<br>
</body>
</html>