<div dir="ltr">The unreachable outside a switch is usually in the case of a fully covered switch to address the way that other compilers conservatively assume that a covered switch may still be skipped (due to values that are not enumerators, but in the representable range of the enumeration). In this case, of a switch with a  default (not fully covered), unreachable in the default is OK/good I think.</div><br><div class="gmail_quote"><div dir="ltr">On Tue, Feb 21, 2017 at 11:01 PM Sean Silva via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="gmail_msg"><div class="gmail_msg">Usually we put the unreachable outside the switch:</div><div class="gmail_msg"><br class="gmail_msg"></div><div class="gmail_msg"><a href="http://llvm.org/docs/CodingStandards.html#don-t-use-default-labels-in-fully-covered-switches-over-enumerations" class="gmail_msg" target="_blank">http://llvm.org/docs/CodingStandards.html#don-t-use-default-labels-in-fully-covered-switches-over-enumerations</a><br class="gmail_msg"></div></div><div class="gmail_extra gmail_msg"><br class="gmail_msg"><div class="gmail_quote gmail_msg">On Tue, Feb 21, 2017 at 5:01 PM, Rui Ueyama via llvm-commits <span dir="ltr" class="gmail_msg"><<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br class="gmail_msg"><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: ruiu<br class="gmail_msg">
Date: Tue Feb 21 19:01:45 2017<br class="gmail_msg">
New Revision: 295799<br class="gmail_msg">
<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=295799&view=rev" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project?rev=295799&view=rev</a><br class="gmail_msg">
Log:<br class="gmail_msg">
Fix -Wcovered-switch-default.<br class="gmail_msg">
<br class="gmail_msg">
Modified:<br class="gmail_msg">
    llvm/trunk/lib/Object/ArchiveWriter.cpp<br class="gmail_msg">
<br class="gmail_msg">
Modified: llvm/trunk/lib/Object/ArchiveWriter.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Object/ArchiveWriter.cpp?rev=295799&r1=295798&r2=295799&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Object/ArchiveWriter.cpp?rev=295799&r1=295798&r2=295799&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- llvm/trunk/lib/Object/ArchiveWriter.cpp (original)<br class="gmail_msg">
+++ llvm/trunk/lib/Object/ArchiveWriter.cpp Tue Feb 21 19:01:45 2017<br class="gmail_msg">
@@ -129,9 +129,7 @@ static bool isBSDLike(object::Archive::K<br class="gmail_msg">
   case object::Archive::K_BSD:<br class="gmail_msg">
   case object::Archive::K_DARWIN:<br class="gmail_msg">
     return true;<br class="gmail_msg">
-  case object::Archive::K_MIPS64:<br class="gmail_msg">
-  case object::Archive::K_DARWIN64:<br class="gmail_msg">
-  case object::Archive::K_COFF:<br class="gmail_msg">
+  default:<br class="gmail_msg">
     llvm_unreachable("not supported for writting");<br class="gmail_msg">
   }<br class="gmail_msg">
 }<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
llvm-commits mailing list<br class="gmail_msg">
<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="gmail_msg">
</blockquote></div><br class="gmail_msg"></div>
_______________________________________________<br class="gmail_msg">
llvm-commits mailing list<br class="gmail_msg">
<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="gmail_msg">
</blockquote></div>