<div dir="ltr">The test change looks wrong (we really need the instruction that disappeared), and, oddly enough, it wasn't in the review.<div>And I guess the original failure on the bots was masked by the build break in r295867.<br></div><div><br></div><div>Alexey, I'm going to revert it for now.</div><div><br></div><div>Thanks,</div><div>  Michael</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Feb 22, 2017 at 2:40 PM, Zachary Turner <span dir="ltr"><<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I'm getting some test failures with this.<div><br></div><div><div>FAIL: LLVM :: Transforms/SLPVectorizer/X86/<wbr>horizontal-list.ll (18687 of 19826)</div><div>******************** TEST 'LLVM :: Transforms/SLPVectorizer/X86/<wbr>horizontal-list.ll' FAILED ********************</div><div>Script:</div><div>--</div><div>D:/src/llvmbuild/ninja-mono/./<wbr>bin\opt.EXE -slp-vectorizer -slp-vectorize-hor -slp-vectorize-hor-store -S < D:\src\llvm-mono\llvm\test\<wbr>Transforms\SLPVectorizer\X86\<wbr>horizontal-list.ll -mtriple=x86_64-unknown-linux-<wbr>gnu -mcpu=bdver2 | D:/src/llvmbuild/ninja-mono/./<wbr>bin\FileCheck.EXE D:\src\llvm-mono\llvm\test\<wbr>Transforms\SLPVectorizer\X86\<wbr>horizontal-list.ll</div><div>D:/src/llvmbuild/ninja-mono/./<wbr>bin\opt.EXE -slp-vectorizer -slp-vectorize-hor -slp-vectorize-hor-store -S < D:\src\llvm-mono\llvm\test\<wbr>Transforms\SLPVectorizer\X86\<wbr>horizontal-list.ll -mtriple=x86_64-unknown-linux-<wbr>gnu -mcpu=bdver2 -slp-threshold=-10 | D:/src/llvmbuild/ninja-mono/./<wbr>bin\FileCheck.EXE D:\src\llvm-mono\llvm\test\<wbr>Transforms\SLPVectorizer\X86\<wbr>horizontal-list.ll --check-prefix=THRESHOLD</div><div>--</div><div>Exit Code: 1</div><div><br></div><div>Command Output (stdout):</div><div>--</div><div>$ "D:/src/llvmbuild/ninja-mono/.<wbr>/bin\opt.EXE" "-slp-vectorizer" "-slp-vectorize-hor" "-slp-vectorize-hor-store" "-S" "-mtriple=x86_64-unknown-<wbr>linux-gnu" "-mcpu=bdver2"</div><div>$ "D:/src/llvmbuild/ninja-mono/.<wbr>/bin\FileCheck.EXE" "D:\src\llvm-mono\llvm\test\<wbr>Transforms\SLPVectorizer\X86\<wbr>horizontal-list.ll"</div><div># command stderr:</div><div>D:\src\llvm-mono\llvm\test\<wbr>Transforms\SLPVectorizer\X86\<wbr>horizontal-list.ll:1683:15: error: expected string not found in input</div><div>; CHECK-NEXT: [[BIN_EXTRA3:%.*]] = add i32 [[BIN_EXTRA]], [[TMP9]]</div><div>              ^</div><div><stdin>:574:2: note: scanning from here</div><div> %r5 = add i32 %r4, undef</div><div> ^</div><div><stdin>:574:2: note: with variable "BIN_EXTRA" equal to "%bin.extra"</div><div> %r5 = add i32 %r4, undef</div><div> ^</div><div><stdin>:574:2: note: with variable "TMP9" equal to "%9"</div><div> %r5 = add i32 %r4, undef</div><div> ^</div><div><br></div><div>error: command failed with exit status: 1</div><div><br></div><div>--</div><div><br></div><div>********************</div><div>Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..</div><div>Testing Time: 255.91s</div><div>********************</div><div>Failing Tests (1):</div><div>    LLVM :: Transforms/SLPVectorizer/X86/<wbr>horizontal-list.ll</div><div><br></div><div>  Expected Passes    : 19126</div><div>  Expected Failures  : 186</div><div>  Unsupported Tests  : 513</div><div>  Unexpected Failures: 1</div><div>FAILED: cmd.exe /C "cd /D D:\src\llvmbuild\ninja-mono\<wbr>test && C:\Python27\python.exe D:/src/llvm-mono/llvm/utils/<wbr>lit/lit.py -sv --param llvm_site_config=D:/src/<wbr>llvmbuild/ninja-mono/test/lit.<wbr>site.cfg --param llvm_unit_site_config=D:/src/<wbr>llvmbuild/ninja-mono/test/<wbr>Unit/lit.site.cfg D:/src/llvmbuild/ninja-mono/<wbr>test"</div><div>ninja: build stopped: subcommand failed.</div></div><div><br></div><div><br></div><div>Could you please take a look?</div></div><br><div class="gmail_quote"><div><div class="h5"><div dir="ltr">On Wed, Feb 22, 2017 at 12:18 PM Alexey Bataev via Phabricator via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br></div></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5">This revision was automatically updated to reflect the committed changes.<br class="m_8511112489990871892gmail_msg">
Closed by commit rL295868: [SLP] Fix for PR32036: Vectorized horizontal reduction returning wrong result (authored by ABataev).<br class="m_8511112489990871892gmail_msg">
<br class="m_8511112489990871892gmail_msg">
Changed prior to commit:<br class="m_8511112489990871892gmail_msg">
  <a href="https://reviews.llvm.org/D30262?vs=89378&id=89401#toc" rel="noreferrer" class="m_8511112489990871892gmail_msg" target="_blank">https://reviews.llvm.org/<wbr>D30262?vs=89378&id=89401#toc</a><br class="m_8511112489990871892gmail_msg">
<br class="m_8511112489990871892gmail_msg">
Repository:<br class="m_8511112489990871892gmail_msg">
  rL LLVM<br class="m_8511112489990871892gmail_msg">
<br class="m_8511112489990871892gmail_msg">
<a href="https://reviews.llvm.org/D30262" rel="noreferrer" class="m_8511112489990871892gmail_msg" target="_blank">https://reviews.llvm.org/<wbr>D30262</a><br class="m_8511112489990871892gmail_msg">
<br class="m_8511112489990871892gmail_msg">
Files:<br class="m_8511112489990871892gmail_msg">
  llvm/trunk/lib/Transforms/<wbr>Vectorize/SLPVectorizer.cpp<br class="m_8511112489990871892gmail_msg">
  llvm/trunk/test/Transforms/<wbr>SLPVectorizer/X86/horizontal-<wbr>list.ll<br class="m_8511112489990871892gmail_msg">
<br class="m_8511112489990871892gmail_msg"></div></div>
______________________________<wbr>_________________<br class="m_8511112489990871892gmail_msg">
llvm-commits mailing list<br class="m_8511112489990871892gmail_msg">
<a href="mailto:llvm-commits@lists.llvm.org" class="m_8511112489990871892gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a><br class="m_8511112489990871892gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" class="m_8511112489990871892gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br class="m_8511112489990871892gmail_msg">
</blockquote></div>
</blockquote></div><br></div>