<div dir="ltr">Hans, could you pull this into release_40, please? It fixes building GLOBAL_ISEL on msc19.<div>(Note, GLOBAL_ISEL is disabled by default in release_40)<br><br><div class="gmail_quote"><div dir="ltr">On Fri, Jan 27, 2017 at 10:24 AM Quentin Colombet via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: qcolombet<br class="gmail_msg">
Date: Thu Jan 26 19:13:30 2017<br class="gmail_msg">
New Revision: 293246<br class="gmail_msg">
<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=293246&view=rev" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project?rev=293246&view=rev</a><br class="gmail_msg">
Log:<br class="gmail_msg">
[AArch64][LegalizerInfo] Specify the type of the opcode.<br class="gmail_msg">
<br class="gmail_msg">
This is an attempt to fix the win7 bot that does not seem to be very<br class="gmail_msg">
good at infering the type when it gets used in an initiliazer list.<br class="gmail_msg">
<br class="gmail_msg">
Modified:<br class="gmail_msg">
llvm/trunk/lib/Target/AArch64/AArch64LegalizerInfo.cpp<br class="gmail_msg">
<br class="gmail_msg">
Modified: llvm/trunk/lib/Target/AArch64/AArch64LegalizerInfo.cpp<br class="gmail_msg">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AArch64/AArch64LegalizerInfo.cpp?rev=293246&r1=293245&r2=293246&view=diff" rel="noreferrer" class="gmail_msg" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AArch64/AArch64LegalizerInfo.cpp?rev=293246&r1=293245&r2=293246&view=diff</a><br class="gmail_msg">
==============================================================================<br class="gmail_msg">
--- llvm/trunk/lib/Target/AArch64/AArch64LegalizerInfo.cpp (original)<br class="gmail_msg">
+++ llvm/trunk/lib/Target/AArch64/AArch64LegalizerInfo.cpp Thu Jan 26 19:13:30 2017<br class="gmail_msg">
@@ -36,7 +36,7 @@ AArch64LegalizerInfo::AArch64LegalizerIn<br class="gmail_msg">
const LLT v4s32 = LLT::vector(4, 32);<br class="gmail_msg">
const LLT v2s64 = LLT::vector(2, 64);<br class="gmail_msg">
<br class="gmail_msg">
- for (auto BinOp : {G_ADD, G_SUB, G_MUL, G_AND, G_OR, G_XOR, G_SHL}) {<br class="gmail_msg">
+ for (unsigned BinOp : {G_ADD, G_SUB, G_MUL, G_AND, G_OR, G_XOR, G_SHL}) {<br class="gmail_msg">
// These operations naturally get the right answer when used on<br class="gmail_msg">
// GPR32, even if the actual type is narrower.<br class="gmail_msg">
for (auto Ty : {s32, s64, v2s32, v4s32, v2s64})<br class="gmail_msg">
@@ -52,7 +52,7 @@ AArch64LegalizerInfo::AArch64LegalizerIn<br class="gmail_msg">
for (auto Ty : {s1, s8, s16, s32})<br class="gmail_msg">
setAction({G_GEP, 1, Ty}, WidenScalar);<br class="gmail_msg">
<br class="gmail_msg">
- for (auto BinOp : {G_LSHR, G_ASHR, G_SDIV, G_UDIV}) {<br class="gmail_msg">
+ for (unsigned BinOp : {G_LSHR, G_ASHR, G_SDIV, G_UDIV}) {<br class="gmail_msg">
for (auto Ty : {s32, s64})<br class="gmail_msg">
setAction({BinOp, Ty}, Legal);<br class="gmail_msg">
<br class="gmail_msg">
@@ -60,25 +60,25 @@ AArch64LegalizerInfo::AArch64LegalizerIn<br class="gmail_msg">
setAction({BinOp, Ty}, WidenScalar);<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
- for (auto BinOp : { G_SREM, G_UREM })<br class="gmail_msg">
+ for (unsigned BinOp : {G_SREM, G_UREM})<br class="gmail_msg">
for (auto Ty : { s1, s8, s16, s32, s64 })<br class="gmail_msg">
setAction({BinOp, Ty}, Lower);<br class="gmail_msg">
<br class="gmail_msg">
- for (auto Op : { G_UADDE, G_USUBE, G_SADDO, G_SSUBO, G_SMULO, G_UMULO }) {<br class="gmail_msg">
+ for (unsigned Op : {G_UADDE, G_USUBE, G_SADDO, G_SSUBO, G_SMULO, G_UMULO}) {<br class="gmail_msg">
for (auto Ty : { s32, s64 })<br class="gmail_msg">
setAction({Op, Ty}, Legal);<br class="gmail_msg">
<br class="gmail_msg">
setAction({Op, 1, s1}, Legal);<br class="gmail_msg">
}<br class="gmail_msg">
<br class="gmail_msg">
- for (auto BinOp : {G_FADD, G_FSUB, G_FMUL, G_FDIV})<br class="gmail_msg">
+ for (unsigned BinOp : {G_FADD, G_FSUB, G_FMUL, G_FDIV})<br class="gmail_msg">
for (auto Ty : {s32, s64})<br class="gmail_msg">
setAction({BinOp, Ty}, Legal);<br class="gmail_msg">
<br class="gmail_msg">
setAction({G_FREM, s32}, Libcall);<br class="gmail_msg">
setAction({G_FREM, s64}, Libcall);<br class="gmail_msg">
<br class="gmail_msg">
- for (auto MemOp : {G_LOAD, G_STORE}) {<br class="gmail_msg">
+ for (unsigned MemOp : {G_LOAD, G_STORE}) {<br class="gmail_msg">
for (auto Ty : {s8, s16, s32, s64, p0, v2s32})<br class="gmail_msg">
setAction({MemOp, Ty}, Legal);<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
llvm-commits mailing list<br class="gmail_msg">
<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="gmail_msg">
</blockquote></div></div></div>