<div dir="ltr"><div>Usually we put the unreachable outside the switch:</div><div><br></div><div><a href="http://llvm.org/docs/CodingStandards.html#don-t-use-default-labels-in-fully-covered-switches-over-enumerations">http://llvm.org/docs/CodingStandards.html#don-t-use-default-labels-in-fully-covered-switches-over-enumerations</a><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Feb 21, 2017 at 5:01 PM, Rui Ueyama via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: ruiu<br>
Date: Tue Feb 21 19:01:45 2017<br>
New Revision: 295799<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=295799&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=295799&view=rev</a><br>
Log:<br>
Fix -Wcovered-switch-default.<br>
<br>
Modified:<br>
    llvm/trunk/lib/Object/<wbr>ArchiveWriter.cpp<br>
<br>
Modified: llvm/trunk/lib/Object/<wbr>ArchiveWriter.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Object/ArchiveWriter.cpp?rev=295799&r1=295798&r2=295799&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/lib/Object/<wbr>ArchiveWriter.cpp?rev=295799&<wbr>r1=295798&r2=295799&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/lib/Object/<wbr>ArchiveWriter.cpp (original)<br>
+++ llvm/trunk/lib/Object/<wbr>ArchiveWriter.cpp Tue Feb 21 19:01:45 2017<br>
@@ -129,9 +129,7 @@ static bool isBSDLike(object::Archive::K<br>
   case object::Archive::K_BSD:<br>
   case object::Archive::K_DARWIN:<br>
     return true;<br>
-  case object::Archive::K_MIPS64:<br>
-  case object::Archive::K_DARWIN64:<br>
-  case object::Archive::K_COFF:<br>
+  default:<br>
     llvm_unreachable("not supported for writting");<br>
   }<br>
 }<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>