<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">
<div class="">The tricky thing is that the location expressions are being built before the backend. So any deference or XDREF needs to be created before the backend. For the XDEREF the target needs to say when it is required. If all this were to be sunk down
then would the notion of these location expressions also be abstracted so they are not DWARF expressions?</div>
<br class="">
<div>
<blockquote type="cite" class="">
<div class="">On Feb 18, 2017, at 2:47 PM, David Blaikie <<a href="mailto:dblaikie@gmail.com" class="">dblaikie@gmail.com</a>> wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<div dir="ltr" class="">I'd probably name it DwarfAddressSpace, if that's the notion. (if another client (CodeView debug info) needs a different address space scheme - such that we need multiple mappings, at that point I'd probably be inclined to sink it down
- use the llvm address space in the IR and map to format specific address spaces in the backend)</div>
<br class="">
<div class="gmail_quote">
<div dir="ltr" class="">On Sat, Feb 18, 2017 at 11:29 AM Konstantin Zhuravlyov via Phabricator <<a href="mailto:reviews@reviews.llvm.org" class="">reviews@reviews.llvm.org</a>> wrote:<br class="">
</div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
kzhuravl added inline comments.<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
================<br class="gmail_msg">
Comment at: include/llvm/IR/DebugInfoMetadata.h:715<br class="gmail_msg">
+ /// pointer or reference type respectively.<br class="gmail_msg">
+ Optional<unsigned> AddressSpace;<br class="gmail_msg">
+<br class="gmail_msg">
----------------<br class="gmail_msg">
Since this is a mapped address space and not LLVM address space (in our case it is Target-specific DWARF Address Space), the name should reflect that.<br class="gmail_msg">
<br class="gmail_msg">
We were thinking of prefixing it with "DI", but not sure what the policy is here. Seems like types are prefixed with "DI".<br class="gmail_msg">
<br class="gmail_msg">
Would there be any objections if we rename it to DIAddressSpace?<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<a href="https://reviews.llvm.org/D29670" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D29670</a><br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
</blockquote>
</div>
</div>
</blockquote>
</div>
<br class="">
</body>
</html>