<div dir="ltr">Minor typo to fix noted below.<div>Thanks,</div><div>Teresa<br><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Feb 11, 2017 at 9:05 PM, Davide Italiano via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: davide<br>
Date: Sat Feb 11 23:05:35 2017<br>
New Revision: 294885<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=294885&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=294885&view=rev</a><br>
Log:<br>
[lib/LTO] Add support for hotness optremarks in the new API.<br>
<br>
Added:<br>
llvm/trunk/test/LTO/<wbr>Resolution/X86/diagnostic-<wbr>handler-remarks-with-hotness.<wbr>ll<br>
Modified:<br>
llvm/trunk/tools/llvm-lto2/<wbr>llvm-lto2.cpp<br>
<br>
Added: llvm/trunk/test/LTO/<wbr>Resolution/X86/diagnostic-<wbr>handler-remarks-with-hotness.<wbr>ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/LTO/Resolution/X86/diagnostic-handler-remarks-with-hotness.ll?rev=294885&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/test/LTO/<wbr>Resolution/X86/diagnostic-<wbr>handler-remarks-with-hotness.<wbr>ll?rev=294885&view=auto</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/test/LTO/<wbr>Resolution/X86/diagnostic-<wbr>handler-remarks-with-hotness.<wbr>ll (added)<br>
+++ llvm/trunk/test/LTO/<wbr>Resolution/X86/diagnostic-<wbr>handler-remarks-with-hotness.<wbr>ll Sat Feb 11 23:05:35 2017<br>
@@ -0,0 +1,37 @@<br>
+; RUN: llvm-as < %s >%t.bc<br>
+<br>
+; RUN: rm -f %t.yaml<br>
+; RUN: llvm-lto2 -pass-remarks-output=%t.yaml \<br>
+; RUN: -pass-remarks-with-hotness \<br>
+; RUN: -r %t.bc,tinkywinky,p \<br>
+; RUN: -r %t.bc,patatino,px \<br>
+; RUN: -r %t.bc,main,px -o %t.o %t.bc<br>
+; RUN: cat %t.yaml | FileCheck %s -check-prefix=YAML<br>
+<br>
+; YAML: --- !Passed<br>
+; YAML-NEXT: Pass: inline<br>
+; YAML-NEXT: Name: Inlined<br>
+; YAML-NEXT: Function: main<br>
+; YAML-NEXT: Hotness: 300<br>
+; YAML-NEXT: Args:<br>
+; YAML-NEXT: - Callee: tinkywinky<br>
+; YAML-NEXT: - String: ' inlined into '<br>
+; YAML-NEXT: - Caller: main<br>
+; YAML-NEXT: ...<br>
+<br>
+target datalayout = "e-m:e-i64:64-f80:128-n8:16:<wbr>32:64-S128"<br>
+target triple = "x86_64-scei-ps4"<br>
+<br>
+declare i32 @patatino()<br>
+<br>
+define i32 @tinkywinky() {<br>
+ %a = call i32 @patatino()<br>
+ ret i32 %a<br>
+}<br>
+<br>
+define i32 @main() !prof !0 {<br>
+ %i = call i32 @tinkywinky()<br>
+ ret i32 %i<br>
+}<br>
+<br>
+!0 = !{!"function_entry_count", i64 300}<br>
<br>
Modified: llvm/trunk/tools/llvm-lto2/<wbr>llvm-lto2.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-lto2/llvm-lto2.cpp?rev=294885&r1=294884&r2=294885&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/tools/llvm-<wbr>lto2/llvm-lto2.cpp?rev=294885&<wbr>r1=294884&r2=294885&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/tools/llvm-lto2/<wbr>llvm-lto2.cpp (original)<br>
+++ llvm/trunk/tools/llvm-lto2/<wbr>llvm-lto2.cpp Sat Feb 11 23:05:35 2017<br>
@@ -94,6 +94,11 @@ static cl::opt<std::string><br>
OptRemarksOutput("pass-<wbr>remarks-output",<br>
cl::desc("YAML output file for optimization remarks"));<br>
<br>
+static cl::opt<bool> OptRemarksWithsHotness(<br></blockquote><div><br></div><div>Typo here and in use below: "Withs".</div><div>Teresa</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+ "pass-remarks-with-hotness",<br>
+ cl::desc("Whether to include hotness informations in the remarks.\n"<br>
+ "Has effect only if -pass-remarks-output is specified."));<br>
+<br>
static void check(Error E, std::string Msg) {<br>
if (!E)<br>
return;<br>
@@ -182,6 +187,7 @@ int main(int argc, char **argv) {<br>
<br>
// Optimization remarks.<br>
Conf.RemarksFilename = OptRemarksOutput;<br>
+ Conf.RemarksWithHotness = OptRemarksWithsHotness;<br>
<br>
// Run a custom pipeline, if asked for.<br>
Conf.OptPipeline = OptPipeline;<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><span style="font-family:Times;font-size:medium"><table cellspacing="0" cellpadding="0"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small"><td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Teresa Johnson |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tejohnson@google.com" target="_blank">tejohnson@google.com</a> |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"> 408-460-2413</td></tr></tbody></table></span></div>
</div></div></div>