<div dir="ltr">(if you feel like waiting for other opinions/perspectives, that's OK - they might have some other ideas, etc)</div><br><div class="gmail_quote"><div dir="ltr">On Thu, Feb 9, 2017 at 10:22 AM David Blaikie via Phabricator via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">dblaikie accepted this revision.<br class="gmail_msg">
dblaikie added a comment.<br class="gmail_msg">
This revision is now accepted and ready to land.<br class="gmail_msg">
<br class="gmail_msg">
Looks good - sounds like you answered your own main question: no way to find the graph from the node type, so the children ops do need an explicit template param.<br class="gmail_msg">
<br class="gmail_msg">
& I'd probably drop the "graph_" prefix - up to you though if you think that's better or worse, etc.<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
================<br class="gmail_msg">
Comment at: lib/Target/Hexagon/HexagonBitSimplify.cpp:264<br class="gmail_msg">
+  for (auto *DTN : graph_children<MachineDomTreeNode*>(MDT->getNode(&B)))<br class="gmail_msg">
+    Changed |= visitBlock(*(DTN->getBlock()), T, NewAVs);<br class="gmail_msg">
+<br class="gmail_msg">
----------------<br class="gmail_msg">
I probably wouldn't bother with the extra parens there:<br class="gmail_msg">
<br class="gmail_msg">
  *DTN->getBlock()<br class="gmail_msg">
<br class="gmail_msg">
rather than:<br class="gmail_msg">
<br class="gmail_msg">
  *(DTN->getBlock())<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<a href="https://reviews.llvm.org/D29767" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D29767</a><br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
llvm-commits mailing list<br class="gmail_msg">
<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a><br class="gmail_msg">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="gmail_msg">
</blockquote></div>