<div dir="ltr">Jonas, feel free to LGTM it to speed up the process :)</div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Feb 6, 2017 at 7:20 AM, Kostya Kortchinsky <span dir="ltr"><<a href="mailto:kostyak@google.com" target="_blank">kostyak@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi,<div><br><a href="https://reviews.llvm.org/D29527" target="_blank">https://reviews.llvm.org/<wbr>D29527</a> is out for review to fix this.<span class="HOEnZb"><font color="#888888"><div><br></div><div>Kostya</div></font></span></div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Feb 6, 2017 at 1:18 AM, Hahnfeld, Jonas <span dir="ltr"><<a href="mailto:Hahnfeld@itc.rwth-aachen.de" target="_blank">Hahnfeld@itc.rwth-aachen.de</a>></span> wrote:<br><!--
--><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br>
<div><div class="m_-9011879123930178650h5"><br>
> -----Original Message-----<br>
> From: llvm-commits [mailto:<a href="mailto:llvm-commits-bounces@lists.llvm.org" target="_blank">llvm-commits-bounces@l<wbr>ists.llvm.org</a>] On Behalf<br>
> Of Kostya Kortchinsky via llvm-commits<br>
> Sent: Friday, February 03, 2017 9:50 PM<br>
> To: <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
> Subject: [compiler-rt] r294037 - [scudo] 32-bit quarantine sizes adjustments<br>
> and bug fixes<br>
><br>
> Author: cryptoad<br>
> Date: Fri Feb 3 14:49:42 2017<br>
> New Revision: 294037<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=294037&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject?rev=294037&view=rev</a><br>
> Log:<br>
> [scudo] 32-bit quarantine sizes adjustments and bug fixes<br>
><br>
> Summary:<br>
> The local and global quarantine sizes were not offering a distinction for<br>
> 32-bit<br>
> and 64-bit platforms. This is addressed with lower values for 32-bit.<br>
><br>
> When writing additional tests for the quarantine, it was discovered that<br>
> when calling some of the allocator interface function prior to any<br>
> allocation<br>
> operation having occured, the test would crash due to the allocator not<br>
> being<br>
> initialized. This was addressed by making sure the allocator is initialized<br>
> for<br>
> those scenarios.<br>
><br>
> Relevant tests were added in interface.cpp and quarantine.cpp.<br>
><br>
> Last change being the removal of the extraneous link dependencies for the<br>
> tests thanks to rL293220, anf the addition of the gc-sections linker flag.<br>
><br>
> Reviewers: kcc, alekseyshl<br>
><br>
> Reviewed By: alekseyshl<br>
><br>
> Subscribers: llvm-commits<br>
><br>
> Differential Revision: <a href="https://reviews.llvm.org/D29341" rel="noreferrer" target="_blank">https://reviews.llvm.org/D2934<wbr>1</a><br>
><br>
> Modified:<br>
> compiler-rt/trunk/lib/scudo/s<wbr>cudo_allocator.cpp<br>
> compiler-rt/trunk/lib/scudo/s<wbr>cudo_flags.cpp<br>
> compiler-rt/trunk/lib/scudo/s<wbr>cudo_flags.inc<br>
> compiler-rt/trunk/test/scudo/<wbr>alignment.cpp<br>
> compiler-rt/trunk/test/scudo/<wbr>double-free.cpp<br>
> compiler-rt/trunk/test/scudo/<wbr>interface.cpp<br>
> compiler-rt/trunk/test/scudo/<wbr>lit.cfg<br>
> compiler-rt/trunk/test/scudo/<wbr>malloc.cpp<br>
> compiler-rt/trunk/test/scudo/<wbr>memalign.cpp<br>
> compiler-rt/trunk/test/scudo/<wbr>mismatch.cpp<br>
> compiler-rt/trunk/test/scudo/<wbr>options.cpp<br>
> compiler-rt/trunk/test/scudo/<wbr>overflow.cpp<br>
> compiler-rt/trunk/test/scudo/<wbr>preinit.cpp<br>
> compiler-rt/trunk/test/scudo/<wbr>quarantine.cpp<br>
> compiler-rt/trunk/test/scudo/<wbr>realloc.cpp<br>
> compiler-rt/trunk/test/scudo/<wbr>secondary.cpp<br>
> compiler-rt/trunk/test/scudo/<wbr>sized-delete.cpp<br>
> compiler-rt/trunk/test/scudo/<wbr>sizes.cpp<br>
><br>
</div></div>> [...]<br>
><br>
> Modified: compiler-rt/trunk/test/scudo/l<wbr>it.cfg<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/compiler-</a><br>
> rt/trunk/test/scudo/lit.cfg?re<wbr>v=294037&r1=294036&r2=294037&<wbr>view=diff<br>
> ==============================<wbr>============================<br>
<span>> ====================<br>
> --- compiler-rt/trunk/test/scudo/l<wbr>it.cfg (original)<br>
> +++ compiler-rt/trunk/test/scudo/l<wbr>it.cfg Fri Feb 3 14:49:42 2017<br>
> @@ -19,12 +19,12 @@ config.suffixes = ['.c', '.cc', '.cpp']<br>
> # C flags.<br>
> c_flags = ([config.target_cflags] +<br>
> ["-std=c++11",<br>
> - "-lrt",<br>
> - "-ldl",<br>
<br>
</span>With this change, I'm getting link errors for dlsym, shm_open and shm_unlink.<br>
Can we read these libraries?<br>
<br>
Thanks,<br>
Jonas<br>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>